Skip to content

Commit 51be2fc

Browse files
martimorsmartimors
authored
helm: Remove unused PVC resources (#12387)
1 parent 9ffd5bb commit 51be2fc

File tree

5 files changed

+51
-71
lines changed

5 files changed

+51
-71
lines changed

‎charts/airbyte/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.3.1
18+
version: 0.3.2
1919

2020
# This is the version number of the application being deployed. This version number should be
2121
# incremented each time you make changes to the application. Versions are not expected to

‎charts/airbyte/README.md

Lines changed: 46 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ Helm charts for Airbyte.
66

77
### Global Parameters
88

9-
| Name | Description | Value |
10-
| ---------------------- | -------------------------------------------- | ----- |
11-
| `global.imageRegistry` | Global Docker image registry | `""` |
12-
| `global.storageClass` | Global StorageClass for Persistent Volume(s) | `""` |
9+
| Name | Description | Value |
10+
| ---------------------- | ---------------------------- | ----- |
11+
| `global.imageRegistry` | Global Docker image registry | `""` |
1312

1413

1514
### Common Parameters
@@ -31,7 +30,7 @@ Helm charts for Airbyte.
3130
| `webapp.replicaCount` | Number of webapp replicas | `1` |
3231
| `webapp.image.repository` | The repository to use for the airbyte webapp image. | `airbyte/webapp` |
3332
| `webapp.image.pullPolicy` | the pull policy to use for the airbyte webapp image | `IfNotPresent` |
34-
| `webapp.image.tag` | The airbyte webapp image tag. Defaults to the chart's AppVersion | `0.36.6-alpha` |
33+
| `webapp.image.tag` | The airbyte webapp image tag. Defaults to the chart's AppVersion | `0.36.6-alpha` |
3534
| `webapp.podAnnotations` | Add extra annotations to the webapp pod(s) | `{}` |
3635
| `webapp.containerSecurityContext` | Security context for the container | `{}` |
3736
| `webapp.livenessProbe.enabled` | Enable livenessProbe on the webapp | `true` |
@@ -68,19 +67,35 @@ Helm charts for Airbyte.
6867

6968
### Scheduler Parameters
7069

71-
| Name | Description | Value |
72-
| ------------------------------ | ------------------------------------------------------------------- | ------------------- |
73-
| `scheduler.replicaCount` | Number of scheduler replicas | `1` |
74-
| `scheduler.image.repository` | The repository to use for the airbyte scheduler image. | `airbyte/scheduler` |
75-
| `scheduler.image.pullPolicy` | the pull policy to use for the airbyte scheduler image | `IfNotPresent` |
76-
| `scheduler.image.tag` | The airbyte scheduler image tag. Defaults to the chart's AppVersion | `0.36.6-alpha` |
77-
| `scheduler.podAnnotations` | Add extra annotations to the scheduler pod | `{}` |
78-
| `scheduler.resources.limits` | The resources limits for the scheduler container | `{}` |
79-
| `scheduler.resources.requests` | The requested resources for the scheduler container | `{}` |
80-
| `scheduler.nodeSelector` | Node labels for pod assignment | `{}` |
81-
| `scheduler.tolerations` | Tolerations for scheduler pod assignment. | `[]` |
82-
| `scheduler.log.level` | The log level to log at. | `INFO` |
83-
| `scheduler.extraEnv` | Additional env vars for scheduler pod(s). | `[]` |
70+
| Name | Description | Value |
71+
| ---------------------------------------------- | ------------------------------------------------------------------- | ------------------- |
72+
| `scheduler.replicaCount` | Number of scheduler replicas | `1` |
73+
| `scheduler.image.repository` | The repository to use for the airbyte scheduler image. | `airbyte/scheduler` |
74+
| `scheduler.image.pullPolicy` | the pull policy to use for the airbyte scheduler image | `IfNotPresent` |
75+
| `scheduler.image.tag` | The airbyte scheduler image tag. Defaults to the chart's AppVersion | `0.36.6-alpha` |
76+
| `scheduler.podAnnotations` | Add extra annotations to the scheduler pod | `{}` |
77+
| `scheduler.containerSecurityContext` | Security context for the container | `{}` |
78+
| `scheduler.livenessProbe.enabled` | Enable livenessProbe on the scheduler | `true` |
79+
| `scheduler.livenessProbe.initialDelaySeconds` | Initial delay seconds for livenessProbe | `5` |
80+
| `scheduler.livenessProbe.periodSeconds` | Period seconds for livenessProbe | `30` |
81+
| `scheduler.livenessProbe.timeoutSeconds` | Timeout seconds for livenessProbe | `1` |
82+
| `scheduler.livenessProbe.failureThreshold` | Failure threshold for livenessProbe | `3` |
83+
| `scheduler.livenessProbe.successThreshold` | Success threshold for livenessProbe | `1` |
84+
| `scheduler.readinessProbe.enabled` | Enable readinessProbe on the scheduler | `true` |
85+
| `scheduler.readinessProbe.initialDelaySeconds` | Initial delay seconds for readinessProbe | `5` |
86+
| `scheduler.readinessProbe.periodSeconds` | Period seconds for readinessProbe | `30` |
87+
| `scheduler.readinessProbe.timeoutSeconds` | Timeout seconds for readinessProbe | `1` |
88+
| `scheduler.readinessProbe.failureThreshold` | Failure threshold for readinessProbe | `3` |
89+
| `scheduler.readinessProbe.successThreshold` | Success threshold for readinessProbe | `1` |
90+
| `scheduler.resources.limits` | The resources limits for the scheduler container | `{}` |
91+
| `scheduler.resources.requests` | The requested resources for the scheduler container | `{}` |
92+
| `scheduler.nodeSelector` | Node labels for pod assignment | `{}` |
93+
| `scheduler.tolerations` | Tolerations for scheduler pod assignment. | `[]` |
94+
| `scheduler.affinity` | Affinity and anti-affinity for scheduler pod assignment. | `{}` |
95+
| `scheduler.log.level` | The log level to log at. | `INFO` |
96+
| `scheduler.extraEnv` | Additional env vars for scheduler pod(s). | `[]` |
97+
| `scheduler.extraVolumeMounts` | Additional volumeMounts for scheduler container(s). | `[]` |
98+
| `scheduler.extraVolumes` | Additional volumes for scheduler pod(s). | `[]` |
8499

85100

86101
### Pod Sweeper parameters
@@ -139,9 +154,6 @@ Helm charts for Airbyte.
139154
| `server.resources.requests` | The requested resources for the server container | `{}` |
140155
| `server.service.type` | The service type to use for the API server | `ClusterIP` |
141156
| `server.service.port` | The service port to expose the API server on | `8001` |
142-
| `server.persistence.accessMode` | The access mode for the airbyte server pvc | `ReadWriteOnce` |
143-
| `server.persistence.size` | The size of the pvc to use for the airbyte server pvc | `1Gi` |
144-
| `server.persistence.storageClass` | The storage class to use for the airbyte server pvc | `""` |
145157
| `server.nodeSelector` | Node labels for pod assignment | `{}` |
146158
| `server.tolerations` | Tolerations for server pod assignment. | `[]` |
147159
| `server.affinity` | Affinity and anti-affinity for server pod assignment. | `{}` |
@@ -191,6 +203,9 @@ Helm charts for Airbyte.
191203
| `bootloader.image.repository` | The repository to use for the airbyte bootloader image. | `airbyte/bootloader` |
192204
| `bootloader.image.pullPolicy` | the pull policy to use for the airbyte bootloader image | `IfNotPresent` |
193205
| `bootloader.image.tag` | The airbyte bootloader image tag. Defaults to the chart's AppVersion | `0.36.6-alpha` |
206+
| `bootloader.podAnnotations` | Add extra annotations to the bootloader pod | `{}` |
207+
| `bootloader.nodeSelector` | Node labels for pod assignment | `{}` |
208+
| `bootloader.tolerations` | Tolerations for worker pod assignment. | `[]` |
194209

195210

196211
### Temporal parameters
@@ -268,13 +283,17 @@ Helm charts for Airbyte.
268283
| `logs.gcs.credentials` | The path the GCS creds are written to | `""` |
269284
| `logs.gcs.credentialsJson` | Base64 encoded json GCP credentials file contents | `""` |
270285

286+
271287
### Minio chart overwrites
272288

273-
| Name | Description | Value |
274-
| -------------------------- | -------------------------------- | ---------- |
275-
| `minio.accessKey.password` | Minio Access Key | `minio` |
276-
| `minio.secretKey.password` | Minio Secret Key | `minio123` |
277-
| `jobs.resources.limits` | The resources limits for jobs | `{}` |
278-
| `jobs.resources.requests` | The requested resources for jobs | `{}` |
289+
| Name | Description | Value |
290+
| -------------------------- | -------------------------------------------- | ---------- |
291+
| `minio.accessKey.password` | Minio Access Key | `minio` |
292+
| `minio.secretKey.password` | Minio Secret Key | `minio123` |
293+
| `jobs.resources.limits` | The resources limits for jobs | `{}` |
294+
| `jobs.resources.requests` | The requested resources for jobs | `{}` |
295+
| `jobs.kube.annotations` | key/value annotations applied to kube jobs | `{}` |
296+
| `jobs.kube.nodeSelector` | key/value node selector applied to kube jobs | `{}` |
297+
| `jobs.kube.tolerations` | Tolerations for jobs.kube pod assignment. | `[]` |
279298

280299

‎charts/airbyte/templates/server/deployment.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -210,22 +210,13 @@ spec:
210210
securityContext: {{- toYaml .Values.server.containerSecurityContext | nindent 10 }}
211211
{{- end }}
212212
volumeMounts:
213-
- name: airbyte-data
214-
mountPath: /configs
215-
subPath: configs
216-
- name: airbyte-data
217-
mountPath: /workspace
218-
subPath: workspace
219213
- name: gcs-log-creds-volume
220214
mountPath: /secrets/gcs-log-creds
221215
readOnly: true
222216
{{- if .Values.server.extraVolumeMounts }}
223217
{{ toYaml .Values.server.extraVolumeMounts | nindent 8 }}
224218
{{- end }}
225219
volumes:
226-
- name: airbyte-data
227-
persistentVolumeClaim:
228-
claimName: {{ include "common.names.fullname" . }}-data
229220
- name: gcs-log-creds-volume
230221
secret:
231222
secretName: {{ include "common.names.fullname" . }}-gcs-log-creds

‎charts/airbyte/templates/server/pvc-data.yaml

Lines changed: 0 additions & 14 deletions
This file was deleted.

‎charts/airbyte/values.yaml

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
## @section Global Parameters
22

33
## @param global.imageRegistry Global Docker image registry
4-
## @param global.storageClass Global StorageClass for Persistent Volume(s)
54
##
65
global:
76
imageRegistry: ""
8-
storageClass: ""
97

108
## @section Common Parameters
119

@@ -512,20 +510,6 @@ server:
512510
type: ClusterIP
513511
port: 8001
514512

515-
## @param server.persistence.accessMode The access mode for the airbyte server pvc
516-
## @param server.persistence.size The size of the pvc to use for the airbyte server pvc
517-
persistence:
518-
size: 1Gi
519-
accessMode: ReadWriteOnce
520-
## @param server.persistence.storageClass The storage class to use for the airbyte server pvc
521-
## If defined, storageClassName: <storageClass>
522-
## If set to "-", storageClassName: "", which disables dynamic provisioning
523-
## If undefined (the default) or set to null, no storageClassName spec is
524-
## set, choosing the default provisioner. (gp2 on AWS, standard on
525-
## GKE, AWS & OpenStack)
526-
##
527-
storageClass: ""
528-
529513
## @param server.nodeSelector [object] Node labels for pod assignment
530514
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
531515
##
@@ -922,8 +906,8 @@ logs:
922906

923907
## Google Cloud Storage (GCS) Log Location Configuration
924908
## @param logs.gcs.bucket GCS bucket name
925-
## @param logs.gcs.credentials The path the GCS creds file is located
926-
## @param logs.gcs.credentialsJson Base64 encoded JSON credentials
909+
## @param logs.gcs.credentials The path the GCS creds are written to
910+
## @param logs.gcs.credentialsJson Base64 encoded json GCP credentials file contents
927911
gcs:
928912
bucket: ""
929913
# If you are mounting an existing secret to extraVolumes on scheduler, server and worker
@@ -965,12 +949,12 @@ jobs:
965949
kube:
966950
## JOB_KUBE_ANNOTATIONS
967951
## pod annotations of the sync job and the default pod annotations fallback for others jobs
968-
## @params jobs.kube.annotations [object] key/value annotations applied to kube jobs
952+
## @param jobs.kube.annotations [object] key/value annotations applied to kube jobs
969953
annotations: {}
970954

971955
## JOB_KUBE_NODE_SELECTORS
972956
## pod node selector of the sync job and the default pod node selector fallback for others jobs
973-
## @params jobs.kubeSelector [object] key/value node selector applied to kube jobs
957+
## @param jobs.kube.nodeSelector [object] key/value node selector applied to kube jobs
974958
nodeSelector: {}
975959

976960
## JOB_KUBE_TOLERATIONS

0 commit comments

Comments
 (0)