Skip to content

Commit 4c7ebfa

Browse files
authored
Destination e2e test: enable dedup (#38097)
1 parent a42532a commit 4c7ebfa

File tree

6 files changed

+963
-1640
lines changed

6 files changed

+963
-1640
lines changed

airbyte-integrations/connectors/destination-e2e-test/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ data:
22
connectorSubtype: unknown
33
connectorType: destination
44
definitionId: 2eb65e87-983a-4fd7-b3e3-9d9dc6eb8537
5-
dockerImageTag: 0.3.5
5+
dockerImageTag: 0.3.6
66
dockerRepository: airbyte/destination-e2e-test
77
githubIssueLabel: destination-e2e-test
88
icon: airbyte.svg

airbyte-integrations/connectors/destination-e2e-test/src/main/resources/spec.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"supportsIncremental": true,
44
"supportsNormalization": false,
55
"supportsDBT": false,
6-
"supported_destination_sync_modes": ["overwrite", "append"],
6+
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
77
"protocol_version": "0.2.1",
88
"connectionSpecification": {
99
"$schema": "http://json-schema.org/draft-07/schema#",

airbyte-integrations/connectors/destination-e2e-test/src/test-integration/java/io/airbyte/integrations/destination/e2e_test/TestingSilentDestinationAcceptanceTest.java

+14-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import java.util.Collections;
1616
import java.util.HashSet;
1717
import java.util.List;
18+
import org.junit.jupiter.api.Disabled;
19+
import org.junit.jupiter.api.Test;
1820

1921
public class TestingSilentDestinationAcceptanceTest extends DestinationAcceptanceTest {
2022

@@ -60,8 +62,18 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
6062
}
6163

6264
@Override
63-
public void testSyncNotFailsWithNewFields() {
64-
// Skip because `retrieveRecords` returns an empty list at all times.
65+
// Skip because `retrieveRecords` returns an empty list at all times.
66+
@Disabled
67+
@Test
68+
public void testSyncNotFailsWithNewFields() {}
69+
70+
@Override
71+
// This test assumes that dedup support means normalization support.
72+
// Override it to do nothing.
73+
@Disabled
74+
@Test
75+
public void testIncrementalDedupeSync() throws Exception {
76+
super.testIncrementalDedupeSync();
6577
}
6678

6779
}

dagger_engine_logs.tgz

-15.1 KB
Binary file not shown.

0 commit comments

Comments
 (0)