🎉 Source Stripe:: improve 404 handling for CheckoutSessionsLineItems stream (#10165)

* Improve 404 handling for CheckoutSessionsLineItems stream

Signed-off-by: Sergey Chvalyuk <[email protected]>

Author: grubberr

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json

@@ -2,7 +2,7 @@
   "sourceDefinitionId": "e094cb9a-26de-4645-8761-65c0c425d1de",
   "name": "Stripe",
   "dockerRepository": "airbyte/source-stripe",
-  "dockerImageTag": "0.1.27",
+  "dockerImageTag": "0.1.28",
   "documentationUrl": "https://docs.airbyte.io/integrations/sources/stripe",
   "icon": "stripe.svg"
 }

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -724,7 +724,7 @@
 - name: Stripe
   sourceDefinitionId: e094cb9a-26de-4645-8761-65c0c425d1de
   dockerRepository: airbyte/source-stripe
-  dockerImageTag: 0.1.27
+  dockerImageTag: 0.1.28
   documentationUrl: https://docs.airbyte.io/integrations/sources/stripe
   icon: stripe.svg
   sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

@@ -7713,7 +7713,7 @@
               type: "string"
               path_in_connector_config:
               - "client_secret"
-- dockerImage: "airbyte/source-stripe:0.1.27"
+- dockerImage: "airbyte/source-stripe:0.1.28"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/sources/stripe"
     connectionSpecification:

airbyte-integrations/connectors/source-stripe/Dockerfile

@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.27
+LABEL io.airbyte.version=0.1.28
 LABEL io.airbyte.name=airbyte/source-stripe

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

@@ -38,3 +38,7 @@ tests:
       configured_catalog_path: "integration_tests/full_refresh_configured_catalog.json"
     - config_path: "secrets/connected_account_config.json"
       configured_catalog_path: "integration_tests/connected_account_configured_catalog.json"
+      ignored_fields:
+        "invoices":
+          - invoice_pdf
+          - hosted_invoice_url

airbyte-integrations/connectors/source-stripe/setup.py

@@ -9,6 +9,7 @@
 
 TEST_REQUIREMENTS = [
     "pytest~=6.1",
+    "requests-mock",
 ]
 
 setup(

airbyte-integrations/connectors/source-stripe/source_stripe/streams.py

@@ -380,7 +380,15 @@ def request_params(self, stream_slice: Mapping[str, Any] = None, **kwargs):
         params["expand[]"] = ["data.discounts", "data.taxes"]
         return params
 
+    @property
+    def raise_on_http_errors(self):
+        return False
+
     def parse_response(self, response: requests.Response, stream_slice: Mapping[str, Any] = None, **kwargs) -> Iterable[Mapping]:
+        if response.status_code == 404:
+            self.logger.warning(response.json())
+            return
+        response.raise_for_status()
 
         response_json = response.json()
         data = response_json.get("data", [])

airbyte-integrations/connectors/source-stripe/unit_tests/test_streams.py

@@ -0,0 +1,49 @@
+#
+# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
+#
+
+
+from airbyte_cdk.models import SyncMode
+from source_stripe.streams import CheckoutSessionsLineItems
+
+
+def test_missed_id_child_stream(requests_mock):
+
+    session_id_missed = "cs_test_a165K4wNihuJlp2u3tknuohrvjAxyXFUB7nxZH3lwXRKJsadNEvIEWMUJ9"
+    session_id_exists = "cs_test_a1RjRHNyGUQOFVF3OkL8V8J0lZUASyVoCtsnZYG74VrBv3qz4245BLA1BP"
+
+    response_sessions = {
+        "data": [{"id": session_id_missed}, {"id": session_id_exists}],
+        "has_more": False,
+        "object": "list",
+        "url": "/v1/checkout/sessions",
+    }
+
+    response_sessions_line_items = {
+        "data": [{"id": "li_1JpAUUIEn5WyEQxnfGJT5MbL"}],
+        "has_more": False,
+        "object": "list",
+        "url": "/v1/checkout/sessions/{}/line_items".format(session_id_exists),
+    }
+
+    response_error = {
+        "error": {
+            "code": "resource_missing",
+            "doc_url": "https://stripe.com/docs/error-codes/resource-missing",
+            "message": "No such checkout session: '{}'".format(session_id_missed),
+            "param": "session",
+            "type": "invalid_request_error",
+        }
+    }
+
+    requests_mock.get("https://api.stripe.com/v1/checkout/sessions", json=response_sessions)
+    requests_mock.get(
+        "https://api.stripe.com/v1/checkout/sessions/{}/line_items".format(session_id_exists), json=response_sessions_line_items
+    )
+    requests_mock.get(
+        "https://api.stripe.com/v1/checkout/sessions/{}/line_items".format(session_id_missed), json=response_error, status_code=404
+    )
+
+    stream = CheckoutSessionsLineItems(start_date=None, account_id=None)
+    records = list(stream.read_records(sync_mode=SyncMode.full_refresh))
+    assert len(records) == 1

docs/integrations/sources/stripe.md

@@ -74,6 +74,7 @@ If you would like to test Airbyte using test data on Stripe, `sk_test_` and `rk_
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| 0.1.28 | 2022-02-08 | [10165](https://github.com/airbytehq/airbyte/pull/10165) | Improve 404 handling for `CheckoutSessionsLineItems` stream |
 | 0.1.27 | 2021-12-28 | [9148](https://github.com/airbytehq/airbyte/pull/9148) | Fix `date`, `arrival\_date` fields |
 | 0.1.26 | 2021-12-21 | [8992](https://github.com/airbytehq/airbyte/pull/8992) | Fix type `events.request` in schema |
 | 0.1.25 | 2021-11-25 | [8250](https://github.com/airbytehq/airbyte/pull/8250) | Rearrange setup fields |