fix: shows partialSuccess icon for all attempts instead of individual status (#10263)

* fix: shows partialSuccess icon for all attempts instead of individual status

* feat: add last attempt text to attempt details

* Update airbyte-webapp/src/components/JobItem/components/JobLogs.tsx

Co-authored-by: Tim Roes <[email protected]>

* fix: added text to i18n

Co-authored-by: Tim Roes <[email protected]>

Author: harshithmullapudi

airbyte-webapp/src/components/JobItem/JobItem.tsx

@@ -95,11 +95,7 @@ const JobItem: React.FC<IProps> = ({ shortInfo, ...props }) => {
           >
             {isOpen ? (
               isJobEntity(props) ? (
-                <JobLogs
-                  id={jobMeta.id}
-                  jobIsFailed={isFailed}
-                  isPartialSuccess={isPartialSuccess}
-                />
+                <JobLogs id={jobMeta.id} jobIsFailed={isFailed} />
               ) : (
                 <JobCurrentLogs
                   id={jobMeta.id}

airbyte-webapp/src/components/JobItem/components/JobLogs.tsx

@@ -4,17 +4,22 @@ import { FormattedMessage } from "react-intl";
 import Status from "core/statuses";
 import { useGetJob, useGetDebugInfoJob } from "services/job/JobService";
 
+import { Attempt } from "core/domain/job/Job";
+
 import Logs from "./Logs";
 import Tabs from "./Tabs";
 import { LogsDetails } from "./LogsDetails";
 
 type IProps = {
   id: number | string;
   jobIsFailed?: boolean;
-  isPartialSuccess?: boolean;
 };
 
-const JobLogs: React.FC<IProps> = ({ id, jobIsFailed, isPartialSuccess }) => {
+const isPartialSuccess = (attempt: Attempt) => {
+  return !!attempt.failureSummary?.partialSuccess;
+};
+
+const JobLogs: React.FC<IProps> = ({ id, jobIsFailed }) => {
   const job = useGetJob(id);
   const debugInfo = useGetDebugInfoJob(id);
 
@@ -32,7 +37,7 @@ const JobLogs: React.FC<IProps> = ({ id, jobIsFailed, isPartialSuccess }) => {
 
   const attemptsTabs = job.attempts.map((item, index) => ({
     id: index.toString(),
-    isPartialSuccess,
+    isPartialSuccess: isPartialSuccess(item.attempt),
     status:
       item.attempt.status === Status.FAILED ||
       item.attempt.status === Status.SUCCEEDED

airbyte-webapp/src/components/JobItem/components/LogsDetails.tsx

@@ -15,6 +15,10 @@ const CenteredDetails = styled.div`
   color: ${({ theme }) => theme.greyColor40};
   position: relative;
 `;
+const AttemptDetailsSection = styled.div`
+  padding-left: 10px;
+  padding-top: 10px;
+`;
 
 const LogsDetails: React.FC<{
   id: number | string;
@@ -24,7 +28,11 @@ const LogsDetails: React.FC<{
   jobDebugInfo?: JobDebugInfoMeta;
 }> = ({ path, logs, id, currentAttempt, jobDebugInfo }) => (
   <>
-    {currentAttempt && <AttemptDetails attempt={currentAttempt} />}
+    {currentAttempt && (
+      <AttemptDetailsSection>
+        <AttemptDetails attempt={currentAttempt} />
+      </AttemptDetailsSection>
+    )}
     <CenteredDetails>
       <div>{path}</div>
       {logs?.logLines && (

airbyte-webapp/src/components/JobItem/components/MainInfo.tsx

@@ -81,6 +81,11 @@ const Arrow = styled.div<{
     opacity: 1;
   }
 `;
+const Text = styled.div`
+  font-size: 12px;
+  font-weight: bold;
+  color: ${({ theme }) => theme.greyColor40};
+`;
 
 type IProps = {
   job: JobApiItem | JobInfo;
@@ -135,10 +140,17 @@ const MainInfo: React.FC<IProps> = ({
           {jobStatus}
           {shortInfo ? <FormattedMessage id="sources.additionLogs" /> : null}
           {attempts.length && !shortInfo ? (
-            <AttemptDetails
-              attempt={attempts[attempts.length - 1]}
-              configType={job.configType}
-            />
+            <div>
+              {attempts.length > 1 && (
+                <Text>
+                  <FormattedMessage id="sources.lastAttempt" />
+                </Text>
+              )}
+              <AttemptDetails
+                attempt={attempts[attempts.length - 1]}
+                configType={job.configType}
+              />
+            </div>
           ) : null}
         </Title>
       </InfoCell>

airbyte-webapp/src/locales/en.json

@@ -274,6 +274,7 @@
   "sources.copied": "Copied",
   "sources.failureOrigin": "Failure Origin",
   "sources.message": "Message",
+  "sources.lastAttempt": "Last attempt:",
 
   "destination.destinationSettings": "Destination Settings",
   "destination.newDestination": "+ new destination",