Skip to content

Commit 46ec5d5

Browse files
gosusnpnataly
authored andcommitted
Add versioning logging (#18618)
1 parent 7e5259a commit 46ec5d5

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/VersionedAirbyteMessageBufferedWriterFactory.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,13 @@
88
import io.airbyte.commons.protocol.AirbyteMessageVersionedMigratorFactory;
99
import io.airbyte.commons.version.Version;
1010
import java.io.BufferedWriter;
11+
import org.slf4j.Logger;
12+
import org.slf4j.LoggerFactory;
1113

1214
public class VersionedAirbyteMessageBufferedWriterFactory implements AirbyteMessageBufferedWriterFactory {
1315

16+
private static final Logger LOGGER = LoggerFactory.getLogger(VersionedAirbyteMessageBufferedWriterFactory.class);
17+
1418
private final AirbyteMessageSerDeProvider serDeProvider;
1519
private final AirbyteMessageVersionedMigratorFactory migratorFactory;
1620
private final Version protocolVersion;
@@ -25,6 +29,11 @@ public VersionedAirbyteMessageBufferedWriterFactory(final AirbyteMessageSerDePro
2529

2630
@Override
2731
public AirbyteMessageBufferedWriter createWriter(BufferedWriter bufferedWriter) {
32+
final boolean needMigration = !protocolVersion.getMajorVersion().equals(migratorFactory.getMostRecentVersion().getMajorVersion());
33+
LOGGER.info(
34+
"Writing messages to protocol version {}{}",
35+
protocolVersion.serialize(),
36+
needMigration ? ", messages will be downgraded from protocol version " + migratorFactory.getMostRecentVersion().serialize() : "");
2837
return new VersionedAirbyteMessageBufferedWriter<>(
2938
bufferedWriter,
3039
serDeProvider.getSerializer(protocolVersion).orElseThrow(),

airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/VersionedAirbyteStreamFactory.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,12 @@ public Stream<AirbyteMessage> create(final BufferedReader bufferedReader) {
9292
initializeForProtocolVersion(fallbackVersion);
9393
}
9494
}
95+
96+
final boolean needMigration = !protocolVersion.getMajorVersion().equals(migratorFactory.getMostRecentVersion().getMajorVersion());
97+
logger.info(
98+
"Reading messages from protocol version {}{}",
99+
protocolVersion.serialize(),
100+
needMigration ? ", messages will be upgraded to protocol version " + migratorFactory.getMostRecentVersion().serialize() : "");
95101
return super.create(bufferedReader);
96102
}
97103

0 commit comments

Comments
 (0)