Skip to content

Commit 41a12f6

Browse files
author
Joey Marshment-Howell
authored
🪟 🔧 Add typings to mock data (#19022)
* refactor mockConnection to TS * refactor mockDestination to TS * refactor mockWorkspace to TS
1 parent 3aacda4 commit 41a12f6

File tree

11 files changed

+738
-749
lines changed

11 files changed

+738
-749
lines changed

‎airbyte-webapp/src/components/CreateConnection/CreateConnectionForm.test.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,17 @@ import { act, render as tlr } from "@testing-library/react";
33
import userEvent from "@testing-library/user-event";
44
import React from "react";
55
import selectEvent from "react-select-event";
6-
import mockConnection from "test-utils/mock-data/mockConnection.json";
7-
import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
6+
import { mockConnection } from "test-utils/mock-data/mockConnection";
7+
import { mockDestination } from "test-utils/mock-data/mockDestination";
88
import { TestWrapper } from "test-utils/testutils";
99

10-
import { AirbyteCatalog } from "core/request/AirbyteClient";
1110
import { defaultFeatures, FeatureItem } from "hooks/services/Feature";
1211
import * as sourceHook from "hooks/services/useSourceHook";
1312

1413
import { CreateConnectionForm } from "./CreateConnectionForm";
1514

1615
jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
17-
useGetDestinationDefinitionSpecification: () => mockDest,
16+
useGetDestinationDefinitionSpecification: () => mockDestination,
1817
}));
1918

2019
jest.mock("services/workspaces/WorkspacesService", () => ({
@@ -40,7 +39,7 @@ describe("CreateConnectionForm", () => {
4039
const baseUseDiscoverSchema = {
4140
schemaErrorStatus: null,
4241
isLoading: false,
43-
schema: mockConnection.syncCatalog as AirbyteCatalog,
42+
schema: mockConnection.syncCatalog,
4443
catalogId: "",
4544
onDiscoverSchema: () => Promise.resolve(),
4645
};

‎airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { act, renderHook } from "@testing-library/react-hooks";
22
import React from "react";
3-
import mockConnection from "test-utils/mock-data/mockConnection.json";
4-
import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
5-
import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
3+
import { mockConnection } from "test-utils/mock-data/mockConnection";
4+
import { mockDestination } from "test-utils/mock-data/mockDestination";
5+
import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
66
import { TestWrapper } from "test-utils/testutils";
77

88
import { WebBackendConnectionUpdate } from "core/request/AirbyteClient";
@@ -11,7 +11,7 @@ import { useConnectionFormService } from "../ConnectionForm/ConnectionFormServic
1111
import { ConnectionEditServiceProvider, useConnectionEditService } from "./ConnectionEditService";
1212

1313
jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
14-
useGetDestinationDefinitionSpecification: () => mockDest,
14+
useGetDestinationDefinitionSpecification: () => mockDestination,
1515
}));
1616

1717
jest.mock("services/workspaces/WorkspacesService", () => ({

‎airbyte-webapp/src/hooks/services/ConnectionForm/ConnectionFormService.test.tsx

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import { act, renderHook } from "@testing-library/react-hooks";
22
import React from "react";
3-
import mockConnection from "test-utils/mock-data/mockConnection.json";
4-
import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
5-
import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
3+
import { mockConnection } from "test-utils/mock-data/mockConnection";
4+
import { mockDestination } from "test-utils/mock-data/mockDestination";
5+
import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
66
import { TestWrapper } from "test-utils/testutils";
77

8-
import { AirbyteCatalog, WebBackendConnectionRead } from "core/request/AirbyteClient";
98
import { FormError } from "utils/errorStatusMessage";
109

1110
import {
@@ -15,7 +14,7 @@ import {
1514
} from "./ConnectionFormService";
1615

1716
jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
18-
useGetDestinationDefinitionSpecification: () => mockDest,
17+
useGetDestinationDefinitionSpecification: () => mockDestination,
1918
}));
2019

2120
jest.mock("services/workspaces/WorkspacesService", () => ({
@@ -37,7 +36,7 @@ describe("ConnectionFormService", () => {
3736

3837
it("should take a partial Connection", async () => {
3938
const partialConnection: ConnectionOrPartialConnection = {
40-
syncCatalog: mockConnection.syncCatalog as AirbyteCatalog,
39+
syncCatalog: mockConnection.syncCatalog,
4140
source: mockConnection.source,
4241
destination: mockConnection.destination,
4342
};
@@ -57,7 +56,7 @@ describe("ConnectionFormService", () => {
5756
const { result } = renderHook(useConnectionFormService, {
5857
wrapper: Wrapper,
5958
initialProps: {
60-
connection: mockConnection as WebBackendConnectionRead,
59+
connection: mockConnection,
6160
mode: "create",
6261
refreshSchema,
6362
},
@@ -71,7 +70,7 @@ describe("ConnectionFormService", () => {
7170
const { result } = renderHook(useConnectionFormService, {
7271
wrapper: Wrapper,
7372
initialProps: {
74-
connection: mockConnection as WebBackendConnectionRead,
73+
connection: mockConnection,
7574
mode: "create",
7675
refreshSchema,
7776
},
@@ -86,7 +85,7 @@ describe("ConnectionFormService", () => {
8685
const { result } = renderHook(useConnectionFormService, {
8786
wrapper: Wrapper,
8887
initialProps: {
89-
connection: mockConnection as WebBackendConnectionRead,
88+
connection: mockConnection,
9089
mode: "create",
9190
refreshSchema,
9291
},
@@ -99,7 +98,7 @@ describe("ConnectionFormService", () => {
9998
const { result } = renderHook(useConnectionFormService, {
10099
wrapper: Wrapper,
101100
initialProps: {
102-
connection: mockConnection as WebBackendConnectionRead,
101+
connection: mockConnection,
103102
mode: "create",
104103
refreshSchema,
105104
},
@@ -112,7 +111,7 @@ describe("ConnectionFormService", () => {
112111
const { result } = renderHook(useConnectionFormService, {
113112
wrapper: Wrapper,
114113
initialProps: {
115-
connection: mockConnection as WebBackendConnectionRead,
114+
connection: mockConnection,
116115
mode: "create",
117116
refreshSchema,
118117
},

‎airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionReplicationTab.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import { render as tlr, act } from "@testing-library/react";
55
import userEvent from "@testing-library/user-event";
66
import React, { Suspense } from "react";
77
import selectEvent from "react-select-event";
8-
import mockConnection from "test-utils/mock-data/mockConnection.json";
9-
import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
10-
import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
8+
import { mockConnection } from "test-utils/mock-data/mockConnection";
9+
import { mockDestination } from "test-utils/mock-data/mockDestination";
10+
import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
1111
import { mockWorkspaceId } from "test-utils/mock-data/mockWorkspaceId";
1212
import { TestWrapper } from "test-utils/testutils";
1313

@@ -19,7 +19,7 @@ import * as connectionHook from "hooks/services/useConnectionHook";
1919
import { ConnectionReplicationTab } from "./ConnectionReplicationTab";
2020

2121
jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
22-
useGetDestinationDefinitionSpecification: () => mockDest,
22+
useGetDestinationDefinitionSpecification: () => mockDestination,
2323
}));
2424
jest.setTimeout(10000);
2525

0 commit comments

Comments
 (0)