Skip to content

Commit 3ffa11c

Browse files
antonioneto-hotmartVincent Kocvincentkococtavia-squidington-iii
authored
🐛 Source JIRA - Field correction bug causing stream connection to fail (#18505)
* max results field correction * added version notes and up * Update acceptance-test-config.yml * auto-bump connector version Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
1 parent 99195c0 commit 3ffa11c

File tree

7 files changed

+10
-6
lines changed

7 files changed

+10
-6
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@
627627
- name: Jira
628628
sourceDefinitionId: 68e63de2-bb83-4c7e-93fa-a8a9051e3993
629629
dockerRepository: airbyte/source-jira
630-
dockerImageTag: 0.2.22
630+
dockerImageTag: 0.2.23
631631
documentationUrl: https://docs.airbyte.com/integrations/sources/jira
632632
icon: jira.svg
633633
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5722,7 +5722,7 @@
57225722
supportsNormalization: false
57235723
supportsDBT: false
57245724
supported_destination_sync_modes: []
5725-
- dockerImage: "airbyte/source-jira:0.2.22"
5725+
- dockerImage: "airbyte/source-jira:0.2.23"
57265726
spec:
57275727
documentationUrl: "https://docs.airbyte.com/integrations/sources/jira"
57285728
connectionSpecification:
@@ -5753,7 +5753,7 @@
57535753
title: "Email"
57545754
description: "The user email for your Jira account."
57555755
max_results:
5756-
type: "number"
5756+
type: "integer"
57575757
title: "Max Results"
57585758
description: "Pagination max results (only for users stream)"
57595759
default: 50

airbyte-integrations/connectors/source-jira/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ RUN pip install .
1212
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
1313
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1414

15-
LABEL io.airbyte.version=0.2.22
15+
LABEL io.airbyte.version=0.2.23
1616
LABEL io.airbyte.name=airbyte/source-jira

airbyte-integrations/connectors/source-jira/acceptance-test-config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ connector_image: airbyte/source-jira:dev
44
tests:
55
spec:
66
- spec_path: "source_jira/spec.json"
7+
backward_compatibility_tests_config:
8+
disable_for_version: "0.2.22"
79
connection:
810
- config_path: "secrets/config.json"
911
status: "succeed"

airbyte-integrations/connectors/source-jira/source_jira/spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"description": "The user email for your Jira account."
2727
},
2828
"max_results": {
29-
"type": "number",
29+
"type": "integer",
3030
"title": "Max Results",
3131
"description": "Pagination max results (only for users stream)",
3232
"default": 50

airbyte-integrations/connectors/source-jira/source_jira/streams.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ def __init__(self, domain: str, projects: List[str], max_results: int, **kwargs)
10901090
self._max_results = max_results
10911091

10921092
def path(self, **kwargs) -> str:
1093-
if int(self._max_results) > 0:
1093+
if self._max_results > 0:
10941094
return "user/search?maxResults=" + str(self._max_results) + "&query="
10951095
return "user/search?query="
10961096

docs/integrations/sources/jira.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ The Jira connector should not run into Jira API limitations under normal usage.
9595

9696
| Version | Date | Pull Request | Subject |
9797
|:--------|:-----------|:------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------|
98+
| 0.2.23 | 2022-10-28 | [\#18505](hhttps://github.com/airbytehq/airbyte/pull/18505) | Correcting `max_results` bug introduced in connector stream |
99+
| 0.2.22 | 2022-10-03 | [\#16944](hhttps://github.com/airbytehq/airbyte/pull/16944) | Adds support for `max_results` to `users` stream |
98100
| 0.2.22 | 2022-10-03 | [\#16944](hhttps://github.com/airbytehq/airbyte/pull/16944) | Adds support for `max_results` to `users` stream |
99101
| 0.2.21 | 2022-07-28 | [\#15135](hhttps://github.com/airbytehq/airbyte/pull/15135) | Adds components to `fields` object on `issues` stream |
100102
| 0.2.20 | 2022-05-25 | [\#13202](https://github.com/airbytehq/airbyte/pull/13202) | Adds resolutiondate to `fields` object on `issues` stream |

0 commit comments

Comments
 (0)