Skip to content

Commit 3c62abe

Browse files
allow BaseTypingDedupingTest to be interrupted (#37854)
When timing out, the LoggingInterceptor attempts to interrupt the test-executing thread. Unfortunately, the `CompletableFuture.join()` call is non-interruptible, which means we still had tests that were hanging forever. This changes it with `CompletableFuture.get()`, which is interruptible (even though the difference in behavior is not clearly documented. One has to notice that `get()` throws an `InterruptedException` while `join()` doesn't).
1 parent d31f0dd commit 3c62abe

File tree

1 file changed

+1
-1
lines changed
  • airbyte-cdk/java/airbyte-cdk/typing-deduping/src/testFixtures/kotlin/io/airbyte/integrations/base/destination/typing_deduping

1 file changed

+1
-1
lines changed

airbyte-cdk/java/airbyte-cdk/typing-deduping/src/testFixtures/kotlin/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ abstract class BaseTypingDedupingTest {
11121112
// TODO Eventually we'll want to somehow extract the state messages while a sync is running,
11131113
// to
11141114
// verify checkpointing.
1115-
destinationOutputFuture.join()
1115+
destinationOutputFuture.get()
11161116
destination.close()
11171117
}
11181118

0 commit comments

Comments
 (0)