Skip to content

Commit 39402c1

Browse files
franviera92xpuska513marcosmarxm
authored
Helm: set new attribute (#22114)
* set new helm attribute * change to camelCase --------- Co-authored-by: Kyryl Skobylko <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
1 parent 1807c8f commit 39402c1

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

charts/airbyte/templates/env-configmap.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ data:
4242
{{- end }}
4343
JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: "0.29.15.001"
4444
LOCAL_ROOT: /tmp/airbyte_local
45-
RUN_DATABASE_MIGRATION_ON_STARTUP: "true"
45+
RUN_DATABASE_MIGRATION_ON_STARTUP: {{ .Values.airbyte-bootloader.runDatabaseMigrationsOnStartup | default "true" }}
4646
S3_LOG_BUCKET: {{ .Values.global.logs.s3.bucket | quote }}
4747
S3_LOG_BUCKET_REGION: {{ .Values.global.logs.s3.bucketRegion | quote }}
4848
S3_MINIO_ENDPOINT: {{ include "airbyte.minio.endpoint" . | quote }}
@@ -58,9 +58,9 @@ data:
5858
WORKSPACE_ROOT: /workspace
5959
METRIC_CLIENT: {{ .Values.global.metrics.metricClient | default "" | quote }}
6060
OTEL_COLLECTOR_ENDPOINT: {{ .Values.global.metrics.otelCollectorEndpoint | default "" | quote }}
61-
ACTIVITY_MAX_ATTEMPT: ""
62-
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
63-
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
61+
ACTIVITY_MAX_ATTEMPT: {{ .Values.worker.activityMaxAttempt | default "" }}
62+
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activityInitialDelayBetweenAttemptsSeconds | default "" }}
63+
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activityMaxDelayBetweenAttemptsSeconds | default "" }}
6464
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS: ""
6565
USE_STREAM_CAPABLE_STATE: "true"
6666
AUTO_DETECT_SCHEMA: "true"
@@ -71,5 +71,5 @@ data:
7171
WORKER_LOGS_STORAGE_TYPE: {{ .Values.global.logs.storage.type | quote }}
7272
WORKER_STATE_STORAGE_TYPE: {{ .Values.global.state.storage.type | quote }}
7373
SHOULD_RUN_NOTIFY_WORKFLOWS: "false"
74-
MAX_NOTIFY_WORKERS: "5"
74+
MAX_NOTIFY_WORKERS: {{ .Values.worker.maxNotifyWorkers | default "5" }}
7575
{{- end }}

charts/airbyte/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,11 @@ worker:
819819
enabled: true
820820
image: ""
821821

822+
## current no exist documentations
823+
activityMaxAttempt: ""
824+
activityInitialDelayBetweenAttemptsSeconds: ""
825+
activityMaxDelayBetweenAttemptsSeconds: ""
826+
822827
## @section Metrics parameters
823828
metrics:
824829
enabled: false
@@ -1057,6 +1062,9 @@ airbyte-bootloader:
10571062
##
10581063
extraVolumes: []
10591064

1065+
## run database migrations on startup true|false
1066+
runDatabaseMigrationsOnStartup: "true"
1067+
10601068
## @section Temporal parameters
10611069
## TODO: Move to consuming temporal from a dedicated helm chart
10621070

charts/airbyte/values.yaml.test

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -807,6 +807,10 @@ worker:
807807
enabled: true
808808
image: ""
809809

810+
activityMaxAttempt: ""
811+
activityInitialDelayBetweenAttemptsSeconds: ""
812+
activityMaxDelayBetweenAttemptsSeconds: ""
813+
810814
## @section Metrics parameters
811815
metrics:
812816
enabled: false
@@ -1045,6 +1049,9 @@ airbyte-bootloader:
10451049
##
10461050
extraVolumes: []
10471051

1052+
## run database migrations on startup true|false
1053+
runDatabaseMigrationsOnStartup: "true"
1054+
10481055
## @section Temporal parameters
10491056
## TODO: Move to consuming temporal from a dedicated helm chart
10501057

0 commit comments

Comments
 (0)