Use cypress dashboard and stabilize e2e tests (#10807)

* Record e2e tests to cypress dashboard

* Make env variable accessible in script

* Improve e2e_test script

* Properly wait for server to be ready

* Isolate test suites better

* More test isolation

* Revert baseUrl for development

Author: timroes

.github/workflows/gradle.yml

@@ -407,6 +407,8 @@ jobs:
         run: SUB_BUILD=PLATFORM ./gradlew --no-daemon assemble --scan
 
       - name: Run End-to-End Frontend Tests
+        env:
+          CYPRESS_WEBAPP_KEY: ${{ secrets.CYPRESS_WEBAPP_KEY }}
         run: ./tools/bin/e2e_test.sh
   # In case of self-hosted EC2 errors, remove this block.
   stop-frontend-test-runner:

airbyte-webapp-e2e-tests/build.gradle

@@ -13,8 +13,15 @@ node {
 
 task e2etest(type: NpmTask) {
     dependsOn npmInstall
-
-    args = ['run', 'cypress:ci']
+    // If the cypressWebappKey property has been set from the outside (see tools/bin/e2e_test.sh)
+    // we'll record the cypress session, otherwise we're not recording
+    def recordCypress = project.hasProperty('cypressWebappKey') && project.getProperty('cypressWebappKey')
+    if (recordCypress) {
+        environment = [CYPRESS_KEY: project.getProperty('cypressWebappKey')]
+        args = ['run', 'cypress:ci:record']
+    } else {
+        args = ['run', 'cypress:ci']
+    }
     inputs.files fileTree('cypress')
     inputs.file 'package.json'
     inputs.file 'package-lock.json'

airbyte-webapp-e2e-tests/cypress.json

@@ -1,4 +1,5 @@
 {
+  "projectId": "916nvw",
   "baseUrl": "http://localhost:3000",
   "testFiles": [
     "base.spec.js",

airbyte-webapp-e2e-tests/cypress/integration/connection.spec.js

@@ -1,12 +1,16 @@
 describe("Connection main actions", () => {
+  beforeEach(() => {
+    cy.initialSetupCompleted();
+  });
+
   it("Create new connection", () => {
     cy.createTestConnection("Test connection source cypress", "Test destination cypress");
 
     cy.get("div").contains("Test connection source cypress").should("exist");
     cy.get("div").contains("Test destination cypress").should("exist");
   });
 
-  it.only("Update connection", () => {
+  it("Update connection", () => {
     cy.intercept("/api/v1/web_backend/connections/update").as("updateConnection");
 
     cy.createTestConnection("Test update connection source cypress", "Test update connection destination cypress");

airbyte-webapp-e2e-tests/cypress/integration/destination.spec.js

@@ -1,4 +1,8 @@
 describe("Destination main actions", () => {
+  beforeEach(() => {
+    cy.initialSetupCompleted();
+  });
+
   it("Create new destination", () => {
     cy.createTestDestination("Test destination cypress");
 

airbyte-webapp-e2e-tests/cypress/integration/onboarding.spec.js

@@ -1,4 +1,8 @@
 describe("Preferences actions", () => {
+  beforeEach(() => {
+    cy.initialSetupCompleted(false);
+  });
+
   it("Should redirect to onboarding after email is entered", () => {
     cy.visit("/preferences");
     cy.url().should("include", `/preferences`);

airbyte-webapp-e2e-tests/cypress/integration/source.spec.js

@@ -1,4 +1,8 @@
 describe("Source main actions", () => {
+  beforeEach(() => {
+    cy.initialSetupCompleted();
+  });
+
   it("Create new source", () => {
     cy.createTestSource("Test source cypress");
 

airbyte-webapp-e2e-tests/cypress/support/commands/index.ts

@@ -3,3 +3,4 @@ import "./sidebar";
 import "./source";
 import "./destination";
 import "./connection";
+import "./workspaces";

airbyte-webapp-e2e-tests/cypress/support/commands/workspaces.js

@@ -0,0 +1,10 @@
+Cypress.Commands.add("initialSetupCompleted", (completed = true) => {
+  // Modify the workspaces/list response to mark every workspace as "initialSetupComplete" to ensure we're not showing
+  // the setup/preference page for any workspace if this method got called.
+  cy.intercept("POST", "/api/v1/workspaces/list", (req) => {
+    req.continue(res => {
+      res.body.workspaces = res.body.workspaces.map(ws => ({ ...ws, initialSetupComplete: completed }));
+      res.send(res.body);
+    });
+  });
+});

airbyte-webapp-e2e-tests/package.json

@@ -4,7 +4,8 @@
   "description": "Airbyte e2e testing",
   "scripts": {
     "cypress:open": "cypress open",
-    "cypress:ci": "CYPRESS_BASE_URL=http://localhost:8000 cypress run"
+    "cypress:ci": "CYPRESS_BASE_URL=http://localhost:8000 cypress run",
+    "cypress:ci:record": "CYPRESS_BASE_URL=http://localhost:8000 cypress run --record --key $CYPRESS_KEY"
   },
   "eslintConfig": {
     "env": {