Skip to content

Commit 3525225

Browse files
authored
Destination dev null: support dedup (#38118)
1 parent 09ad5e6 commit 3525225

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

airbyte-integrations/connectors/destination-dev-null/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ data:
22
connectorSubtype: file
33
connectorType: destination
44
definitionId: a7bcc9d8-13b3-4e49-b80d-d020b90045e3
5-
dockerImageTag: 0.3.2
5+
dockerImageTag: 0.3.3
66
dockerRepository: airbyte/destination-dev-null
77
githubIssueLabel: destination-dev-null
88
icon: airbyte.svg

airbyte-integrations/connectors/destination-dev-null/src/test-integration/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java

+14-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
import java.util.Collections;
1515
import java.util.HashSet;
1616
import java.util.List;
17+
import org.junit.jupiter.api.Disabled;
18+
import org.junit.jupiter.api.Test;
1719

1820
public class DevNullDestinationAcceptanceTest extends DestinationAcceptanceTest {
1921

@@ -59,8 +61,18 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
5961
}
6062

6163
@Override
62-
public void testSyncNotFailsWithNewFields() {
63-
// Skip because `retrieveRecords` returns an empty list at all times.
64+
// Skip because `retrieveRecords` returns an empty list at all times.
65+
@Disabled
66+
@Test
67+
public void testSyncNotFailsWithNewFields() {}
68+
69+
@Override
70+
// This test assumes that dedup support means normalization support.
71+
// Override it to do nothing.
72+
@Disabled
73+
@Test
74+
public void testIncrementalDedupeSync() throws Exception {
75+
super.testIncrementalDedupeSync();
6476
}
6577

6678
}

airbyte-integrations/connectors/destination-dev-null/src/test/resources/expected_spec.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"supportsIncremental": true,
44
"supportsNormalization": false,
55
"supportsDBT": false,
6-
"supported_destination_sync_modes": ["overwrite", "append"],
6+
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
77
"protocol_version": "0.2.1",
88
"connectionSpecification": {
99
"$schema": "http://json-schema.org/draft-07/schema#",

docs/integrations/destinations/dev-null.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ The Airbyte `dev-null` Destination. This destination is for testing and debuggin
66

77
| Version | Date | Pull Request | Subject |
88
| :------ | :--------- | :------------------------------------------------------- | :---------------- |
9+
| 0.3.3 | 2023-05-08 | [38118](https://github.com/airbytehq/airbyte/pull/38118) | Support dedup |
910
| 0.3.2 | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Support Refreshes |
1011
| 0.3.0 | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Change Schema |
1112
| 0.2.7 | 2022-08-08 | [13932](https://github.com/airbytehq/airbyte/pull/13932) | Bump version |

0 commit comments

Comments
 (0)