Skip to content

Commit 33f3a60

Browse files
committed
Fix tests
1 parent 59b8eee commit 33f3a60

File tree

3 files changed

+30
-3
lines changed

3 files changed

+30
-3
lines changed

airbyte-ci/connectors/pipelines/poetry.lock

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

airbyte-ci/connectors/pipelines/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ airbyte-protocol-models = "*"
2020
tabulate = "^0.8.9"
2121
jinja2 = "^3.0.2"
2222
requests = "^2.28.2"
23-
connector-ops = {path = "../connector_ops"}
23+
connector-ops = {path = "../connector_ops", develop = true}
2424
toml = "^0.10.2"
2525
sentry-sdk = "^1.28.1"
2626

airbyte-ci/connectors/pipelines/tests/test_commands/test_groups/test_connectors.py

+27
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def test_get_selected_connectors_by_name_no_file_modification():
2525
selected_languages=(),
2626
modified=False,
2727
metadata_changes_only=False,
28+
metadata_query=None,
2829
modified_files=set(),
2930
)
3031

@@ -41,6 +42,7 @@ def test_get_selected_connectors_by_support_level_no_file_modification():
4142
selected_languages=(),
4243
modified=False,
4344
metadata_changes_only=False,
45+
metadata_query=None,
4446
modified_files=set(),
4547
)
4648

@@ -54,6 +56,7 @@ def test_get_selected_connectors_by_language_no_file_modification():
5456
selected_languages=(ConnectorLanguage.LOW_CODE,),
5557
modified=False,
5658
metadata_changes_only=False,
59+
metadata_query=None,
5760
modified_files=set(),
5861
)
5962

@@ -69,6 +72,7 @@ def test_get_selected_connectors_by_name_with_file_modification():
6972
selected_languages=(),
7073
modified=False,
7174
metadata_changes_only=False,
75+
metadata_query=None,
7276
modified_files=modified_files,
7377
)
7478

@@ -87,6 +91,7 @@ def test_get_selected_connectors_by_name_and_support_level_or_languages_leads_to
8791
selected_languages=(connector.language,),
8892
modified=False,
8993
metadata_changes_only=False,
94+
metadata_query=None,
9095
modified_files=modified_files,
9196
)
9297

@@ -103,6 +108,7 @@ def test_get_selected_connectors_with_modified():
103108
selected_languages=(),
104109
modified=True,
105110
metadata_changes_only=False,
111+
metadata_query=None,
106112
modified_files=modified_files,
107113
)
108114

@@ -119,6 +125,7 @@ def test_get_selected_connectors_with_modified_and_language():
119125
selected_languages=(ConnectorLanguage.JAVA,),
120126
modified=True,
121127
metadata_changes_only=False,
128+
metadata_query=None,
122129
modified_files=modified_files,
123130
)
124131

@@ -136,6 +143,7 @@ def test_get_selected_connectors_with_modified_and_support_level():
136143
selected_languages=(),
137144
modified=True,
138145
metadata_changes_only=False,
146+
metadata_query=None,
139147
modified_files=modified_files,
140148
)
141149

@@ -157,6 +165,7 @@ def test_get_selected_connectors_with_modified_and_metadata_only():
157165
selected_languages=(),
158166
modified=True,
159167
metadata_changes_only=True,
168+
metadata_query=None,
160169
modified_files=modified_files,
161170
)
162171

@@ -182,6 +191,7 @@ def test_get_selected_connectors_with_metadata_only():
182191
selected_languages=(),
183192
modified=False,
184193
metadata_changes_only=True,
194+
metadata_query=None,
185195
modified_files=modified_files,
186196
)
187197

@@ -192,6 +202,23 @@ def test_get_selected_connectors_with_metadata_only():
192202
second_modified_connector.code_directory / "setup.py",
193203
}
194204

205+
def test_get_selected_connectors_with_metadata_query():
206+
connector = pick_a_random_connector()
207+
metadata_query = f"data.dockerRepository == '{connector.metadata['dockerRepository']}'"
208+
selected_connectors = connectors.get_selected_connectors_with_modified_files(
209+
selected_names=(),
210+
selected_support_levels=(),
211+
selected_languages=(),
212+
modified=False,
213+
metadata_changes_only=False,
214+
metadata_query=metadata_query,
215+
modified_files=set(),
216+
)
217+
218+
assert len(selected_connectors) == 1
219+
assert isinstance(selected_connectors[0], ConnectorWithModifiedFiles)
220+
assert selected_connectors[0].technical_name == connector.technical_name
221+
assert not selected_connectors[0].modified_files
195222

196223
@pytest.fixture()
197224
def click_context_obj():

0 commit comments

Comments
 (0)