Skip to content

Commit 33a5cf7

Browse files
authored
[Python CDK] Delete SingerSource (#37364)
1 parent dccb6c0 commit 33a5cf7

File tree

7 files changed

+22
-685
lines changed

7 files changed

+22
-685
lines changed

airbyte-cdk/python/README.md

+22-19
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ cd airbyte-integrations/connector-templates/generator
3232
- [Stripe](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-stripe/)
3333
- [Salesforce](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-salesforce/)
3434

35-
**Simple Python connectors using the bare-bones `Source` abstraction**:
35+
**Python connectors using the bare-bones `Source` abstraction**:
3636

3737
- [Google Sheets](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/google_sheets_source.py)
3838

@@ -60,16 +60,15 @@ Airbyte CDK code is within `airbyte_cdk` directory. Here's a high level overview
6060
declarative manifest language to define streams, operations, etc. This makes it easier to build
6161
connectors without writing Python code.
6262
- `sources/file_based` is the CDK for file-based sources. Examples include S3, Azure, GCS, etc.
63-
- `sources/singer` is a singer tap source adapter. Deprecated.
6463

6564
## Contributing
6665

6766
Thank you for being interested in contributing to Airbyte Python CDK! Here are some guidelines to
6867
get you started:
6968

7069
- We adhere to the [code of conduct](/CODE_OF_CONDUCT.md).
71-
- You can contribute by reporting bugs, posting github discussions, opening issues, improving [documentation](/docs/), and
72-
submitting pull requests with bugfixes and new features alike.
70+
- You can contribute by reporting bugs, posting github discussions, opening issues, improving
71+
[documentation](/docs/), and submitting pull requests with bugfixes and new features alike.
7372
- If you're changing the code, please add unit tests for your change.
7473
- When submitting issues or PRs, please add a small reproduction project. Using the changes in your
7574
connector and providing that connector code as an example (or a satellite PR) helps!
@@ -199,21 +198,25 @@ within docker.
199198

200199
Python CDK has a
201200
[GitHub workflow](https://github.com/airbytehq/airbyte/actions/workflows/publish-cdk-command-manually.yml)
202-
that manages the CDK changelog, making a new release for `airbyte_cdk`, publishing it to PyPI, and then making a commit to update (and subsequently auto-release)
201+
that manages the CDK changelog, making a new release for `airbyte_cdk`, publishing it to PyPI, and
202+
then making a commit to update (and subsequently auto-release)
203203
[`source-declarative-m anifest`](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-declarative-manifest)
204204
and Connector Builder (in the platform repository).
205205

206-
> [!Note]: The workflow will handle the `CHANGELOG.md` entry for you. You should
207-
> not add changelog lines in your PRs to the CDK itself.
208-
209-
> [!Warning]: The workflow bumps version on it's own, please don't change the
210-
> CDK version in `pyproject.toml` manually.
211-
212-
1. You only trigger the release workflow once all the PRs that you want to be included are already merged into the `master` branch.
213-
2. The [`Publish CDK Manually`](https://github.com/airbytehq/airbyte/actions/workflows/publish-cdk-command-manually.yml) workflow from master using `release-type=major|manor|patch` and setting the changelog message.
214-
3. When the workflow runs, it will commit a new version directly to master
215-
branch.
216-
4. The workflow will bump the version of `source-declarative-manifest` according to the `release-type` of the CDK, then commit these changes
217-
back to master. The commit to master will kick off a publish of the new version of `source-declarative-manifest`.
218-
5. The workflow will also add a pull request to `airbyte-platform-internal`
219-
repo to bump the dependency in Connector Builder.
206+
> [!Note]: The workflow will handle the `CHANGELOG.md` entry for you. You should not add changelog
207+
> lines in your PRs to the CDK itself.
208+
209+
> [!Warning]: The workflow bumps version on it's own, please don't change the CDK version in
210+
> `pyproject.toml` manually.
211+
212+
1. You only trigger the release workflow once all the PRs that you want to be included are already
213+
merged into the `master` branch.
214+
2. The
215+
[`Publish CDK Manually`](https://github.com/airbytehq/airbyte/actions/workflows/publish-cdk-command-manually.yml)
216+
workflow from master using `release-type=major|manor|patch` and setting the changelog message.
217+
3. When the workflow runs, it will commit a new version directly to master branch.
218+
4. The workflow will bump the version of `source-declarative-manifest` according to the
219+
`release-type` of the CDK, then commit these changes back to master. The commit to master will
220+
kick off a publish of the new version of `source-declarative-manifest`.
221+
5. The workflow will also add a pull request to `airbyte-platform-internal` repo to bump the
222+
dependency in Connector Builder.

airbyte-cdk/python/airbyte_cdk/sources/singer/__init__.py

-8
This file was deleted.

0 commit comments

Comments
 (0)