Skip to content

Commit 3099108

Browse files
author
Marius Posta
committed
connector acceptance tests: fix regression in test_airbyte_trace_message_on_failure
1 parent 59d0cb6 commit 3099108

File tree

3 files changed

+10
-18
lines changed

3 files changed

+10
-18
lines changed

airbyte-integrations/bases/connector-acceptance-test/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 3.9.3
4+
5+
Undo failure trace message test case changes from 3.9.1
6+
37
## 3.9.2
48

59
Relax test_oneof_usage criteria for constant value definitions.

airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py

+5-17
Original file line numberDiff line numberDiff line change
@@ -1158,29 +1158,17 @@ async def test_airbyte_trace_message_on_failure(self, connector_config, inputs:
11581158

11591159
invalid_configured_catalog = ConfiguredAirbyteCatalog(
11601160
streams=[
1161-
# Create ConfiguredAirbyteStream without validation.
1162-
#
1163-
# Care must be taken for the created object to be valid regardless.
1164-
# Connectors using the Bulk CDK will perform schema validation
1165-
# https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/bulk/core/base/src/main/kotlin/io/airbyte/cdk/command/ConfiguredCatalogFactory.kt#L29
1161+
# Create ConfiguredAirbyteStream which is deliberately invalid
1162+
# with regard to the Airbyte Protocol.
1163+
# This should cause the connector to fail.
11661164
ConfiguredAirbyteStream.construct(
11671165
stream=AirbyteStream(
11681166
name="__AIRBYTE__stream_that_does_not_exist",
1169-
namespace="__AIRBYTE__namespace_that_does_not_exist",
11701167
json_schema={"type": "object", "properties": {"f1": {"type": "string"}}},
11711168
supported_sync_modes=[SyncMode.full_refresh],
1172-
source_defined_primary_key=[],
1173-
source_defined_cursor=False,
1174-
default_cursor_field=[],
1175-
is_resumable=False,
11761169
),
1177-
sync_mode=SyncMode.full_refresh,
1178-
destination_sync_mode=DestinationSyncMode.append,
1179-
primary_key=[],
1180-
cursor_field=[],
1181-
minimum_generation_id=1,
1182-
generation_id=1,
1183-
sync_id=1,
1170+
sync_mode="INVALID",
1171+
destination_sync_mode="INVALID",
11841172
)
11851173
]
11861174
)

airbyte-integrations/bases/connector-acceptance-test/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "connector-acceptance-test"
7-
version = "3.9.2"
7+
version = "3.9.3"
88
description = "Contains acceptance tests for connectors."
99
authors = ["Airbyte <[email protected]>"]
1010
license = "MIT"

0 commit comments

Comments
 (0)