Skip to content

Commit 2c827f5

Browse files
authored
refactor(source-s3): Replace AirbyteLogger with logging.Logger (#38252)
1 parent e56e05b commit 2c827f5

File tree

5 files changed

+96
-95
lines changed

5 files changed

+96
-95
lines changed

airbyte-integrations/connectors/source-s3/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ data:
1010
connectorSubtype: file
1111
connectorType: source
1212
definitionId: 69589781-7828-43c5-9f63-8925b1c1ccc2
13-
dockerImageTag: 4.5.14
13+
dockerImageTag: 4.5.15
1414
dockerRepository: airbyte/source-s3
1515
documentationUrl: https://docs.airbyte.com/integrations/sources/s3
1616
githubIssueLabel: source-s3

airbyte-integrations/connectors/source-s3/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
33
build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
6-
version = "4.5.14"
6+
version = "4.5.15"
77
name = "source-s3"
88
description = "Source implementation for S3."
99
authors = [ "Airbyte <[email protected]>",]

airbyte-integrations/connectors/source-s3/source_s3/source_files_abstract/source.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
33
#
44

5+
import logging
56
from abc import ABC, abstractmethod
67
from traceback import format_exc
78
from typing import Any, List, Mapping, Optional, Tuple
89

9-
from airbyte_cdk.logger import AirbyteLogger
1010
from airbyte_cdk.models import ConnectorSpecification, SyncMode
1111
from airbyte_cdk.models.airbyte_protocol import DestinationSyncMode
1212
from airbyte_cdk.sources import AbstractSource
@@ -43,7 +43,7 @@ def documentation_url(self) -> str:
4343
:return: link to docs page for this source e.g. "https://docs.airbyte.com/integrations/sources/s3"
4444
"""
4545

46-
def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) -> Tuple[bool, Optional[Any]]:
46+
def check_connection(self, logger: logging.Logger, config: Mapping[str, Any]) -> Tuple[bool, Optional[Any]]:
4747
"""
4848
This method checks two things:
4949
- That the credentials provided in config are valid for access.

airbyte-integrations/connectors/source-s3/source_s3/utils.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
33
#
44

5+
import logging
56
import multiprocessing as mp
67
import traceback
78
from multiprocessing import Queue
89
from typing import Any, Callable, List, Mapping
910

1011
import dill
11-
from airbyte_cdk.logger import AirbyteLogger
1212

1313

14-
def run_in_external_process(fn: Callable, timeout: int, max_timeout: int, logger: AirbyteLogger, args: List[Any]) -> Mapping[str, Any]:
14+
def run_in_external_process(fn: Callable, timeout: int, max_timeout: int, logger: logging.Logger, args: List[Any]) -> Mapping[str, Any]:
1515
"""
1616
fn passed in must return a tuple of (desired return value, Exception OR None)
1717
This allows propagating any errors from the process up and raising accordingly

0 commit comments

Comments
 (0)