Skip to content

Commit 285661c

Browse files
midavadimlazebnyi
andauthored
🎉 Source Bing Ads - added high test_strictness_level (#22103)
* added high test_strictness_level * updated expected records * added allowedHosts for bing ads --------- Co-authored-by: Serhii Lazebnyi <[email protected]>
1 parent f098287 commit 285661c

File tree

3 files changed

+64
-21
lines changed

3 files changed

+64
-21
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,14 @@
194194
icon: bingads.svg
195195
sourceType: api
196196
releaseStage: generally_available
197+
allowedHosts:
198+
hosts:
199+
- bingads.microsoft.com
200+
- login.microsoftonline.com
201+
- login.live.com
202+
- login.windows-ppe.net
203+
- ads.microsoft.com
204+
- api.ads.microsoft.com
197205
- name: Braintree
198206
sourceDefinitionId: 63cea06f-1c75-458d-88fe-ad48c7cb27fd
199207
dockerRepository: airbyte/source-braintree
Lines changed: 36 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,41 @@
11
connector_image: airbyte/source-bing-ads:dev
2-
tests:
2+
test_strictness_level: high
3+
acceptance_tests:
34
spec:
4-
- spec_path: "source_bing_ads/spec.json"
5-
connection:
6-
- config_path: "secrets/config_old.json"
7-
status: "succeed"
8-
- config_path: "secrets/config.json"
9-
status: "succeed"
10-
- config_path: "integration_tests/invalid_config.json"
11-
status: "failed"
5+
tests:
6+
- spec_path: source_bing_ads/spec.json
127
discovery:
13-
- config_path: "secrets/config.json"
8+
tests:
9+
- config_path: secrets/config.json
10+
connection:
11+
tests:
12+
- config_path: secrets/config_old.json
13+
status: succeed
14+
- config_path: secrets/config.json
15+
status: succeed
16+
- config_path: integration_tests/invalid_config.json
17+
status: failed
1418
basic_read:
15-
- config_path: "secrets/config.json"
16-
timeout_seconds: 600
17-
configured_catalog_path: "integration_tests/configured_catalog.json"
18-
empty_streams: ["account_performance_report_hourly","ad_group_performance_report_hourly","ad_performance_report_hourly","campaign_performance_report_hourly","keyword_performance_report_hourly"]
19-
# incremental test doesn"t work if a single stream has multiple states
20-
#incremental:
21-
# - config_path: "secrets/config.json"
22-
# configured_catalog_path: "integration_tests/configured_catalog.json"
23-
# future_state_path: "integration_tests/abnormal_state.json"
19+
tests:
20+
- config_path: secrets/config.json
21+
expect_records:
22+
path: "integration_tests/expected_records.txt"
23+
extra_records: yes
24+
empty_streams:
25+
- name: account_performance_report_hourly
26+
bypass_reason: "Hourly reports are disabled, because sync is too long"
27+
- name: ad_group_performance_report_hourly
28+
bypass_reason: "Hourly reports are disabled, because sync is too long"
29+
- name: ad_performance_report_hourly
30+
bypass_reason: "Hourly reports are disabled, because sync is too long"
31+
- name: campaign_performance_report_hourly
32+
bypass_reason: "Hourly reports are disabled, because sync is too long"
33+
- name: keyword_performance_report_hourly
34+
bypass_reason: "Hourly reports are disabled, because sync is too long"
2435
full_refresh:
25-
- config_path: "secrets/config.json"
26-
configured_catalog_path: "integration_tests/configured_catalog.json"
36+
tests:
37+
- config_path: secrets/config.json
38+
configured_catalog_path: integration_tests/configured_catalog.json
39+
incremental:
40+
tests:
41+
bypass_reason: "SAT doesn't support complex nested states used in incremental report streams"

0 commit comments

Comments
 (0)