Skip to content

Commit 2855dfc

Browse files
Tim Roestuliren
andauthored
Upgrade plop in connector generators (#10578)
* Upgrade plop * Remove scaffolded code * Build fixes * Remove scaffolded code * Revert "Remove scaffolded code" This reverts commit 3911f52. * Revert "Remove scaffolded code" This reverts commit 549f790. * Remove .gitignore changes * Remove .gitignore changes * Update scaffold generated code * Replace titleCase with capitalCase (#10654) * Add capitalCase helper * Replace titleCase with capitalCase * Update generated scaffold files Co-authored-by: LiRen Tu <[email protected]>
1 parent 9e941f3 commit 2855dfc

File tree

26 files changed

+2765
-1663
lines changed

26 files changed

+2765
-1663
lines changed

airbyte-integrations/connector-templates/destination-java/README.md.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Destination {{titleCase name}}
1+
# Destination {{capitalCase name}}
22

3-
This is the repository for the {{titleCase name}} destination connector in Java.
3+
This is the repository for the {{capitalCase name}} destination connector in Java.
44
For information about how to use this connector within Airbyte, see [the User Documentation](https://docs.airbyte.io/integrations/destinations/{{dashCase name}}).
55

66
## Local development
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
- destinationDefinitionId: {{uuid}}
2-
name: {{titleCase name}}
2+
name: {{capitalCase name}}
33
dockerRepository: airbyte/destination-{{dashCase name}}
44
dockerImageTag: 0.1.0
55
documentationUrl: https://docs.airbyte.io/integrations/destinations/{{dashCase name}}

airbyte-integrations/connector-templates/destination-java/doc.md.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# {{titleCase name}}
1+
# {{capitalCase name}}
22

33
TODO: update this doc
44

airbyte-integrations/connector-templates/destination-python/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# {{titleCase name}} Destination
1+
# {{capitalCase name}} Destination
22

3-
This is the repository for the {{titleCase name}} destination connector, written in Python.
3+
This is the repository for the {{capitalCase name}} destination connector, written in Python.
44
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/destinations/{{dashCase name}}).
55

66
## Local development

airbyte-integrations/connector-templates/destination-python/destination_{{snakeCase name}}/spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"supportsNormalization": false,
99
"connectionSpecification": {
1010
"$schema": "http://json-schema.org/draft-07/schema#",
11-
"title": "Destination {{titleCase name}}",
11+
"title": "Destination {{capitalCase name}}",
1212
"type": "object",
1313
"required": ["TODO -- fix me!"],
1414
"additionalProperties": false,

airbyte-integrations/connector-templates/destination-python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
setup(
1717
name="destination_{{snakeCase name}}",
18-
description="Destination implementation for {{titleCase name}}.",
18+
description="Destination implementation for {{capitalCase name}}.",
1919
author="Airbyte",
2020
author_email="[email protected]",
2121
packages=find_packages(),

airbyte-integrations/connector-templates/generator/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:14-alpine
1+
FROM node:16-alpine
22

33
ARG UID
44
ARG GID

airbyte-integrations/connector-templates/generator/build.gradle

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ plugins {
33
id "com.github.node-gradle.node" version "2.2.4"
44
}
55

6-
def nodeVersion = System.getenv('NODE_VERSION') ?: '14.11.0'
6+
def nodeVersion = System.getenv('NODE_VERSION') ?: '16.13.0'
77

88
node {
99
download = true
@@ -14,9 +14,9 @@ assemble.dependsOn(npmInstall)
1414

1515
task testScaffoldTemplates
1616

17-
def addScaffoldTemplateTask(name, packageName,scaffoldParams=[]) {
17+
def addScaffoldTemplateTask(name, packageName, outputDirName, scaffoldParams=[]) {
1818
def taskName = "testScaffoldTemplate_${name}"
19-
def outputDir = "airbyte-integrations/connectors/source-${packageName}"
19+
def outputDir = "airbyte-integrations/connectors/${outputDirName}"
2020

2121
def task = tasks.create(taskName) {
2222
inputs.files rootProject.fileTree("airbyte-integrations/connector-templates/")
@@ -40,9 +40,9 @@ def addScaffoldTemplateTask(name, packageName,scaffoldParams=[]) {
4040
testScaffoldTemplates.dependsOn task
4141
}
4242

43-
addScaffoldTemplateTask('Python Source', 'scaffold-source-python')
44-
addScaffoldTemplateTask('Python HTTP API Source', 'scaffold-source-http')
45-
addScaffoldTemplateTask('Java JDBC Source', 'scaffold-java-jdbc')
46-
addScaffoldTemplateTask('Python Destination', 'scaffold-destination-python')
43+
addScaffoldTemplateTask('Python Source', 'scaffold-source-python', 'source-scaffold-source-python')
44+
addScaffoldTemplateTask('Python HTTP API Source', 'scaffold-source-http', 'source-scaffold-source-http')
45+
addScaffoldTemplateTask('Java JDBC Source', 'scaffold-java-jdbc', 'source-scaffold-java-jdbc')
46+
addScaffoldTemplateTask('Python Destination', 'scaffold-destination-python', 'destination-scaffold-destination-python')
4747
// TODO: enable Singer template testing
4848
//addScaffoldTask('source-python-singer', ['tap-exchangeratesapi'])

0 commit comments

Comments
 (0)