Skip to content

Commit 258a905

Browse files
authored
🎉 Destination Snowflake: tag snowflake traffic with airbyte ID to enable optimizations from Snowflake (#4713)
1 parent 3add914 commit 258a905

File tree

7 files changed

+25
-10
lines changed

7 files changed

+25
-10
lines changed

‎airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
"destinationDefinitionId": "424892c4-daac-4491-b35d-c6688ba547ba",
33
"name": "Snowflake",
44
"dockerRepository": "airbyte/destination-snowflake",
5-
"dockerImageTag": "0.3.9",
5+
"dockerImageTag": "0.3.10",
66
"documentationUrl": "https://docs.airbyte.io/integrations/destinations/snowflake"
77
}

‎airbyte-config/init/src/main/resources/seed/destination_definitions.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
- destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba
3333
name: Snowflake
3434
dockerRepository: airbyte/destination-snowflake
35-
dockerImageTag: 0.3.9
35+
dockerImageTag: 0.3.10
3636
documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake
3737
- destinationDefinitionId: 4816b78f-1489-44c1-9060-4b19d5fa9362
3838
name: S3

‎airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java

+12-6
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,10 @@ public void testSecondSync() throws Exception {
372372
.put("id", 1)
373373
.put("currency", "USD")
374374
.put("date", "2020-03-31T00:00:00Z")
375-
.put("HKD", 10.0)
376-
.put("NZD", 700.0)
375+
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
376+
// fails destination tests
377+
.put("HKD", 10.1)
378+
.put("NZD", 700.1)
377379
.build()))),
378380
new AirbyteMessage()
379381
.withType(Type.STATE)
@@ -405,8 +407,10 @@ public void testLineBreakCharacters() throws Exception {
405407
.put("id", 1)
406408
.put("currency", "USD\u2028")
407409
.put("date", "2020-03-\n31T00:00:00Z\r")
408-
.put("HKD", 10.0)
409-
.put("NZD", 700.0)
410+
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
411+
// fails destination tests
412+
.put("HKD", 10.1)
413+
.put("NZD", 700.1)
410414
.build()))),
411415
new AirbyteMessage()
412416
.withType(Type.STATE)
@@ -470,8 +474,10 @@ public void testIncrementalSync() throws Exception {
470474
.put("id", 1)
471475
.put("currency", "USD")
472476
.put("date", "2020-03-31T00:00:00Z")
473-
.put("HKD", 10.0)
474-
.put("NZD", 700.0)
477+
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
478+
// fails destination tests
479+
.put("HKD", 10.1)
480+
.put("NZD", 700.1)
475481
.build()))),
476482
new AirbyteMessage()
477483
.withType(Type.STATE)

‎airbyte-integrations/connectors/destination-snowflake/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar
88

99
RUN tar xf ${APPLICATION}.tar --strip-components=1
1010

11-
LABEL io.airbyte.version=0.3.9
11+
LABEL io.airbyte.version=0.3.10
1212
LABEL io.airbyte.name=airbyte/destination-snowflake

‎airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java

+4
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ public static Connection getConnection(JsonNode config) throws SQLException {
5959
// allows queries to contain any number of statements.
6060
properties.put("MULTI_STATEMENT_COUNT", 0);
6161

62+
// https://docs.snowflake.com/en/user-guide/jdbc-parameters.html#application
63+
// identify airbyte traffic to snowflake to enable partnership & optimization opportunities
64+
properties.put("application", "airbyte");
65+
6266
return DriverManager.getConnection(connectUrl, properties);
6367
}
6468

‎docs/integrations/destinations/snowflake.md

+5
Original file line numberDiff line numberDiff line change
@@ -186,3 +186,8 @@ The final query should show a `STORAGE_GCP_SERVICE_ACCOUNT` property with an ema
186186

187187
Finally, you need to add read/write permissions to your bucket with that email.
188188

189+
190+
| Version | Date | Pull Request | Subject |
191+
| :------ | :-------- | :----- | :------ |
192+
| 0.3.10 | July 12, 2021| [4713](https://github.com/airbytehq/airbyte/pull/4713)| Tag traffic with `airbyte` label to enable optimization opportunities from Snowflake |
193+

‎docs/integrations/sources/stripe.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,4 @@ If you would like to test Airbyte using test data on Stripe, `sk_test_` and `rk_
6969
| 0.1.11 | 2021-05-30 | [3744](https://github.com/airbytehq/airbyte/pull/3744) | Fix types in schema |
7070
| 0.1.10 | 2021-05-28 | [3728](https://github.com/airbytehq/airbyte/pull/3728) | Update data types to be number instead of int |
7171
| 0.1.9 | 2021-05-13 | [3367](https://github.com/airbytehq/airbyte/pull/3367) | Add acceptance tests for connected accounts |
72-
| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors |
72+
| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors |

0 commit comments

Comments
 (0)