Skip to content

Commit 22d226a

Browse files
authored
CDK: Avoid duplicate HTTP query in simple_retriever (#19485)
Signed-off-by: Sergey Chvalyuk <[email protected]>
1 parent 64cfb38 commit 22d226a

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

airbyte-cdk/python/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## 0.9.3
4+
Low-code: Avoid duplicate HTTP query in `simple_retriever`
5+
36
## 0.9.2
47
Low-code: Make `default_paginator.page_token_option` optional
58

airbyte-cdk/python/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,7 @@ def read_records(
363363
# Warning: use self.state instead of the stream_state passed as argument!
364364
stream_slice = stream_slice or {} # None-check
365365
self.paginator.reset()
366-
records_generator = self._read_pages(
367-
lambda req, res, state, _slice: self.parse_records_and_emit_request_and_responses(
368-
req, res, stream_slice=_slice, stream_state=state
369-
),
366+
records_generator = self._read_pages(self.parse_records_and_emit_request_and_responses,
370367
stream_slice,
371368
stream_state,
372369
)
@@ -411,9 +408,7 @@ def parse_records_and_emit_request_and_responses(self, request, response, stream
411408
yield self._create_trace_message_from_response(response)
412409
# Not great to need to call _read_pages which is a private method
413410
# A better approach would be to extract the HTTP client from the HttpStream and call it directly from the HttpRequester
414-
yield from self._read_pages(
415-
lambda req, res, state, _slice: self.parse_response(res, stream_slice=_slice, stream_state=state), stream_slice, stream_state
416-
)
411+
yield from self.parse_response(response, stream_slice=stream_slice, stream_state=stream_state)
417412

418413
def _create_trace_message_from_request(self, request: requests.PreparedRequest):
419414
# FIXME: this should return some sort of trace message

airbyte-cdk/python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
setup(
1717
name="airbyte-cdk",
18-
version="0.9.2",
18+
version="0.9.3",
1919
description="A framework for writing Airbyte Connectors.",
2020
long_description=README,
2121
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)