Skip to content

Commit 1f2fd6e

Browse files
authored
šŸ› Source Shopify: Have message and description be nullable for custom_collections deletā€¦ (#45116)
1 parent af58faa commit 1f2fd6e

File tree

4 files changed

+79
-78
lines changed

4 files changed

+79
-78
lines changed

ā€Žairbyte-integrations/connectors/source-shopify/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ data:
1111
connectorSubtype: api
1212
connectorType: source
1313
definitionId: 9da77001-af33-4bcd-be46-6252bf9342b9
14-
dockerImageTag: 2.4.23
14+
dockerImageTag: 2.4.24
1515
dockerRepository: airbyte/source-shopify
1616
documentationUrl: https://docs.airbyte.com/integrations/sources/shopify
1717
erdUrl: https://dbdocs.io/airbyteio/source-shopify?view=relationships

ā€Žairbyte-integrations/connectors/source-shopify/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
33
build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
6-
version = "2.4.23"
6+
version = "2.4.24"
77
name = "source-shopify"
88
description = "Source CDK implementation for Shopify."
99
authors = [ "Airbyte <[email protected]>",]

ā€Žairbyte-integrations/connectors/source-shopify/source_shopify/streams/base_streams.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ def produce_deleted_records_from_events(self, delete_events: Iterable[Mapping[st
143143
yield {
144144
"id": event["subject_id"],
145145
self.cursor_field: event["created_at"],
146-
"deleted_message": event["message"],
147-
"deleted_description": event["description"],
146+
"deleted_message": event.get("message", None),
147+
"deleted_description": event.get("description", None),
148148
"shop_url": event["shop_url"],
149149
}
150150

0 commit comments

Comments
Ā (0)