Skip to content

Commit 1c3a6e2

Browse files
author
Marius Posta
authored
source-elasticsearch: adopt CDK 0.20.4 (#35230)
1 parent fd0b77e commit 1c3a6e2

File tree

5 files changed

+9
-16
lines changed

5 files changed

+9
-16
lines changed
Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,13 @@
11
plugins {
2-
id 'application'
32
id 'airbyte-java-connector'
43
}
54

65
airbyteJavaConnector {
7-
cdkVersionRequired = '0.2.0'
6+
cdkVersionRequired = '0.20.4'
87
features = ['db-sources']
98
useLocalCdk = false
109
}
1110

12-
//remove once upgrading the CDK version to 0.4.x or later
13-
java {
14-
compileJava {
15-
options.compilerArgs.remove("-Werror")
16-
}
17-
}
18-
19-
airbyteJavaConnector.addCdkDependencies()
20-
2111
application {
2212
mainClass = 'io.airbyte.integrations.source.elasticsearch.ElasticsearchSource'
2313
applicationDefaultJvmArgs = ['-XX:+ExitOnOutOfMemoryError', '-XX:MaxRAMPercentage=75.0']
@@ -26,6 +16,7 @@ application {
2616
dependencies {
2717

2818
implementation 'co.elastic.clients:elasticsearch-java:7.15.0'
19+
implementation 'org.elasticsearch.client:elasticsearch-rest-high-level-client:7.15.2'
2920
implementation 'com.fasterxml.jackson.core:jackson-databind:2.12.3'
3021

3122
// EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
@@ -39,6 +30,5 @@ dependencies {
3930

4031
// MIT
4132
// https://www.testcontainers.org/
42-
testImplementation libs.testcontainers.elasticsearch
43-
integrationTestJavaImplementation libs.testcontainers.elasticsearch
33+
testImplementation 'org.testcontainers:elasticsearch:1.19.4'
4434
}

airbyte-integrations/connectors/source-elasticsearch/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ data:
22
connectorSubtype: api
33
connectorType: source
44
definitionId: 7cf88806-25f5-4e1a-b422-b2fa9e1b0090
5-
dockerImageTag: 0.1.1
5+
dockerImageTag: 0.1.2
66
dockerRepository: airbyte/source-elasticsearch
77
githubIssueLabel: source-elasticsearch
88
icon: elasticsearch.svg

airbyte-integrations/connectors/source-elasticsearch/src/main/java/io/airbyte/integrations/source/elasticsearch/ElasticsearchConnection.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.elasticsearch.client.indices.GetMappingsRequest;
2222
import org.elasticsearch.client.indices.GetMappingsResponse;
2323
import org.elasticsearch.cluster.metadata.MappingMetadata;
24-
import org.elasticsearch.common.unit.TimeValue;
24+
import org.elasticsearch.core.TimeValue;
2525
import org.elasticsearch.index.query.QueryBuilders;
2626
import org.elasticsearch.search.Scroll;
2727
import org.elasticsearch.search.SearchHit;
@@ -44,6 +44,7 @@ public class ElasticsearchConnection {
4444
*
4545
* @param config Configuration parameters for connecting to the Elasticsearch host
4646
*/
47+
@SuppressWarnings("this-escape")
4748
public ElasticsearchConnection(ConnectorConfiguration config) {
4849
log.info(String.format(
4950
"creating ElasticsearchConnection: %s", config.getEndpoint()));

airbyte-integrations/connectors/source-elasticsearch/src/test-integration/java/io/airbyte/integrations/source/elasticsearch/ElasticsearchSourceAcceptanceTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.fasterxml.jackson.databind.ObjectMapper;
99
import io.airbyte.cdk.integrations.standardtest.source.SourceAcceptanceTest;
1010
import io.airbyte.cdk.integrations.standardtest.source.TestDestinationEnv;
11+
import io.airbyte.cdk.integrations.util.HostPortResolver;
1112
import io.airbyte.commons.jackson.MoreMappers;
1213
import io.airbyte.commons.json.Jsons;
1314
import io.airbyte.commons.resources.MoreResources;
@@ -47,7 +48,7 @@ protected String getImageName() {
4748
@Override
4849
protected JsonNode getConfig() {
4950
var configJson = mapper.createObjectNode();
50-
configJson.put("endpoint", String.format("http://%s:%s", container.getHost(), container.getMappedPort(9200)));
51+
configJson.put("endpoint", String.format("http://%s:%s", HostPortResolver.resolveHost(container), HostPortResolver.resolvePort(container)));
5152
return configJson;
5253
}
5354

docs/integrations/sources/elasticsearch.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ all values in the array must be of the same data type. Hence, every field can be
8484

8585
| Version | Date | Pull Request | Subject |
8686
|:--------| :--------- | :------------------------------------------------------- | :-------------- |
87+
| 0.1.2 | 2024-02-13 | [35230](https://github.com/airbytehq/airbyte/pull/35230) | Adopt CDK 0.20.4 |
8788
| `0.1.2` | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
8889
| `0.1.1` | 2022-12-02 | [18118](https://github.com/airbytehq/airbyte/pull/18118) | Avoid too_long_frame_exception |
8990
| `0.1.0` | 2022-07-12 | [14118](https://github.com/airbytehq/airbyte/pull/14118) | Initial Release |

0 commit comments

Comments
 (0)