Skip to content

Commit 1519df3

Browse files
fix: formatting issue (#10525)
1 parent d0a5547 commit 1519df3

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

airbyte-server/src/main/java/io/airbyte/server/handlers/DestinationHandler.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import io.airbyte.commons.json.Jsons;
2020
import io.airbyte.config.DestinationConnection;
2121
import io.airbyte.config.StandardDestinationDefinition;
22-
import io.airbyte.config.StandardSourceDefinition;
2322
import io.airbyte.config.persistence.ConfigNotFoundException;
2423
import io.airbyte.config.persistence.ConfigRepository;
2524
import io.airbyte.config.persistence.split_secrets.JsonSecretsProcessor;
@@ -155,7 +154,7 @@ public DestinationRead getDestination(final DestinationIdRequestBody destination
155154
}
156155

157156
public DestinationRead cloneDestination(final DestinationIdRequestBody destinationIdRequestBody)
158-
throws JsonValidationException, IOException, ConfigNotFoundException {
157+
throws JsonValidationException, IOException, ConfigNotFoundException {
159158
// read destination configuration from db
160159
final DestinationRead destinationToClone = buildDestinationReadWithSecrets(destinationIdRequestBody.getDestinationId());
161160
final ConnectorSpecification spec = getSpec(destinationToClone.getDestinationDefinitionId());
@@ -165,12 +164,12 @@ public DestinationRead cloneDestination(final DestinationIdRequestBody destinati
165164
final String copyText = " (Copy)";
166165
final String destinationName = destinationToClone.getName() + copyText;
167166
persistDestinationConnection(
168-
destinationName,
169-
destinationToClone.getDestinationDefinitionId(),
170-
destinationToClone.getWorkspaceId(),
171-
destinationId,
172-
destinationToClone.getConnectionConfiguration(),
173-
false);
167+
destinationName,
168+
destinationToClone.getDestinationDefinitionId(),
169+
destinationToClone.getWorkspaceId(),
170+
destinationId,
171+
destinationToClone.getConnectionConfiguration(),
172+
false);
174173

175174
// read configuration from db
176175
return buildDestinationRead(destinationId, spec);
@@ -273,12 +272,12 @@ private DestinationRead buildDestinationRead(final UUID destinationId, final Con
273272
}
274273

275274
private DestinationRead buildDestinationReadWithSecrets(final UUID destinationId)
276-
throws ConfigNotFoundException, IOException, JsonValidationException {
275+
throws ConfigNotFoundException, IOException, JsonValidationException {
277276

278277
// remove secrets from config before returning the read
279278
final DestinationConnection dci = Jsons.clone(configRepository.getDestinationConnectionWithSecrets(destinationId));
280279
final StandardDestinationDefinition standardDestinationDefinition =
281-
configRepository.getStandardDestinationDefinition(dci.getDestinationDefinitionId());
280+
configRepository.getStandardDestinationDefinition(dci.getDestinationDefinitionId());
282281
return toDestinationRead(dci, standardDestinationDefinition);
283282
}
284283

airbyte-server/src/test/java/io/airbyte/server/handlers/DestinationHandlerTest.java

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -255,19 +255,19 @@ void testSearchDestinations() throws JsonValidationException, ConfigNotFoundExce
255255
void testCloneDestination() throws JsonValidationException, ConfigNotFoundException, IOException {
256256
final DestinationConnection clonedConnection = DestinationHelpers.generateDestination(standardDestinationDefinition.getDestinationDefinitionId());
257257
final DestinationRead expectedDestinationRead = new DestinationRead()
258-
.name(clonedConnection.getName())
259-
.destinationDefinitionId(standardDestinationDefinition.getDestinationDefinitionId())
260-
.workspaceId(clonedConnection.getWorkspaceId())
261-
.destinationId(clonedConnection.getDestinationId())
262-
.connectionConfiguration(clonedConnection.getConfiguration())
263-
.destinationName(standardDestinationDefinition.getName());
258+
.name(clonedConnection.getName())
259+
.destinationDefinitionId(standardDestinationDefinition.getDestinationDefinitionId())
260+
.workspaceId(clonedConnection.getWorkspaceId())
261+
.destinationId(clonedConnection.getDestinationId())
262+
.connectionConfiguration(clonedConnection.getConfiguration())
263+
.destinationName(standardDestinationDefinition.getName());
264264
final DestinationRead destinationRead = new DestinationRead()
265-
.name(destinationConnection.getName())
266-
.destinationDefinitionId(standardDestinationDefinition.getDestinationDefinitionId())
267-
.workspaceId(destinationConnection.getWorkspaceId())
268-
.destinationId(destinationConnection.getDestinationId())
269-
.connectionConfiguration(destinationConnection.getConfiguration())
270-
.destinationName(standardDestinationDefinition.getName());
265+
.name(destinationConnection.getName())
266+
.destinationDefinitionId(standardDestinationDefinition.getDestinationDefinitionId())
267+
.workspaceId(destinationConnection.getWorkspaceId())
268+
.destinationId(destinationConnection.getDestinationId())
269+
.connectionConfiguration(destinationConnection.getConfiguration())
270+
.destinationName(standardDestinationDefinition.getName());
271271

272272
final DestinationIdRequestBody destinationIdRequestBody = new DestinationIdRequestBody().destinationId(destinationRead.getDestinationId());
273273

@@ -276,10 +276,11 @@ void testCloneDestination() throws JsonValidationException, ConfigNotFoundExcept
276276
when(configRepository.getDestinationConnection(clonedConnection.getDestinationId())).thenReturn(clonedConnection);
277277

278278
when(configRepository.getStandardDestinationDefinition(destinationDefinitionSpecificationRead.getDestinationDefinitionId()))
279-
.thenReturn(standardDestinationDefinition);
280-
when(configRepository.getDestinationDefinitionFromDestination(destinationConnection.getDestinationId())).thenReturn(standardDestinationDefinition);
279+
.thenReturn(standardDestinationDefinition);
280+
when(configRepository.getDestinationDefinitionFromDestination(destinationConnection.getDestinationId()))
281+
.thenReturn(standardDestinationDefinition);
281282
when(secretsProcessor.maskSecrets(destinationConnection.getConfiguration(), destinationDefinitionSpecificationRead.getConnectionSpecification()))
282-
.thenReturn(destinationConnection.getConfiguration());
283+
.thenReturn(destinationConnection.getConfiguration());
283284

284285
final DestinationRead actualDestinationRead = destinationHandler.cloneDestination(destinationIdRequestBody);
285286

0 commit comments

Comments
 (0)