🐛 [source-facebook-marketing] Should not run migration if the legacy field account_id is not present (#37367)

Author: brianjlai

airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml

@@ -10,7 +10,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
-  dockerImageTag: 2.1.3
+  dockerImageTag: 2.1.4
   dockerRepository: airbyte/source-facebook-marketing
   documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
   githubIssueLabel: source-facebook-marketing

airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml

@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "2.1.3"
+version = "2.1.4"
 name = "source-facebook-marketing"
 description = "Source implementation for Facebook Marketing."
 authors = [ "Airbyte <[email protected]>",]

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/config_migrations.py

@@ -38,7 +38,7 @@ def should_migrate(cls, config: Mapping[str, Any]) -> bool:
             > False, otherwise.
             > Raises the Exception if the structure could not be migrated.
         """
-        return False if config.get(cls.migrate_to_key) else True
+        return cls.migrate_from_key in config and cls.migrate_to_key not in config
 
     @classmethod
     def transform(cls, config: Mapping[str, Any]) -> Mapping[str, Any]:

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_config_migrations.py

@@ -27,6 +27,7 @@ class TestMigrateAccountIdToArray:
     TEST_CONFIG_PATH = "unit_tests/test_migrations/account_id_to_array/test_old_config.json"
     NEW_TEST_CONFIG_PATH = "unit_tests/test_migrations/account_id_to_array/test_new_config.json"
     UPGRADED_TEST_CONFIG_PATH = "unit_tests/test_migrations/account_id_to_array/test_upgraded_config.json"
+    NEW_CONFIG_WITHOUT_ACCOUNT_ID = "unit_tests/test_migrations/account_id_to_array/test_new_config_without_account_id.json"
 
     @staticmethod
     def revert_migration(config_path: str = TEST_CONFIG_PATH) -> None:
@@ -86,6 +87,14 @@ def test_should_not_migrate_upgraded_config(self):
         migration_instance = MigrateAccountIdToArray()
         assert not migration_instance.should_migrate(new_config)
 
+    def test_should_not_migrate_config_without_account_id(self):
+        # OC Issue: https://github.com/airbytehq/oncall/issues/4131
+        # Newly created sources will not have the deprecated `account_id` field, and we should not attempt to migrate
+        # because it is already in the new `account_ids` format
+        new_config = load_config(self.NEW_CONFIG_WITHOUT_ACCOUNT_ID)
+        migration_instance = MigrateAccountIdToArray()
+        assert not migration_instance.should_migrate(new_config)
+
 
 class TestMigrateIncludeDeletedToStatusFilters:
     OLD_TEST1_CONFIG_PATH = "unit_tests/test_migrations/include_deleted_to_status_filters/include_deleted_false/test_old_config.json"

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_migrations/account_id_to_array/test_new_config_without_account_id.json

@@ -0,0 +1,13 @@
+{
+  "start_date": "2021-02-08T00:00:00Z",
+  "end_date": "2021-02-15T00:00:00Z",
+  "custom_insights": [
+    {
+      "name": "custom_insight_stream",
+      "fields": ["account_name", "clicks", "cpc", "account_id", "ad_id"],
+      "breakdowns": ["gender"],
+      "action_breakdowns": []
+    }
+  ],
+  "access_token": "access_token"
+}

docs/integrations/sources/facebook-marketing.md

@@ -200,6 +200,7 @@ The Facebook Marketing connector uses the `lookback_window` parameter to repeate
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                                                                                           |
 |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 2.1.4   | 2024-04-16 | [37367](https://github.com/airbytehq/airbyte/pull/37367)     | Skip config migration when the legacy account_id field does not exist                                                                                                                                                                                                                             |
 | 2.1.3   | 2024-04-16 | [37320](https://github.com/airbytehq/airbyte/pull/37320) | Add retry for transient error                                                                                                                                                                                                                                                                     |
 | 2.1.2   | 2024-03-29 | [36689](https://github.com/airbytehq/airbyte/pull/36689) | Fix key error `account_id` for custom reports.                                                                                                                                                                                                                                                    |
 | 2.1.1   | 2024-03-18 | [36025](https://github.com/airbytehq/airbyte/pull/36025) | Fix start_date selection behaviour                                                                                                                                                                                                                                                                |