Skip to content

Commit 0b17e6b

Browse files
subodh1810gl-pix
authored andcommitted
fix broken assertions for automatic migration tests (#4732)
1 parent df01bb1 commit 0b17e6b

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

airbyte-server/src/test/java/io/airbyte/server/migration/RunMigrationTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,11 @@ private void assertSourceDefinitions(ConfigRepository configRepository) throws J
159159
assertEquals("MySQL", mysqlDefinition.getName());
160160

161161
final StandardSourceDefinition postgresDefinition = sourceDefinitions.get("decd338e-5647-4c0b-adf4-da0e75f5a750");
162-
assertTrue(postgresDefinition.getDockerImageTag().compareTo("0.3.4") >= 0);
162+
String[] tagBrokenAsArray = postgresDefinition.getDockerImageTag().replace(".", ",").split(",");
163+
assertEquals(3, tagBrokenAsArray.length);
164+
assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
165+
assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
166+
assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 4);
163167
assertTrue(postgresDefinition.getName().contains("Postgres"));
164168
}
165169

@@ -178,7 +182,11 @@ private void assertDestinationDefinitions(ConfigRepository configRepository) thr
178182
assertEquals("0.2.0", localCsvDefinition.getDockerImageTag());
179183

180184
final StandardDestinationDefinition snowflakeDefinition = sourceDefinitions.get("424892c4-daac-4491-b35d-c6688ba547ba");
181-
assertTrue(snowflakeDefinition.getDockerImageTag().compareTo("0.3.9") >= 0);
185+
String[] tagBrokenAsArray = snowflakeDefinition.getDockerImageTag().replace(".", ",").split(",");
186+
assertEquals(3, tagBrokenAsArray.length);
187+
assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
188+
assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
189+
assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 9);
182190
assertTrue(snowflakeDefinition.getName().contains("Snowflake"));
183191
}
184192

airbyte-tests/src/automaticMigrationAcceptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,11 @@ private void assertSourceDefinitionInformation(ApiClient apiClient) throws ApiEx
204204
foundMysqlSourceDefinition = true;
205205
} else if (sourceDefinitionRead.getSourceDefinitionId().toString()
206206
.equals("decd338e-5647-4c0b-adf4-da0e75f5a750")) {
207-
assertTrue(sourceDefinitionRead.getDockerImageTag().compareTo("0.3.4") >= 0);
207+
String[] tagBrokenAsArray = sourceDefinitionRead.getDockerImageTag().replace(".", ",").split(",");
208+
assertEquals(3, tagBrokenAsArray.length);
209+
assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
210+
assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
211+
assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 4);
208212
assertTrue(sourceDefinitionRead.getName().contains("Postgres"));
209213
foundPostgresSourceDefinition = true;
210214
}
@@ -235,7 +239,11 @@ private void assertDestinationDefinitionInformation(ApiClient apiClient) throws
235239
foundLocalCSVDestinationDefinition = true;
236240
}
237241
case "424892c4-daac-4491-b35d-c6688ba547ba" -> {
238-
assertTrue(destinationDefinitionRead.getDockerImageTag().compareTo("0.3.9") >= 0);
242+
String[] tagBrokenAsArray = destinationDefinitionRead.getDockerImageTag().replace(".", ",").split(",");
243+
assertEquals(3, tagBrokenAsArray.length);
244+
assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
245+
assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
246+
assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 9);
239247
assertTrue(destinationDefinitionRead.getName().contains("Snowflake"));
240248
foundSnowflakeDestinationDefintion = true;
241249
}

0 commit comments

Comments
 (0)