[Source-mysql/mssql] : Remove legacy bad values handling code (#37476)

akashkulk · web-flow · commit 097709a18716 · 2024-04-22T20:10:54.000-04:00
diff --git a/airbyte-integrations/connectors/source-mssql/build.gradle b/airbyte-integrations/connectors/source-mssql/build.gradle
@@ -3,7 +3,7 @@ plugins {
 }
 
 airbyteJavaConnector {
-    cdkVersionRequired = '0.30.5'
+    cdkVersionRequired = '0.30.7'
     features = ['db-sources']
     useLocalCdk = false
 }
diff --git a/airbyte-integrations/connectors/source-mssql/metadata.yaml b/airbyte-integrations/connectors/source-mssql/metadata.yaml
@@ -9,7 +9,7 @@ data:
   connectorSubtype: database
   connectorType: source
   definitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1
-  dockerImageTag: 4.0.13
+  dockerImageTag: 4.0.14
   dockerRepository: airbyte/source-mssql
   documentationUrl: https://docs.airbyte.com/integrations/sources/mssql
   githubIssueLabel: source-mssql
diff --git a/airbyte-integrations/connectors/source-mysql/build.gradle b/airbyte-integrations/connectors/source-mysql/build.gradle
@@ -6,7 +6,7 @@ plugins {
 }
 
 airbyteJavaConnector {
-    cdkVersionRequired = '0.30.5'
+    cdkVersionRequired = '0.30.7'
     features = ['db-sources']
     useLocalCdk = false
 }
diff --git a/airbyte-integrations/connectors/source-mysql/metadata.yaml b/airbyte-integrations/connectors/source-mysql/metadata.yaml
@@ -9,7 +9,7 @@ data:
   connectorSubtype: database
   connectorType: source
   definitionId: 435bb9a5-7887-4809-aa58-28c27df0d7ad
-  dockerImageTag: 3.3.20
+  dockerImageTag: 3.3.21
   dockerRepository: airbyte/source-mysql
   documentationUrl: https://docs.airbyte.com/integrations/sources/mysql
   githubIssueLabel: source-mysql
diff --git a/airbyte-integrations/connectors/source-mysql/src/test/java/io/airbyte/integrations/source/mysql/CdcMysqlSourceTest.java b/airbyte-integrations/connectors/source-mysql/src/test/java/io/airbyte/integrations/source/mysql/CdcMysqlSourceTest.java
@@ -804,7 +804,7 @@ public void testInvalidDatetime_metaChangesPopulated() throws Exception {
     assertEquals(expectedMessageMeta, invalidDateRecord.getMeta());
 
     ObjectMapper mapper = new ObjectMapper();
-    final JsonNode expectedDataWithoutCdcFields = mapper.readTree("{\"id\":120}");
+    final JsonNode expectedDataWithoutCdcFields = mapper.readTree("{\"id\":120, \"CAR_DATE\":null}");
     removeCDCColumns((ObjectNode) invalidDateRecord.getData());
     assertEquals(expectedDataWithoutCdcFields, invalidDateRecord.getData());
   }
diff --git a/docs/integrations/sources/mssql.md b/docs/integrations/sources/mssql.md
@@ -417,6 +417,7 @@ WHERE actor_definition_id ='b5ea17b1-f170-46dc-bc31-cc744ca984c1' AND (configura
 
 | Version | Date       | Pull Request                                                                                                      | Subject                                                                                                                                         |
 |:--------|:-----------| :---------------------------------------------------------------------------------------------------------------- |:------------------------------------------------------------------------------------------------------------------------------------------------|
+| 4.0.14  | 2024-04-22 | [37476](https://github.com/airbytehq/airbyte/pull/37476)                                                          | Adopt latest CDK.                                                                                                                               |
 | 4.0.13  | 2024-04-16 | [37111](https://github.com/airbytehq/airbyte/pull/37111)                                                          | Populate null values in record message.                                                                                                         |
 | 4.0.12  | 2024-04-15 | [37326](https://github.com/airbytehq/airbyte/pull/37326)                                                          | Allow up to 60 minutes of wait for the an initial CDC record.                                                                                   |
 | 4.0.11  | 2024-04-15 | [37325](https://github.com/airbytehq/airbyte/pull/37325)                                                          | Populate airbyte_meta.changes + error handling.                                                                                                 |
diff --git a/docs/integrations/sources/mysql.md b/docs/integrations/sources/mysql.md
@@ -223,6 +223,7 @@ Any database or table encoding combination of charset and collation is supported
 
 | Version | Date       | Pull Request                                               | Subject                                                                                                                                         |
 |:--------|:-----------|:-----------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
+| 3.3.21  | 2024-04-22 | [37476](https://github.com/airbytehq/airbyte/pull/37476)                                                          | Adopt latest CDK.                                                                                                                               |
 | 3.3.20  | 2024-04-16 | [37111](https://github.com/airbytehq/airbyte/pull/37111)                                                          | Populate null values in record message.                                                                                                         |
 | 3.3.19  | 2024-04-15 | [37328](https://github.com/airbytehq/airbyte/pull/37328)   | Populate airbyte_meta.changes                                                                                                                   |
 | 3.3.18  | 2024-04-15 | [37324](https://github.com/airbytehq/airbyte/pull/37324)   | Refactor source operations.                                                                                                                     |

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ plugins {`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`airbyteJavaConnector {`
`6`		`- cdkVersionRequired = '0.30.5'`
	`6`	`+ cdkVersionRequired = '0.30.7'`
`7`	`7`	`features = ['db-sources']`
`8`	`8`	`useLocalCdk = false`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ plugins {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`airbyteJavaConnector {`
`9`		`- cdkVersionRequired = '0.30.5'`
	`9`	`+ cdkVersionRequired = '0.30.7'`
`10`	`10`	`features = ['db-sources']`
`11`	`11`	`useLocalCdk = false`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -804,7 +804,7 @@ public void testInvalidDatetime_metaChangesPopulated() throws Exception {`
`804`	`804`	`assertEquals(expectedMessageMeta, invalidDateRecord.getMeta());`
`805`	`805`
`806`	`806`	`ObjectMapper mapper = new ObjectMapper();`
`807`		`- final JsonNode expectedDataWithoutCdcFields = mapper.readTree("{\"id\":120}");`
	`807`	`+ final JsonNode expectedDataWithoutCdcFields = mapper.readTree("{\"id\":120, \"CAR_DATE\":null}");`
`808`	`808`	`removeCDCColumns((ObjectNode) invalidDateRecord.getData());`
`809`	`809`	`assertEquals(expectedDataWithoutCdcFields, invalidDateRecord.getData());`
`810`	`810`	`}`