change link file name

Author: stephane-airbyte

airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/templates/test_report.html.j2

@@ -171,7 +171,7 @@ function copyToClipBoard(htmlElement) {
       <h3>Artifacts</h3>
       <ul>
       {% for artifact in step_result_to_artifact_links[step_result.step.title] %}
-        <li><a href="{{ artifact.url }}">{{ artifact.name }}</a></li>
+        <li><a href="{{ artifact.url }}" download="{{ artifact.name }}">{{ artifact.name }}</a></li>
       {% endfor %}
       </ul>
       {% endif %}

airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/steps/gradle.py

@@ -2,7 +2,8 @@
 # Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 from abc import ABC
-from typing import Any, ClassVar, List, Optional, Tuple
+from datetime import datetime
+from typing import Any, ClassVar, List, Optional, Tuple, cast
 
 import pipelines.dagger.actions.system.docker
 from dagger import CacheSharingMode, CacheVolume, Container, ExecError
@@ -220,20 +221,26 @@ async def _collect_test_logs(self, gradle_container: Container) -> Optional[Arti
         The docs in the container are expected to be in build/test-logs, and will end up test-artifact directory by default
         One can change the destination directory by setting the outputs
         """
-        test_logs_dir_name = "test-logs"
-        if test_logs_dir_name not in await gradle_container.directory(f"{self.context.connector.code_directory}/build").entries():
-            self.context.logger.warn(f"No {test_logs_dir_name} found directory in the build folder")
+        test_logs_dir_name_in_container = "test-logs"
+        test_logs_dir_name_in_zip = f"test-logs-{datetime.fromtimestamp(cast(float, self.context.pipeline_start_timestamp)).isoformat()}-{self.context.git_branch}-{self.gradle_task_name}".replace(
+            "/", "_"
+        )
+        if (
+            test_logs_dir_name_in_container
+            not in await gradle_container.directory(f"{self.context.connector.code_directory}/build").entries()
+        ):
+            self.context.logger.warn(f"No {test_logs_dir_name_in_container} found directory in the build folder")
             return None
         try:
             zip_file = await (
                 dagger_directory_as_zip_file(
                     self.dagger_client,
-                    await gradle_container.directory(f"{self.context.connector.code_directory}/build/{test_logs_dir_name}"),
-                    test_logs_dir_name,
+                    await gradle_container.directory(f"{self.context.connector.code_directory}/build/{test_logs_dir_name_in_container}"),
+                    test_logs_dir_name_in_zip,
                 )
             )
             return Artifact(
-                name="test-logs.zip",
+                name=f"{test_logs_dir_name_in_zip}.zip",
                 content=zip_file,
                 content_type="application/zip",
                 to_upload=True,
@@ -249,20 +256,26 @@ async def _collect_test_results(self, gradle_container: Container) -> Optional[A
         Only the XML files generated by junit are downloaded into the host filesystem
         One can change the destination directory by setting the outputs
         """
-        test_results_dir_name = "test-results"
-        if test_results_dir_name not in await gradle_container.directory(f"{self.context.connector.code_directory}/build").entries():
-            self.context.logger.warn(f"No {test_results_dir_name} found directory in the build folder")
+        test_results_dir_name_in_container = "test-results"
+        test_results_dir_name_in_zip = f"test-results-{datetime.fromtimestamp(cast(float, self.context.pipeline_start_timestamp)).isoformat()}-{self.context.git_branch}-{self.gradle_task_name}".replace(
+            "/", "_"
+        )
+        if (
+            test_results_dir_name_in_container
+            not in await gradle_container.directory(f"{self.context.connector.code_directory}/build").entries()
+        ):
+            self.context.logger.warn(f"No {test_results_dir_name_in_container} found directory in the build folder")
             return None
         try:
             zip_file = await (
                 dagger_directory_as_zip_file(
                     self.dagger_client,
-                    await gradle_container.directory(f"{self.context.connector.code_directory}/build/{test_results_dir_name}"),
-                    test_results_dir_name,
+                    await gradle_container.directory(f"{self.context.connector.code_directory}/build/{test_results_dir_name_in_container}"),
+                    test_results_dir_name_in_zip,
                 )
             )
             return Artifact(
-                name="test-results.zip",
+                name=f"{test_results_dir_name_in_zip}.zip",
                 content=zip_file,
                 content_type="application/zip",
                 to_upload=True,

airbyte-ci/connectors/pipelines/pipelines/models/artifacts.py

@@ -29,7 +29,9 @@ async def save_to_local_path(self, path: Path) -> Path:
             raise Exception(f"Failed to save artifact {self.name} to local path {path}")
 
     async def upload_to_gcs(self, dagger_client: dagger.Client, bucket: str, key: str, gcs_credentials: dagger.Secret) -> str:
-        gcs_cp_flags = None if self.content_type is None else [f"--content-type={self.content_type}"]
+        gcs_cp_flags = [f"--content-disposition=attachment;filename='{self.name}'"]
+        if self.content_type is not None:
+            gcs_cp_flags = gcs_cp_flags + [f"--content-type={self.content_type}"]
 
         report_upload_exit_code, _, _ = await remote_storage.upload_to_gcs(
             dagger_client=dagger_client,