Skip to content

Remove duplicate key #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove duplicate key #409

wants to merge 2 commits into from

Conversation

rsitrifork
Copy link
Contributor

@rsitrifork rsitrifork commented May 13, 2025

Remove duplicate key to fix #58591

What

The ENV entry for AB_JWT_SIGNATURE_SECRET was duplicated in the deployment, preventing Helm upgrades.

How

Remove one of the two duplicate entries

Recommended reading order

  1. deployment.yaml

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Remove duplicate key to fix #58591
@CLAassistant
Copy link

CLAassistant commented May 13, 2025

CLA assistant check
All committers have signed the CLA.

@dfeddad
Copy link

dfeddad commented May 16, 2025

I have been waiting for this to be merged for sometimes #402

@abedzantout
Copy link

Hi all — just checking in on this. It’s been open for a few weeks, and it’s currently a key blocker for deploying the latest version of Airbyte. Happy to contribute if there's any blockers preventing this from being merged

@fabio-wmp
Copy link

I have the same problem, does uninstall delete the volumes ?

@TheNumberOne
Copy link

@abuchanan-airbyte Would it be possible to get someone on the airbyte team to review and merge this

(I'm pinging you because you have the most commits in the last month)

@perangel perangel self-requested a review June 18, 2025 19:57
@perangel
Copy link
Contributor

Hey, thanks for bringing this to our attention. We'll process this PR internally and get this merged shortly

@perangel
Copy link
Contributor

/create-oss-pr

@mnacharov
Copy link

mnacharov commented Jun 20, 2025

@pmossman @perangel @abuchanan-airbyte can you please add this patch into the next chart release ? this bug is here for quite a long time ~ 2 months already (see #402)

@perangel
Copy link
Contributor

These changes have now been merged. A patch release of the chart is forthcoming

@chyzouakia
Copy link

These changes have now been merged. A patch release of the chart is forthcoming

Hello @perangel ! Hope you are doing fine 🙂
Do you know when this patch will be released ? It's blocking the upgrade on our side 😬
Thank you ! 🙏

@TheNumberOne
Copy link

@chyzouakia 1.7.1 was released with this change a few days ago ^-^

@chyzouakia
Copy link

@chyzouakia 1.7.1 was released with this change a few days ago ^-^

@TheNumberOne Hello ! No if you check the helm-charts repo and get the latest airbyte-1.7.1 tgz you'll see that the duplication is still there in charts/workload-api-server/templates/deployment.yaml. I still get the error when I try to upgrade. I upgraded manually by downloading the charts and fixing this issue. I hope it will be fixed in the next release so I don't need to have the helm charts locally 😄

@eugene-kuchansky-proxet
Copy link

@perangel @mnacharov it's "Closed with unmerged commits"
could you please fix?

@TheNumberOne
Copy link

@chyzouakia Yeah, you're right. I don't know why I thought it had the fix :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.