-
Notifications
You must be signed in to change notification settings - Fork 326
Remove duplicate key #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate key #409
Conversation
Remove duplicate key to fix #58591
I have been waiting for this to be merged for sometimes #402 |
Hi all — just checking in on this. It’s been open for a few weeks, and it’s currently a key blocker for deploying the latest version of Airbyte. Happy to contribute if there's any blockers preventing this from being merged |
I have the same problem, does uninstall delete the volumes ? |
@abuchanan-airbyte Would it be possible to get someone on the airbyte team to review and merge this (I'm pinging you because you have the most commits in the last month) |
Hey, thanks for bringing this to our attention. We'll process this PR internally and get this merged shortly |
/create-oss-pr |
@pmossman @perangel @abuchanan-airbyte can you please add this patch into the next chart release ? this bug is here for quite a long time ~ 2 months already (see #402) |
These changes have now been merged. A patch release of the chart is forthcoming |
Hello @perangel ! Hope you are doing fine 🙂 |
@chyzouakia 1.7.1 was released with this change a few days ago ^-^ |
@TheNumberOne Hello ! No if you check the |
@perangel @mnacharov it's "Closed with unmerged commits" |
@chyzouakia Yeah, you're right. I don't know why I thought it had the fix :/ |
Remove duplicate key to fix #58591
What
The ENV entry for AB_JWT_SIGNATURE_SECRET was duplicated in the deployment, preventing Helm upgrades.
How
Remove one of the two duplicate entries
Recommended reading order
deployment.yaml
Can this PR be safely reverted and rolled back?