Skip to content

Commit 559dc25

Browse files
committed
chore: delete remaining worker v1 config code (#13989)
1 parent 342f72e commit 559dc25

File tree

45 files changed

+65
-1488
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+65
-1488
lines changed

airbyte-analytics/src/main/kotlin/io/airbyte/analytics/TrackingClient.kt

-3
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ class SegmentTrackingClient(
121121
// deployment
122122
put(AIRBYTE_VERSION_KEY, deployment.getDeploymentVersion())
123123
put("deployment_mode", deployment.getDeploymentMode())
124-
put("deployment_env", deployment.getDeploymentEnvironment())
125124
put("deployment_id", deployment.getDeploymentId().toString())
126125

127126
// workspace (includes info that in the future we would store in an organization)
@@ -386,8 +385,6 @@ class Deployment(private val deploymentMetadata: DeploymentMetadataRead) {
386385

387386
fun getDeploymentId(): UUID = deploymentMetadata.id
388387

389-
fun getDeploymentEnvironment(): String = deploymentMetadata.environment
390-
391388
fun getDeploymentVersion(): String = deploymentMetadata.version
392389
}
393390

airbyte-analytics/src/main/kotlin/io/airbyte/analytics/config/AnalyticsTrackingBeanFactory.kt

-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import io.airbyte.config.Configs
77
import io.micronaut.context.annotation.Factory
88
import io.micronaut.context.annotation.Requires
99
import io.micronaut.context.annotation.Value
10-
import io.micronaut.context.env.Environment
1110
import io.micronaut.core.util.StringUtils
1211
import jakarta.inject.Named
1312
import jakarta.inject.Singleton
@@ -24,11 +23,9 @@ class AnalyticsTrackingBeanFactory {
2423
fun deploymentSupplier(
2524
airbyteVersion: AirbyteVersion,
2625
deploymentMode: Configs.DeploymentMode,
27-
environment: Environment,
2826
): Supplier<DeploymentMetadataRead> =
2927
Supplier {
3028
DeploymentMetadataRead(
31-
environment = getDeploymentEnvironment(environment),
3229
id = BLANK_UUID,
3330
mode = deploymentMode.name,
3431
version = airbyteVersion.serialize(),
@@ -68,11 +65,4 @@ class AnalyticsTrackingBeanFactory {
6865
creatorFunction: Function<String, T>,
6966
@Suppress("SameParameterValue") defaultValue: T,
7067
): T = if (StringUtils.isNotEmpty(value)) creatorFunction.apply(value.uppercase()) else defaultValue
71-
72-
private fun getDeploymentEnvironment(environment: Environment): String =
73-
if (environment.activeNames.contains(Environment.KUBERNETES)) {
74-
Configs.WorkerEnvironment.KUBERNETES.name
75-
} else {
76-
Configs.WorkerEnvironment.DOCKER.name
77-
}
7868
}

airbyte-analytics/src/test/kotlin/io/airbyte/analytics/DeploymentFetcherTest.kt

+1-4
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ class DeploymentFetcherTest {
2323
deploymentMetadata =
2424
DeploymentMetadataRead(
2525
id = deploymentId,
26-
environment = Configs.WorkerEnvironment.KUBERNETES.name,
27-
mode =
28-
Configs.DeploymentMode.OSS.name,
26+
mode = Configs.DeploymentMode.OSS.name,
2927
version = airbyteVersion.serialize(),
3028
)
3129
deploymentFetcher = DeploymentFetcher { deploymentMetadata }
@@ -35,7 +33,6 @@ class DeploymentFetcherTest {
3533
fun testRetrievingDeploymentMetadata() {
3634
val deployment = deploymentFetcher.get()
3735
assertEquals(deploymentMetadata.id, deployment.getDeploymentId())
38-
assertEquals(deploymentMetadata.environment, deployment.getDeploymentEnvironment())
3936
assertEquals(deploymentMetadata.mode, deployment.getDeploymentMode())
4037
assertEquals(deploymentMetadata.version, deployment.getDeploymentVersion())
4138
}

airbyte-analytics/src/test/kotlin/io/airbyte/analytics/SegmentTrackingClientTest.kt

-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import com.segment.analytics.messages.TrackMessage
1010
import io.airbyte.api.client.model.generated.DeploymentMetadataRead
1111
import io.airbyte.commons.version.AirbyteVersion
1212
import io.airbyte.config.Configs
13-
import io.airbyte.config.Configs.WorkerEnvironment
1413
import io.micronaut.http.HttpHeaders
1514
import io.micronaut.http.HttpRequest
1615
import io.micronaut.http.context.ServerRequestContext
@@ -30,7 +29,6 @@ class SegmentTrackingClientTest {
3029
private val deploymentMetadata: DeploymentMetadataRead =
3130
DeploymentMetadataRead(
3231
id = deploymentId,
33-
environment = WorkerEnvironment.KUBERNETES.name,
3432
mode = Configs.DeploymentMode.OSS.name,
3533
version = airbyteVersion.serialize(),
3634
)
@@ -78,7 +76,6 @@ class SegmentTrackingClientTest {
7876
mapOf(
7977
"anonymized" to identity.anonymousDataCollection!!,
8078
SegmentTrackingClient.AIRBYTE_VERSION_KEY to airbyteVersion.serialize(),
81-
"deployment_env" to deploymentMetadata.environment,
8279
"deployment_mode" to deploymentMetadata.mode,
8380
"deployment_id" to deploymentMetadata.id.toString(),
8481
EMAIL_KEY to identity.email!!,
@@ -111,7 +108,6 @@ class SegmentTrackingClientTest {
111108
"airbyte_role" to "role",
112109
SegmentTrackingClient.AIRBYTE_VERSION_KEY to airbyteVersion.serialize(),
113110
"anonymized" to identity.anonymousDataCollection!!,
114-
"deployment_env" to deploymentMetadata.environment,
115111
"deployment_mode" to deploymentMetadata.mode,
116112
"deployment_id" to deploymentMetadata.id.toString(),
117113
EMAIL_KEY to identity.email!!,
@@ -146,7 +142,6 @@ class SegmentTrackingClientTest {
146142
"airbyte_role" to "role",
147143
SegmentTrackingClient.AIRBYTE_VERSION_KEY to airbyteVersion.serialize(),
148144
"anonymized" to identity.anonymousDataCollection!!,
149-
"deployment_env" to deploymentMetadata.environment,
150145
"deployment_mode" to deploymentMetadata.mode,
151146
"deployment_id" to deploymentMetadata.id.toString(),
152147
EMAIL_KEY to identity.email!!,

airbyte-api/server-api/src/main/openapi/config.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -13019,13 +13019,10 @@ components:
1301913019
DeploymentMetadataRead:
1302013020
type: object
1302113021
required:
13022-
- environment
1302313022
- id
1302413023
- mode
1302513024
- version
1302613025
properties:
13027-
environment:
13028-
type: string
1302913026
id:
1303013027
type: string
1303113028
format: uuid

airbyte-commons-server/src/main/java/io/airbyte/commons/server/handlers/DeploymentMetadataHandler.java

+1-11
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import io.airbyte.api.model.generated.DeploymentMetadataRead;
88
import io.airbyte.commons.version.AirbyteVersion;
99
import io.airbyte.config.Configs;
10-
import io.micronaut.context.env.Environment;
1110
import jakarta.inject.Named;
1211
import jakarta.inject.Singleton;
1312
import java.util.UUID;
@@ -22,31 +21,22 @@ public class DeploymentMetadataHandler {
2221
private final AirbyteVersion airbyteVersion;
2322
private final Configs.DeploymentMode deploymentMode;
2423
private final DSLContext dslContext;
25-
private final Environment environment;
2624

2725
public DeploymentMetadataHandler(
2826
final AirbyteVersion airbyteVersion,
2927
final Configs.DeploymentMode deploymentMode,
30-
@Named("unwrappedConfig") final DSLContext dslContext,
31-
final Environment environment) {
28+
@Named("unwrappedConfig") final DSLContext dslContext) {
3229
this.airbyteVersion = airbyteVersion;
3330
this.deploymentMode = deploymentMode;
3431
this.dslContext = dslContext;
35-
this.environment = environment;
3632
}
3733

3834
public DeploymentMetadataRead getDeploymentMetadata() {
3935
final Result<org.jooq.Record> result = dslContext.fetch(DEPLOYMENT_ID_QUERY);
4036
final String deploymentId = result.getValue(0, "value").toString();
4137
return new DeploymentMetadataRead().id(UUID.fromString(deploymentId))
4238
.mode(deploymentMode.name())
43-
.environment(getEnvironment())
4439
.version(airbyteVersion.serialize());
4540
}
4641

47-
private String getEnvironment() {
48-
return environment.getActiveNames().contains(Environment.KUBERNETES) ? Configs.WorkerEnvironment.KUBERNETES.name()
49-
: Configs.WorkerEnvironment.DOCKER.name();
50-
}
51-
5242
}

airbyte-commons-server/src/test/java/io/airbyte/commons/server/handlers/DeploymentMetadataHandlerTest.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,16 @@ void testRetrievingDeploymentMetadata(final String activeEnvironment) {
3333
final DSLContext dslContext = mock(DSLContext.class);
3434
final Environment environment = mock(Environment.class);
3535
final Result<org.jooq.Record> result = mock(Result.class);
36-
final String expectedEnvironment =
37-
Environment.KUBERNETES.equals(activeEnvironment) ? Configs.WorkerEnvironment.KUBERNETES.name() : Configs.WorkerEnvironment.DOCKER.name();
3836

3937
when(result.getValue(anyInt(), anyString())).thenReturn(deploymentId);
4038
when(dslContext.fetch(anyString())).thenReturn(result);
4139
when(environment.getActiveNames()).thenReturn(Set.of(activeEnvironment));
4240

43-
final DeploymentMetadataHandler handler = new DeploymentMetadataHandler(airbyteVersion, deploymentMode, dslContext, environment);
41+
final DeploymentMetadataHandler handler = new DeploymentMetadataHandler(airbyteVersion, deploymentMode, dslContext);
4442

4543
final DeploymentMetadataRead deploymentMetadataRead = handler.getDeploymentMetadata();
4644

4745
assertEquals(deploymentId, deploymentMetadataRead.getId());
48-
assertEquals(expectedEnvironment, deploymentMetadataRead.getEnvironment());
4946
assertEquals(deploymentMode.name(), deploymentMetadataRead.getMode());
5047
assertEquals(version, deploymentMetadataRead.getVersion());
5148
}

airbyte-commons-temporal/src/main/java/io/airbyte/commons/temporal/config/CommonFactory.java

-23
This file was deleted.

airbyte-commons-with-dependencies/src/main/java/io/airbyte/commons/workers/config/ConfigurationBeanFactory.java

-107
This file was deleted.

0 commit comments

Comments
 (0)