Skip to content

Commit 54849f2

Browse files
committed
design: use standard empty state for dbt cloud transformations tab (#13944)
1 parent bc351cc commit 54849f2

File tree

4 files changed

+10
-25
lines changed

4 files changed

+10
-25
lines changed

airbyte-webapp/src/pages/connections/ConnectionTransformationPage/DbtCloudTransformations/DbtCloudTransformationsForm/DbtCloudTransformationsFormControls.tsx

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
import classNames from "classnames";
12
import React from "react";
23
import { useFieldArray, useFormState } from "react-hook-form";
34
import { FormattedMessage } from "react-intl";
45

6+
import { EmptyState } from "components/EmptyState";
57
import { Box } from "components/ui/Box";
68
import { Button } from "components/ui/Button";
79
import { DropdownMenu } from "components/ui/DropdownMenu";
@@ -15,7 +17,6 @@ import { DbtCloudTransformationsFormValues } from "./DbtCloudTransformationsForm
1517
import styles from "./DbtCloudTransformationsFormControls.module.scss";
1618
import { NoDbtIntegrationMsg } from "./NoDbtIntegrationMessage";
1719
import { NoJobsFoundForAccountMsg } from "./NoJobsFoundForAccountMessage";
18-
import { NoJobsPlaceholder } from "./NoJobsPlaceholder";
1920
import { JobListItem } from "../JobListItem";
2021

2122
interface DbtCloudTransformationsFormControlsProps {
@@ -67,7 +68,7 @@ export const DbtCloudTransformationsFormControls: React.FC<DbtCloudTransformatio
6768
)
6869
) : null}
6970
</FlexContainer>
70-
<Box p="md" className={styles.cardBodyContainer}>
71+
<Box p="md" className={classNames({ [styles.cardBodyContainer]: !isFormFieldsEmpty })}>
7172
{!isFormFieldsEmpty ? (
7273
<FlexContainer direction="column" gap="md">
7374
{fields.map((field, index) => (
@@ -77,7 +78,13 @@ export const DbtCloudTransformationsFormControls: React.FC<DbtCloudTransformatio
7778
) : (
7879
<FlexContainer alignItems="center" justifyContent="center">
7980
<FlexContainer direction="column" alignItems="center">
80-
{!hasDbtIntegration ? <NoDbtIntegrationMsg /> : isFormFieldsEmpty ? <NoJobsPlaceholder /> : null}
81+
{!hasDbtIntegration ? (
82+
<NoDbtIntegrationMsg />
83+
) : isFormFieldsEmpty ? (
84+
<Box py="lg">
85+
<EmptyState icon="folder" text={<FormattedMessage id="connection.dbtCloudJobs.noJobs" />} />
86+
</Box>
87+
) : null}
8188
</FlexContainer>
8289
</FlexContainer>
8390
)}

airbyte-webapp/src/pages/connections/ConnectionTransformationPage/DbtCloudTransformations/DbtCloudTransformationsForm/NoJobsPlaceholder.module.scss

-7
This file was deleted.

airbyte-webapp/src/pages/connections/ConnectionTransformationPage/DbtCloudTransformations/DbtCloudTransformationsForm/NoJobsPlaceholder.tsx

-15
This file was deleted.

0 commit comments

Comments
 (0)