fix: excude inactive connections from all counts except paused (#16944)

Author: clnoll

airbyte-data/src/main/kotlin/io/airbyte/data/services/impls/jooq/ConnectionServiceJooqImpl.kt

@@ -1775,11 +1775,11 @@ class ConnectionServiceJooqImpl
       val sql =
         """
         SELECT
-          COALESCE(SUM(CASE WHEN lj.latest_status = 'running' THEN 1 ELSE 0 END), 0) AS running,
-          COALESCE(SUM(CASE WHEN lj.latest_status = 'succeeded' THEN 1 ELSE 0 END), 0) AS healthy,
-          COALESCE(SUM(CASE WHEN lj.latest_status IN ('failed', 'cancelled', 'incomplete') THEN 1 ELSE 0 END), 0) AS failed,
+          COALESCE(SUM(CASE WHEN c.status != 'inactive' AND lj.latest_status = 'running' THEN 1 ELSE 0 END), 0) AS running,
+          COALESCE(SUM(CASE WHEN c.status != 'inactive' AND lj.latest_status = 'succeeded' THEN 1 ELSE 0 END), 0) AS healthy,
+          COALESCE(SUM(CASE WHEN c.status != 'inactive' AND lj.latest_status IN ('failed', 'cancelled', 'incomplete') THEN 1 ELSE 0 END), 0) AS failed,
           COALESCE(SUM(CASE WHEN c.status = 'inactive' THEN 1 ELSE 0 END), 0) AS paused,
-          COALESCE(SUM(CASE WHEN lj.latest_status IS NULL AND c.status != 'inactive' THEN 1 ELSE 0 END), 0) AS not_synced
+          COALESCE(SUM(CASE WHEN c.status != 'inactive' AND lj.latest_status IS NULL THEN 1 ELSE 0 END), 0) AS not_synced
         FROM connection c
         JOIN actor a ON c.source_id = a.id
         LEFT JOIN LATERAL (

airbyte-data/src/test/java/io/airbyte/data/services/impls/jooq/ConnectionServiceJooqImplTest.java

@@ -364,6 +364,11 @@ void testGetConnectionStatusCounts() throws IOException, JsonValidationException
         .withStatus(StandardSync.Status.ACTIVE);
     connectionServiceJooqImpl.writeStandardSync(notSyncedConnection);
 
+    // Connection 4: Inactive but last job succeeded
+    final StandardSync pausedWithJobSucceededConnection = createStandardSync(source, destination, streams)
+        .withStatus(StandardSync.Status.INACTIVE);
+    connectionServiceJooqImpl.writeStandardSync(pausedWithJobSucceededConnection);
+
     // Insert job records using raw SQL since we need to work with the jobs database
     database.query(ctx -> {
       final var now = OffsetDateTime.now();
@@ -452,6 +457,18 @@ void testGetConnectionStatusCounts() throws IOException, JsonValidationException
           .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.CONFIG, org.jooq.impl.DSL.field("'{}'::jsonb", org.jooq.JSONB.class))
           .execute();
 
+      // Job for successful sync but paused connection
+      ctx.insertInto(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS)
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.ID, 8L)
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.CONFIG_TYPE,
+              io.airbyte.db.instance.jobs.jooq.generated.enums.JobConfigType.sync)
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.SCOPE, pausedWithJobSucceededConnection.getConnectionId().toString())
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.STATUS, io.airbyte.db.instance.jobs.jooq.generated.enums.JobStatus.succeeded)
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.CREATED_AT, now.minusHours(2))
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.UPDATED_AT, now.minusHours(2))
+          .set(io.airbyte.db.instance.jobs.jooq.generated.Tables.JOBS.CONFIG, org.jooq.impl.DSL.field("'{}'::jsonb", org.jooq.JSONB.class))
+          .execute();
+
       return null;
     });
 
@@ -461,7 +478,7 @@ void testGetConnectionStatusCounts() throws IOException, JsonValidationException
     assertEquals(1, result.healthy());
     // failedConnection + cancelledConnection + incompleteConnection
     assertEquals(3, result.failed());
-    assertEquals(1, result.paused());
+    assertEquals(2, result.paused());
     // notSyncedConnection (active connection with no jobs)
     assertEquals(1, result.notSynced());
   }