-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Deprecate BasicAuth in favor of middleware based auth #10921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Or even just ask users to set the header, which is going to more efficient. A middleware to set a header on every request to a fixed value is probably overkill (as is the existing BasicAuth implementation). |
While more efficient, I expect it to be beyond the skill level of many first time users |
We also need to think about the case or the username and password is embedded in the URL |
Maybe the encoding, but we can keep a helper for that. So, already today, you could probably just do: |
I think that's a separate thing from the auth parameter, so probably little to do there. There are tests for it anyway, so it won't be forgotten. |
Uh oh!
There was an error while loading. Please reload this page.
We can replace BasicAuth and proxy auth with a middleware helper instead so we don't have to maintain two methods. This will be a long deprecation cycle.
The text was updated successfully, but these errors were encountered: