Skip to content

Commit 57c7f55

Browse files
committed
set the start register range to 0
1 parent 5e4b3f1 commit 57c7f55

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

bms-shoto-modbus/src/main/java/com/airepublic/bmstoinverter/bms/shoto/modbus/ShotoBmsModbusProcessor.java

+9-7
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,16 @@ public class ShotoBmsModbusProcessor extends BMS {
3434

3535
@Override
3636
protected void collectData(final Port port) {
37+
final int startRange = 0;
38+
3739
try {
38-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x0001, 1, getBmsId(), this::readBatteryVoltage);
39-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x0005, 2, getBmsId(), this::readCellMinMaxTemperature);
40-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x0012, 32, getBmsId(), this::readCellVoltageAndTemperature);
41-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x0101, 2, getBmsId(), this::readHardwareSoftwareVersion);
42-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x010F, 1, getBmsId(), this::readNumberOfCells);
43-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x1010, 1, getBmsId(), this::readMaxDischargeVoltage);
44-
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, 30000 + 0x1031, 18, getBmsId(), this::readBatteryStatus);
40+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x0001, 1, getBmsId(), this::readBatteryVoltage);
41+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x0005, 2, getBmsId(), this::readCellMinMaxTemperature);
42+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x0012, 32, getBmsId(), this::readCellVoltageAndTemperature);
43+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x0101, 2, getBmsId(), this::readHardwareSoftwareVersion);
44+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x010F, 1, getBmsId(), this::readNumberOfCells);
45+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x1010, 1, getBmsId(), this::readMaxDischargeVoltage);
46+
sendMessage(port, RegisterCode.READ_HOLDING_REGISTERS, startRange + 0x1031, 18, getBmsId(), this::readBatteryStatus);
4547
} catch (final IOException e) {
4648
LOG.error("Error reading from modbus!", e);
4749
}

0 commit comments

Comments
 (0)