Skip to content

Commit f808ea2

Browse files
GeorgeHahnjszwedko
andauthored
chore(CI): Switch regression detector to new API and analysis service (vectordotdev#17912)
This should be a transparent change. If you notice any issues, please ping us in #single-machine-performance. We'll also be keeping a close eye on things after this is merged. ## Single Machine Performance API (`curta`) The Single Machine Performance team has built an API to interact with the regression detector system. This will allow us to maintain reliability while continuing to evolve the system. This is enabled with the `--use-curta` flag, which will become the default in an upcoming release. The curta API uses a unique URI for each team. This isn't secret - all endpoints have authorization - but we'd prefer it not be public. The URI for Vector is in SMP-617. The `smp` binary can read this from the `SINGLE_MACHINE_PERFORMANCE_API` environment variable or the `--api-base` flag. ## Lambda Analysis Worker (`consignor`) We have also changed how the analysis worker is deployed so it can run on-demand for incoming requests. This improves analysis speed while reducing our operational workload. This is set using the `--use-consignor` flag, which will also become the default in a future release. --------- Co-authored-by: Jesse Szwedko <[email protected]>
1 parent f8461cb commit f808ea2

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

.github/actions/spelling/allow.txt

+1
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,7 @@ compiletime
246246
coredns
247247
corejs
248248
coreutils
249+
curta
249250
daemonset
250251
databend
251252
datacenter

.github/workflows/regression.yml

+11-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ concurrency:
3737
group: ${{ github.workflow }}-${{ github.event.merge_group.head_sha || github.sha }}
3838
cancel-in-progress: true
3939

40+
env:
41+
SINGLE_MACHINE_PERFORMANCE_API: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_API }}
42+
4043
jobs:
4144

4245
# Only run this workflow if files changed in areas that could possibly introduce a regression
@@ -229,7 +232,7 @@ jobs:
229232
export REPLICAS="10"
230233
export TOTAL_SAMPLES="600"
231234
export P_VALUE="0.1"
232-
export SMP_CRATE_VERSION="0.7.3"
235+
export SMP_CRATE_VERSION="0.9.0"
233236
export LADING_VERSION="0.12.0"
234237
235238
echo "warmup seconds: ${WARMUP_SECONDS}"
@@ -496,6 +499,7 @@ jobs:
496499
chmod +x ${{ runner.temp }}/bin/smp
497500
498501
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job submit \
502+
--use-curta \
499503
--lading-version ${{ needs.compute-metadata.outputs.lading-version }} \
500504
--total-samples ${{ needs.compute-metadata.outputs.total-samples }} \
501505
--warmup-seconds ${{ needs.compute-metadata.outputs.warmup-seconds }} \
@@ -525,6 +529,7 @@ jobs:
525529
chmod +x ${{ runner.temp }}/bin/smp
526530
527531
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job status \
532+
--use-curta \
528533
--wait \
529534
--wait-delay-seconds 60 \
530535
--wait-timeout-minutes 90 \
@@ -537,6 +542,7 @@ jobs:
537542
run: |
538543
chmod +x ${{ runner.temp }}/bin/smp
539544
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job cancel \
545+
--use-curta \
540546
--submission-metadata ${{ runner.temp }}/submission-metadata
541547
542548
- name: Check status, cancelled
@@ -617,6 +623,8 @@ jobs:
617623
chmod +x ${{ runner.temp }}/bin/smp
618624
619625
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job result \
626+
--use-curta \
627+
--use-consignor \
620628
--submission-metadata ${{ runner.temp }}/submission-metadata
621629
622630
- name: Check status, cancelled
@@ -708,6 +716,8 @@ jobs:
708716
chmod +x ${{ runner.temp }}/bin/smp
709717
710718
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job sync \
719+
--use-curta \
720+
--use-consignor \
711721
--submission-metadata ${{ runner.temp }}/submission-metadata \
712722
--output-path "${{ runner.temp }}/outputs"
713723

0 commit comments

Comments
 (0)