Skip to content

Commit 7699f4d

Browse files
authored
chore(ci): update comment_trigger note about concurrency groups (vectordotdev#17491)
1 parent 84f0ada commit 7699f4d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/comment-trigger.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ env:
3434
# can be removed when we switch back to the upstream openssl-sys crate
3535
CARGO_NET_GIT_FETCH_WITH_CLI: true
3636

37-
# TODO: temporarily disabling concurrency groups at request of GitHub Support, to see if it resolves
38-
# the issue we are having.
37+
# The below concurrency group settings would let us cancel in progress runs that were triggered with the
38+
# same comment on a given PR, which could save on time consuming runs.
39+
# But GH does not currently support the github.event.comment.body as part of the concurrency name, this
40+
# appears to be due to the potential length of it.
3941
#concurrency:
40-
# group: ${{ github.workflow }}-${{ github.event.issue_comment.issue.id }}-${{ github.event.comment.body }}
42+
# group: ${{ github.workflow }}-${{ github.event.issue.id }}-${{ github.event.comment.body }}
4143
# cancel-in-progress: true
4244

4345
jobs:

0 commit comments

Comments
 (0)