Skip to content

Commit 8738826

Browse files
committed
Remove an unused build stage (and add a note)
The question posed in the previous commit was a legitimate question on my part, but I failed to make that clear and instead just wrote it without context while I pushed it and went to search for the answer. And on second reading, I feel like it comes across as having an accusatory tone toward the maintainers of the official open source Docker image, which is actively harmful of me. I want to append onto that commit to note: I expected that there would be a clear explanation for this default, and there was, and it is clear that the correct default was set for this context. More importantly, I was able to confirm that I'm not doing something _truly_ horrible, i.e. that this wasn't set because it would actively break something around how the Go distribution is configured in this specific image. I apologize for the poor message on my part, and hope that this additional note serves as a concrete step in the right direction.
1 parent 83dce53 commit 8738826

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

Dockerfile

-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ RUN \
2020
./cmd/randomizer-server
2121

2222

23-
FROM scratch AS server-binary
24-
COPY --link --from=build /randomizer-server /
25-
26-
2723
FROM $ALPINE_BASE AS server-image
2824
COPY --link --from=build /randomizer-server /usr/local/bin/randomizer-server
2925
EXPOSE 7636

0 commit comments

Comments
 (0)