Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMAIN inherited from postgres TEXT doesn't get appended to the sqlalchemy.dialects.postgresql imports #379

Open
2 tasks done
henrikmathisen opened this issue Feb 26, 2025 · 1 comment
Labels
Milestone

Comments

@henrikmathisen
Copy link

Things to check first

  • I have searched the existing issues and didn't find my bug already reported there

  • I have checked that my bug is still present in the latest release

Sqlacodegen version

3.0.0rc5

SQLAlchemy version

2.0.34

RDBMS vendor

PostgreSQL

What happened?

DOMAIN types from postgres that inherits from TEXT are correctly identified but aren't included in the
sqlalchemy.dialects.postgresql imports (maybe clashes with the lower case text import from sqlalchemy?)
resulting in NameError: name 'TEXT' is not defined, manually adding TEXT to the imports resolves the issue.

Database schema for reproducing the bug

No response

@sheinbergon sheinbergon added this to the 3.1 milestone Feb 28, 2025
@sheinbergon sheinbergon marked this as a duplicate of #230 Feb 28, 2025
@sheinbergon
Copy link
Collaborator

@henrikmathisen can you please test with the lastest 3.0.0 release?
Van you provide a simple table definition to reproduce this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants