Skip to content

Consider using actions/upload and download artifact actions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steveoh opened this issue Feb 6, 2025 · 2 comments
Open

Consider using actions/upload and download artifact actions #84

steveoh opened this issue Feb 6, 2025 · 2 comments

Comments

@steveoh
Copy link
Member

steveoh commented Feb 6, 2025

This best practice seems like something we can apply to this action to increase our security posture.

- name: ⬆️ Upload artifacts
        uses: actions/upload-artifact@v4
        with:
          name: build-artifacts
          path: dist
          retention-days: 1
 - name: ⬇️ Download artifacts
        uses: actions/download-artifact@v4
        with:
          name: build-artifacts
          path: dist
@stdavis
Copy link
Member

stdavis commented Feb 6, 2025

Would we have to split this into two separate actions so that we could use them in separate jobs in our workflows?

@steveoh
Copy link
Member Author

steveoh commented Feb 6, 2025

If the token permission can only be done at the job level, then I suppose it would?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants