Skip to content

ranked_in_list returns incorrect ranks if some members dont exist #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clevercricket opened this issue Oct 5, 2017 · 1 comment
Open

ranked_in_list returns incorrect ranks if some members dont exist #48

clevercricket opened this issue Oct 5, 2017 · 1 comment

Comments

@clevercricket
Copy link

Use CompetitionLeaderboard and i have a set of friends - some of whom may or may not be part of the Leaderboard. When i call ranked_in_list with the complete list of my friends, it returns incorrect ranks for some of the friends who are part of the Leaderboard.
@czarneckid
Copy link
Member

@clevercricket In this case, I would include the option include_missing=False in the call to ranked_in_list. This seems like the only correct option in this scenario, but I need to think on it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@czarneckid @clevercricket