Support bridgeless architecture lazy loaded functions #396

andrewzey · 2024-10-30T02:06:52Z

Description

Exports functions properly for bridgeless architecture that is default as of react native 0.76.0

Fixes #395

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have checked my code and corrected any misspellings

Ashalbulk

Well done!
Small adjustment:

import { Activities, Observers, Permissions, Units } from './src/constants'

const { AppleHealthKit } = require('react-native').NativeModules

export const HealthKit = {
  initHealthKit: AppleHealthKit.initHealthKit,
  isAvailable: AppleHealthKit.isAvailable,
  getBiologicalSex: AppleHealthKit.getBiologicalSex,
  getBloodType: AppleHealthKit.getBloodType,
  getDateOfBirth: AppleHealthKit.getDateOfBirth,
  getLatestWeight: AppleHealthKit.getLatestWeight,
  getWeightSamples: AppleHealthKit.getWeightSamples,
  saveWeight: AppleHealthKit.saveWeight,
  getLatestHeight: AppleHealthKit.getLatestHeight,
  getHeightSamples: AppleHealthKit.getHeightSamples,
  saveHeight: AppleHealthKit.saveHeight,
  getLatestWaistCircumference: AppleHealthKit.getLatestWaistCircumference,
  getWaistCircumferenceSamples: AppleHealthKit.getWaistCircumferenceSamples,
  saveWaistCircumference: AppleHealthKit.saveWaistCircumference,
  getLatestPeakFlow: AppleHealthKit.getLatestPeakFlow,
  getPeakFlowSamples: AppleHealthKit.getPeakFlowSamples,
  savePeakFlow: AppleHealthKit.savePeakFlow,
  saveLeanBodyMass: AppleHealthKit.saveLeanBodyMass,
  getLatestBmi: AppleHealthKit.getLatestBmi,
  getBmiSamples: AppleHealthKit.getBmiSamples,
  saveBmi: AppleHealthKit.saveBmi,
  getLatestBodyFatPercentage: AppleHealthKit.getLatestBodyFatPercentage,
  getBodyFatPercentageSamples: AppleHealthKit.getBodyFatPercentageSamples,
  getLatestLeanBodyMass: AppleHealthKit.getLatestLeanBodyMass,
  getLeanBodyMassSamples: AppleHealthKit.getLeanBodyMassSamples,
  getStepCount: AppleHealthKit.getStepCount,
  getSamples: AppleHealthKit.getSamples,
  getAnchoredWorkouts: AppleHealthKit.getAnchoredWorkouts,
  getDailyStepCountSamples: AppleHealthKit.getDailyStepCountSamples,
  saveSteps: AppleHealthKit.saveSteps,
  saveWalkingRunningDistance: AppleHealthKit.saveWalkingRunningDistance,
  getDistanceWalkingRunning: AppleHealthKit.getDistanceWalkingRunning,
  getDailyDistanceWalkingRunningSamples: AppleHealthKit.getDailyDistanceWalkingRunningSamples,
  getDistanceCycling: AppleHealthKit.getDistanceCycling,
  getDailyDistanceCyclingSamples: AppleHealthKit.getDailyDistanceCyclingSamples,
  getFlightsClimbed: AppleHealthKit.getFlightsClimbed,
  getDailyFlightsClimbedSamples: AppleHealthKit.getDailyFlightsClimbedSamples,
  getEnergyConsumedSamples: AppleHealthKit.getEnergyConsumedSamples,
  getProteinSamples: AppleHealthKit.getProteinSamples,
  getFiberSamples: AppleHealthKit.getFiberSamples,
  getTotalFatSamples: AppleHealthKit.getTotalFatSamples,
  saveFood: AppleHealthKit.saveFood,
  saveWater: AppleHealthKit.saveWater,
  getWater: AppleHealthKit.getWater,
  saveHeartRateSample: AppleHealthKit.saveHeartRateSample,
  getWaterSamples: AppleHealthKit.getWaterSamples,
  getHeartRateSamples: AppleHealthKit.getHeartRateSamples,
  getRestingHeartRate: AppleHealthKit.getRestingHeartRate,
  getWalkingHeartRateAverage: AppleHealthKit.getWalkingHeartRateAverage,
  getActiveEnergyBurned: AppleHealthKit.getActiveEnergyBurned,
  getBasalEnergyBurned: AppleHealthKit.getBasalEnergyBurned,
  getAppleExerciseTime: AppleHealthKit.getAppleExerciseTime,
  getAppleStandTime: AppleHealthKit.getAppleStandTime,
  getVo2MaxSamples: AppleHealthKit.getVo2MaxSamples,
  getBodyTemperatureSamples: AppleHealthKit.getBodyTemperatureSamples,
  getBloodPressureSamples: AppleHealthKit.getBloodPressureSamples,
  getRespiratoryRateSamples: AppleHealthKit.getRespiratoryRateSamples,
  getHeartRateVariabilitySamples: AppleHealthKit.getHeartRateVariabilitySamples,
  getHeartbeatSeriesSamples: AppleHealthKit.getHeartbeatSeriesSamples,
  getRestingHeartRateSamples: AppleHealthKit.getRestingHeartRateSamples,
  getBloodGlucoseSamples: AppleHealthKit.getBloodGlucoseSamples,
  getCarbohydratesSamples: AppleHealthKit.getCarbohydratesSamples,
  saveBloodGlucoseSample: AppleHealthKit.saveBloodGlucoseSample,
  saveCarbohydratesSample: AppleHealthKit.saveCarbohydratesSample,
  deleteBloodGlucoseSample: AppleHealthKit.deleteBloodGlucoseSample,
  deleteCarbohydratesSample: AppleHealthKit.deleteCarbohydratesSample,
  getSleepSamples: AppleHealthKit.getSleepSamples,
  getInfo: AppleHealthKit.getInfo,
  getMindfulSession: AppleHealthKit.getMindfulSession,
  saveMindfulSession: AppleHealthKit.saveMindfulSession,
  getWorkoutRouteSamples: AppleHealthKit.getWorkoutRouteSamples,
  saveWorkout: AppleHealthKit.saveWorkout,
  getAuthStatus: AppleHealthKit.getAuthStatus,
  getLatestBloodAlcoholContent: AppleHealthKit.getLatestBloodAlcoholContent,
  getBloodAlcoholContentSamples: AppleHealthKit.getBloodAlcoholContentSamples,
  saveBloodAlcoholContent: AppleHealthKit.saveBloodAlcoholContent,
  getDistanceSwimming: AppleHealthKit.getDistanceSwimming,
  getDailyDistanceSwimmingSamples: AppleHealthKit.getDailyDistanceSwimmingSamples,
  getOxygenSaturationSamples: AppleHealthKit.getOxygenSaturationSamples,
  getElectrocardiogramSamples: AppleHealthKit.getElectrocardiogramSamples,
  saveBodyFatPercentage: AppleHealthKit.saveBodyFatPercentage,
  saveBodyTemperature: AppleHealthKit.saveBodyTemperature,
  getEnvironmentalAudioExposure: AppleHealthKit.getEnvironmentalAudioExposure,
  getHeadphoneAudioExposure: AppleHealthKit.getHeadphoneAudioExposure,
  getClinicalRecords: AppleHealthKit.getClinicalRecords,
  getActivitySummary: AppleHealthKit.getActivitySummary,
  getInsulinDeliverySamples: AppleHealthKit.getInsulinDeliverySamples,
  saveInsulinDeliverySample: AppleHealthKit.saveInsulinDeliverySample,
  deleteInsulinDeliverySample: AppleHealthKit.deleteInsulinDeliverySample,

  Constants: {
    Activities,
    Observers,
    Permissions,
    Units,
  },
}

module.exports = HealthKit

andrewzey · 2024-10-31T23:09:25Z

@Ashalbulk Thanks for the review. I updated the code accordingly as well as my yarn patch and confirmed this works properly on React Native 0.76.0 bridgeless architecture both in development (using Xcode 16.1 running on iOS 18.1 simulator) as well as in production physically on a device (iPhone 15 Pro @ iOS 18.0.1 built via Bitrise using XCode 16.0)

willashley23 · 2024-11-18T02:52:59Z

Thanks for putting this PR up! Are there any blockers with merging this in? I rely on this library and would love to be able to update to the new arch!

ben-edge · 2024-11-21T12:59:01Z

Also relying on this to upgrade to 0.76! Would be great to get this in please.

garywongzc · 2024-12-02T14:17:31Z

Thanks for the PR! Is there anything preventing it from being merged? Would love to see this released soon. Thanks

andrewzey · 2024-12-02T23:35:30Z

garywongzc

LGTM

garywongzc · 2024-12-03T12:39:13Z

Hey @GGGava @ruan-azevedo can you help us with this PR please? 🙏

…ise#396

ghure · 2024-12-14T17:07:45Z

Guys can you please merge this PR.

ghure

Changes looks good to me

carozo

hey, using this on Android is throwing this error:

I was able to fix it using optional chaining:

  initHealthKit: AppleHealthKit?.initHealthKit,
  isAvailable: AppleHealthKit?.isAvailable,
  getBiologicalSex: AppleHealthKit?.getBiologicalSex,
  getBloodType: AppleHealthKit?.getBloodType,
  getDateOfBirth: AppleHealthKit?.getDateOfBirth,
  getLatestWeight: AppleHealthKit?.getLatestWeight,
  getWeightSamples: AppleHealthKit?.getWeightSamples,
  saveWeight: AppleHealthKit?.saveWeight,
  getLatestHeight: AppleHealthKit?.getLatestHeight,
  getHeightSamples: AppleHealthKit?.getHeightSamples,
  saveHeight: AppleHealthKit?.saveHeight,
  getLatestWaistCircumference: AppleHealthKit?.getLatestWaistCircumference,
  getWaistCircumferenceSamples: AppleHealthKit?.getWaistCircumferenceSamples,
  saveWaistCircumference: AppleHealthKit?.saveWaistCircumference,
  getLatestPeakFlow: AppleHealthKit?.getLatestPeakFlow,
  getPeakFlowSamples: AppleHealthKit?.getPeakFlowSamples,
  savePeakFlow: AppleHealthKit?.savePeakFlow,
  saveLeanBodyMass: AppleHealthKit?.saveLeanBodyMass,
  getLatestBmi: AppleHealthKit?.getLatestBmi,
  getBmiSamples: AppleHealthKit?.getBmiSamples,
  saveBmi: AppleHealthKit?.saveBmi,
  getLatestBodyFatPercentage: AppleHealthKit?.getLatestBodyFatPercentage,
  getBodyFatPercentageSamples: AppleHealthKit?.getBodyFatPercentageSamples,
  getLatestLeanBodyMass: AppleHealthKit?.getLatestLeanBodyMass,
  getLeanBodyMassSamples: AppleHealthKit?.getLeanBodyMassSamples,
  getStepCount: AppleHealthKit?.getStepCount,
  getSamples: AppleHealthKit?.getSamples,
  getAnchoredWorkouts: AppleHealthKit?.getAnchoredWorkouts,
  getDailyStepCountSamples: AppleHealthKit?.getDailyStepCountSamples,
  saveSteps: AppleHealthKit?.saveSteps,
  saveWalkingRunningDistance: AppleHealthKit?.saveWalkingRunningDistance,
  getDistanceWalkingRunning: AppleHealthKit?.getDistanceWalkingRunning,
  getDailyDistanceWalkingRunningSamples: AppleHealthKit?.getDailyDistanceWalkingRunningSamples,
  getDistanceCycling: AppleHealthKit?.getDistanceCycling,
  getDailyDistanceCyclingSamples: AppleHealthKit?.getDailyDistanceCyclingSamples,
  getFlightsClimbed: AppleHealthKit?.getFlightsClimbed,
  getDailyFlightsClimbedSamples: AppleHealthKit?.getDailyFlightsClimbedSamples,
  getEnergyConsumedSamples: AppleHealthKit?.getEnergyConsumedSamples,
  getProteinSamples: AppleHealthKit?.getProteinSamples,
  getFiberSamples: AppleHealthKit?.getFiberSamples,
  getTotalFatSamples: AppleHealthKit?.getTotalFatSamples,
  saveFood: AppleHealthKit?.saveFood,
  saveWater: AppleHealthKit?.saveWater,
  getWater: AppleHealthKit?.getWater,
  saveHeartRateSample: AppleHealthKit?.saveHeartRateSample,
  getWaterSamples: AppleHealthKit?.getWaterSamples,
  getHeartRateSamples: AppleHealthKit?.getHeartRateSamples,
  getRestingHeartRate: AppleHealthKit?.getRestingHeartRate,
  getWalkingHeartRateAverage: AppleHealthKit?.getWalkingHeartRateAverage,
  getActiveEnergyBurned: AppleHealthKit?.getActiveEnergyBurned,
  getBasalEnergyBurned: AppleHealthKit?.getBasalEnergyBurned,
  getAppleExerciseTime: AppleHealthKit?.getAppleExerciseTime,
  getAppleStandTime: AppleHealthKit?.getAppleStandTime,
  getVo2MaxSamples: AppleHealthKit?.getVo2MaxSamples,
  getBodyTemperatureSamples: AppleHealthKit?.getBodyTemperatureSamples,
  getBloodPressureSamples: AppleHealthKit?.getBloodPressureSamples,
  getRespiratoryRateSamples: AppleHealthKit?.getRespiratoryRateSamples,
  getHeartRateVariabilitySamples: AppleHealthKit?.getHeartRateVariabilitySamples,
  getHeartbeatSeriesSamples: AppleHealthKit?.getHeartbeatSeriesSamples,
  getRestingHeartRateSamples: AppleHealthKit?.getRestingHeartRateSamples,
  getBloodGlucoseSamples: AppleHealthKit?.getBloodGlucoseSamples,
  getCarbohydratesSamples: AppleHealthKit?.getCarbohydratesSamples,
  saveBloodGlucoseSample: AppleHealthKit?.saveBloodGlucoseSample,
  saveCarbohydratesSample: AppleHealthKit?.saveCarbohydratesSample,
  deleteBloodGlucoseSample: AppleHealthKit?.deleteBloodGlucoseSample,
  deleteCarbohydratesSample: AppleHealthKit?.deleteCarbohydratesSample,
  getSleepSamples: AppleHealthKit?.getSleepSamples,
  getInfo: AppleHealthKit?.getInfo,
  getMindfulSession: AppleHealthKit?.getMindfulSession,
  saveMindfulSession: AppleHealthKit?.saveMindfulSession,
  getWorkoutRouteSamples: AppleHealthKit?.getWorkoutRouteSamples,
  saveWorkout: AppleHealthKit?.saveWorkout,
  getAuthStatus: AppleHealthKit?.getAuthStatus,
  getLatestBloodAlcoholContent: AppleHealthKit?.getLatestBloodAlcoholContent,
  getBloodAlcoholContentSamples: AppleHealthKit?.getBloodAlcoholContentSamples,
  saveBloodAlcoholContent: AppleHealthKit?.saveBloodAlcoholContent,
  getDistanceSwimming: AppleHealthKit?.getDistanceSwimming,
  getDailyDistanceSwimmingSamples: AppleHealthKit?.getDailyDistanceSwimmingSamples,
  getOxygenSaturationSamples: AppleHealthKit?.getOxygenSaturationSamples,
  getElectrocardiogramSamples: AppleHealthKit?.getElectrocardiogramSamples,
  saveBodyFatPercentage: AppleHealthKit?.saveBodyFatPercentage,
  saveBodyTemperature: AppleHealthKit?.saveBodyTemperature,
  getEnvironmentalAudioExposure: AppleHealthKit?.getEnvironmentalAudioExposure,
  getHeadphoneAudioExposure: AppleHealthKit?.getHeadphoneAudioExposure,
  getClinicalRecords: AppleHealthKit?.getClinicalRecords,
  getActivitySummary: AppleHealthKit?.getActivitySummary,
  getInsulinDeliverySamples: AppleHealthKit?.getInsulinDeliverySamples,
  saveInsulinDeliverySample: AppleHealthKit?.saveInsulinDeliverySample,
  deleteInsulinDeliverySample: AppleHealthKit?.deleteInsulinDeliverySample,

bfblackjack · 2024-12-29T04:13:03Z

Can we get this reviewed/merged, please?

fmmattioni · 2025-01-02T13:57:50Z

I believe this is a more actively developed project: https://github.com/kingstinct/react-native-healthkit

tremblerz · 2025-01-02T15:01:44Z

Fixed the issue for me

colinharris05 · 2025-01-28T04:43:12Z

Friendly ping hoping to see this merged!

MarzyCoder · 2025-02-16T14:59:44Z

Same here! Please merge it! This simple fix fixes the problems with new arch for me!

MarzyCoder · 2025-02-16T15:02:28Z

Please help us and merge it :)
@GGGava @ruan-azevedo

MarzyCoder

Everything works fine!

D0Dam

👍

timtres-eylo · 2025-03-17T11:16:12Z

Please merge this one. Why is it still open?

sfkaos · 2025-03-27T02:07:43Z

Great job on this! would love to see it merged as well :)

shobith · 2025-04-03T05:28:54Z

when will this be merged?

MarzyCoder · 2025-04-03T06:21:58Z

when will this be merged?

To be honest, I think never 😄
I would choose another package..

shobith · 2025-04-03T16:10:23Z

when will this be merged?

To be honest, I think never 😄 I would choose another package..

any recommendations?? 😄

MarzyCoder · 2025-04-03T17:19:48Z

when will this be merged?

To be honest, I think never 😄 I would choose another package..

any recommendations?? 😄

I migrated to https://github.com/kingstinct/react-native-healthkit. Works very well!

Bridgeless architecture support for lazy loaded functions

22e4d0d

Ashalbulk reviewed Oct 30, 2024

View reviewed changes

Update index.js for bridgeless architecture compatibility

8386490

andrewzey requested a review from Ashalbulk October 31, 2024 23:09

Ashalbulk approved these changes Nov 1, 2024

View reviewed changes

fontesrp mentioned this pull request Nov 19, 2024

Warning: TypeError: _reactNativeHealth.default.initHealthKit is not a function (it is undefined) #399

Open

abdulbasiAmjeo approved these changes Nov 27, 2024

View reviewed changes

garywongzc approved these changes Dec 3, 2024

View reviewed changes

garywongzc added a commit to garywongzc/lucid-react-native-health that referenced this pull request Dec 11, 2024

Support bridgeless architecture lazy loaded functions - agencyenterpr…

8cb2d52

…ise#396

ghure approved these changes Dec 14, 2024

View reviewed changes

carozo approved these changes Dec 23, 2024

View reviewed changes

carozo reviewed Dec 24, 2024

View reviewed changes

tremblerz approved these changes Jan 2, 2025

View reviewed changes

MarzyCoder approved these changes Feb 16, 2025

View reviewed changes

D0Dam approved these changes Mar 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support bridgeless architecture lazy loaded functions #396

Support bridgeless architecture lazy loaded functions #396

andrewzey commented Oct 30, 2024

Ashalbulk left a comment •

edited

Loading

andrewzey commented Oct 31, 2024

willashley23 commented Nov 18, 2024

ben-edge commented Nov 21, 2024

garywongzc commented Dec 2, 2024

andrewzey commented Dec 2, 2024

garywongzc left a comment

garywongzc commented Dec 3, 2024

ghure commented Dec 14, 2024

ghure left a comment

carozo left a comment

bfblackjack commented Dec 29, 2024

fmmattioni commented Jan 2, 2025

tremblerz commented Jan 2, 2025

colinharris05 commented Jan 28, 2025

MarzyCoder commented Feb 16, 2025

MarzyCoder commented Feb 16, 2025

MarzyCoder left a comment

D0Dam left a comment

timtres-eylo commented Mar 17, 2025

sfkaos commented Mar 27, 2025

shobith commented Apr 3, 2025

MarzyCoder commented Apr 3, 2025

shobith commented Apr 3, 2025

MarzyCoder commented Apr 3, 2025

Support bridgeless architecture lazy loaded functions #396

Are you sure you want to change the base?

Support bridgeless architecture lazy loaded functions #396

Conversation

andrewzey commented Oct 30, 2024

Description

Type of change

Checklist:

Ashalbulk left a comment • edited Loading

Choose a reason for hiding this comment

andrewzey commented Oct 31, 2024

willashley23 commented Nov 18, 2024

ben-edge commented Nov 21, 2024

garywongzc commented Dec 2, 2024

andrewzey commented Dec 2, 2024

garywongzc left a comment

Choose a reason for hiding this comment

garywongzc commented Dec 3, 2024

ghure commented Dec 14, 2024

ghure left a comment

Choose a reason for hiding this comment

carozo left a comment

Choose a reason for hiding this comment

bfblackjack commented Dec 29, 2024

fmmattioni commented Jan 2, 2025

tremblerz commented Jan 2, 2025

colinharris05 commented Jan 28, 2025

MarzyCoder commented Feb 16, 2025

MarzyCoder commented Feb 16, 2025

MarzyCoder left a comment

Choose a reason for hiding this comment

D0Dam left a comment

Choose a reason for hiding this comment

timtres-eylo commented Mar 17, 2025

sfkaos commented Mar 27, 2025

shobith commented Apr 3, 2025

MarzyCoder commented Apr 3, 2025

shobith commented Apr 3, 2025

MarzyCoder commented Apr 3, 2025

Ashalbulk left a comment •

edited

Loading