Skip to content

Commit 8aff831

Browse files
authored
storage: tests: skip tests that CI does not have permissions for (#2395)
RE: googleapis/google-cloud-node#2224 @todo Revert this
1 parent 5893e9a commit 8aff831

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

system-test/storage.js

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ var Bucket = Storage.Bucket;
3535
var File = Storage.File;
3636

3737
describe('storage', function() {
38+
var IS_CI = env.projectId === 'long-door-651';
3839
var TESTS_PREFIX = 'gcloud-test-';
3940

4041
var storage = new Storage(env);
@@ -60,7 +61,7 @@ describe('storage', function() {
6061
});
6162

6263
after(function(done) {
63-
if (env.projectId === 'long-door-651') {
64+
if (IS_CI) {
6465
// The system tests account is unable to delete files.
6566
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
6667
done();
@@ -609,6 +610,12 @@ describe('storage', function() {
609610

610611
describe('bucket metadata', function() {
611612
it('should allow setting metadata on a bucket', function(done) {
613+
if (IS_CI) {
614+
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
615+
this.skip();
616+
return;
617+
}
618+
612619
var metadata = {
613620
website: {
614621
mainPageSuffix: 'http://fakeuri',
@@ -624,7 +631,8 @@ describe('storage', function() {
624631
});
625632
});
626633

627-
describe('write, read, and remove files', function() {
634+
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
635+
(IS_CI ? describe.skip : describe)('write/read/remove files', function() {
628636
before(function(done) {
629637
function setHash(filesKey, done) {
630638
var file = FILES[filesKey];
@@ -1066,7 +1074,8 @@ describe('storage', function() {
10661074
});
10671075
});
10681076

1069-
describe('combine files', function() {
1077+
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
1078+
(IS_CI ? describe.skip : describe)('combine files', function() {
10701079
it('should combine multiple files into one', function(done) {
10711080
var files = [
10721081
{ file: bucket.file('file-one.txt'), contents: '123' },
@@ -1098,7 +1107,8 @@ describe('storage', function() {
10981107
});
10991108
});
11001109

1101-
describe('list files', function() {
1110+
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
1111+
(IS_CI ? describe.skip : describe)('list files', function() {
11021112
var NEW_FILES = [
11031113
bucket.file('CloudLogo1'),
11041114
bucket.file('CloudLogo2'),
@@ -1252,7 +1262,7 @@ describe('storage', function() {
12521262
});
12531263
});
12541264

1255-
describe('sign urls', function() {
1265+
(IS_CI ? describe.skip : describe)('sign urls', function() {
12561266
var localFile = fs.readFileSync(FILES.logo.path);
12571267
var file;
12581268

@@ -1300,7 +1310,8 @@ describe('storage', function() {
13001310
});
13011311
});
13021312

1303-
describe('sign policy', function() {
1313+
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
1314+
(IS_CI ? describe.skip : describe)('sign policy', function() {
13041315
var file;
13051316

13061317
before(function(done) {

0 commit comments

Comments
 (0)