Skip to content

Limitations - Documenting behaviors of renaming the tool in the uploaded SARIF #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felickz opened this issue Mar 21, 2025 · 0 comments

Comments

@felickz
Copy link

felickz commented Mar 21, 2025

This method renames the CodeQL tool in the results, which breaks CodeQL Autofix and may affect other features of Code Scanning

Legacy Scans + Alert Closure

If a configuration is no longer utilized (EOL of a service in monorepo) and there is a shared piece of code that is scanned for each service - it is CRITICAL that the old tool CodeQL-EOLservice configuration is removed. Missing uploads of a tool will prevent an alert from closing even after the alert is remediated. Viewing the Affected branches can make this apparent, choose the 🗑️ symbol on the missing configuration.

Image

Autofix

CodeQL Autofixes are not generated when analyses are uploaded with a renamed tool

Tool Status Page

  • Code Scanning - Tool Status Page does not properly identify CodeQL as the intended tool and file coverage information is not shown

Image

  • If any of the jobs in a configuration fails to upload, you will see failing status for ALL "tools" that are scanning from the same job.

Image

Repo Rulesets

Enforcing Require code scanning results will require a configuration for every iteration of the tool name

@felickz felickz changed the title Limitations - Documenting behaviors Limitations - Documenting behaviors of renaming the tool in the uploaded SARIF Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant