Skip to content

Commit 3593e29

Browse files
committed
Remove check_version in common_functions.sh
- remove check_version function - remove set_version function - remove supported_versions resolves : #4949 Signed-off-by: Anna Babu Palathingal <[email protected]>
1 parent d4b2efe commit 3593e29

File tree

3 files changed

+22
-55
lines changed

3 files changed

+22
-55
lines changed

external/build_all.sh

+21-24
Original file line numberDiff line numberDiff line change
@@ -25,27 +25,24 @@ cleanup_images
2525
# Loop through all possible images
2626
for test in ${supported_tests}
2727
do
28-
for version in ${supported_versions}
29-
do
30-
for vm in ${supported_jvms}
31-
do
32-
for os in ${supported_os}
33-
do
34-
for package in ${supported_packages}
35-
do
36-
for build in ${supported_builds}
37-
do
38-
echo "==============================================================================="
39-
echo " "
40-
echo " Building Docker Images for ${test} ${version} ${vm} ${os} ${package} ${build} "
41-
echo " "
42-
echo "==============================================================================="
43-
$(dirname "$0")/build_image.sh ${test} ${version} ${vm} ${os} ${package} ${build}
44-
echo
45-
echo
46-
done
47-
done
48-
done
49-
done
50-
done
51-
done
28+
for vm in ${supported_jvms}
29+
do
30+
for os in ${supported_os}
31+
do
32+
for package in ${supported_packages}
33+
do
34+
for build in ${supported_builds}
35+
do
36+
echo "==============================================================================="
37+
echo " "
38+
echo " Building Docker Images for ${test} ${version} ${vm} ${os} ${package} ${build} "
39+
echo " "
40+
echo "==============================================================================="
41+
$(dirname "$0")/build_image.sh ${test} ${version} ${vm} ${os} ${package} ${build}
42+
echo
43+
echo
44+
done
45+
done
46+
done
47+
done
48+
done

external/build_image.sh

-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ if [ $# -ne 9 ] && [ $# -ne 10 ]; then
2424
echo
2525
echo "usage: $0 test version vm os package build platform check_external_custom"
2626
echo "test = ${supported_tests}"
27-
echo "version = ${supported_versions}"
2827
echo "vm = ${supported_jvms}"
2928
echo "os = ${supported_os}"
3029
echo "package = ${supported_packages}"
@@ -42,7 +41,6 @@ check_external_custom=$9
4241
if [[ "${check_external_custom}" == "0" ]]; then
4342
set_test $1
4443
fi
45-
set_version $2
4644
set_vm $3
4745
set_os $4
4846
set_package $5

external/common_functions.sh

+1-29
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414
#
15-
16-
# Supported versions
17-
supported_versions="8 11 17 21 22"
18-
1915
# Supported JVMs
2016
supported_jvms="hotspot openj9"
2117

@@ -32,30 +28,6 @@ supported_builds="full"
3228
# Supported tests
3329
supported_tests="external_custom camel criu-functional criu-portable-checkpoint criu-portable-restore criu-ubi-portable-checkpoint criu-ubi-portable-restore derby elasticsearch jacoco jenkins functional-test kafka lucene-solr openliberty-mp-tck payara-mp-tck quarkus quarkus_quickstarts scala system-test tomcat tomee wildfly wycheproof netty spring zookeeper"
3430

35-
function check_version() {
36-
version=$1
37-
38-
for current_version in ${supported_versions}
39-
do
40-
if [[ "${version}" == "${current_version}" ]]; then
41-
return 1
42-
fi
43-
done
44-
45-
return 0
46-
}
47-
48-
# Set a valid version
49-
function set_version() {
50-
version=$1
51-
52-
if (check_version ${version}); then
53-
echo "ERROR: Invalid Version: ${version}"
54-
echo "Usage: $0 [${supported_versions}]"
55-
exit 1
56-
fi
57-
}
58-
5931
function check_os() {
6032
os=$1
6133

@@ -213,7 +185,7 @@ function set_test_info() {
213185
check_external_custom_test=$2
214186
cd ../
215187
path_to_file=$(pwd)
216-
echo ${path_to_file}
188+
echo ${path_to_file}
217189
PROPERTY_FILE=${path_to_file}/${test}/test.properties
218190
github_url=$(getProperty "github_url")
219191
test_options=$(getProperty "test_options")

0 commit comments

Comments
 (0)