Skip to content

Commit bf9e4d8

Browse files
authored
Merge pull request #362 from adopted-ember-addons/ember-cli-update
Sync with latest addon blueprint
2 parents e7795f0 + bed68cf commit bf9e4d8

31 files changed

+28252
-24125
lines changed

.ember-cli

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
{
22
/**
3-
Ember CLI sends analytics information by default. The data is completely
4-
anonymous, but there are times when you might want to disable this behavior.
5-
6-
Setting `disableAnalytics` to true will prevent any data from being sent.
3+
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
4+
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
75
*/
8-
"disableAnalytics": false
6+
"isTypeScriptProject": false
97
}

.github/workflows/ci.yml

+31-19
Original file line numberDiff line numberDiff line change
@@ -7,59 +7,67 @@ on:
77
- master
88
pull_request: {}
99

10+
concurrency:
11+
group: ci-${{ github.head_ref || github.ref }}
12+
cancel-in-progress: true
13+
1014
jobs:
1115
test:
1216
name: "Tests"
1317
runs-on: ubuntu-latest
18+
timeout-minutes: 10
1419

1520
steps:
16-
- uses: actions/checkout@v2
21+
- uses: actions/checkout@v4
1722
- name: Install Node
18-
uses: actions/setup-node@v2
23+
uses: actions/setup-node@v4
1924
with:
20-
node-version: 18.x
25+
node-version: 18
2126
cache: npm
2227
- name: Install Dependencies
2328
run: npm ci
2429
- name: Lint
25-
run: npm run lint:js
30+
run: npm run lint
2631
- name: Run Tests
27-
run: npm run test
32+
run: npm run test:ember
2833

2934
floating:
3035
name: "Floating Dependencies"
3136
runs-on: ubuntu-latest
37+
timeout-minutes: 10
3238

3339
steps:
34-
- uses: actions/checkout@v2
35-
- uses: actions/setup-node@v2
40+
- uses: actions/checkout@v4
41+
- uses: actions/setup-node@v4
3642
with:
37-
node-version: 18.x
43+
node-version: 18
3844
cache: npm
3945
- name: Install Dependencies
4046
run: npm install --no-shrinkwrap
4147
- name: Run Tests
42-
run: npm run test
48+
run: npm run test:ember
4349

4450
blueprints:
4551
name: "Blueprints Tests"
4652
runs-on: ubuntu-latest
4753

4854
steps:
49-
- uses: actions/checkout@v2
50-
- uses: actions/setup-node@v2
55+
- uses: actions/checkout@v4
56+
- name: Install Node
57+
uses: actions/setup-node@v4
5158
with:
52-
node-version: 18.x
59+
node-version: 18
5360
cache: npm
5461
- name: Install Dependencies
55-
run: npm install --no-shrinkwrap
62+
run: npm ci
5663
- name: Run Tests
5764
run: npm run node-test
5865

5966
try-scenarios:
6067
name: ${{ matrix.try-scenario }}
6168
runs-on: ubuntu-latest
62-
needs: 'test'
69+
needs: "test"
70+
timeout-minutes: 10
6371

6472
strategy:
6573
fail-fast: false
@@ -68,20 +76,24 @@ jobs:
6876
- ember-lts-3.20
6977
- ember-lts-3.24
7078
- ember-lts-3.28
79+
- ember-lts-4.4
80+
- ember-lts-4.8
81+
- ember-lts-4.12
82+
- ember-lts-5.4
83+
- ember-lts-5.8
84+
- ember-lts-5.12
7185
- ember-release
7286
- ember-beta
7387
- ember-canary
74-
- ember-classic
75-
- ember-default-with-jquery
7688
- embroider-safe
7789
- embroider-optimized
7890

7991
steps:
80-
- uses: actions/checkout@v2
92+
- uses: actions/checkout@v4
8193
- name: Install Node
82-
uses: actions/setup-node@v2
94+
uses: actions/setup-node@v4
8395
with:
84-
node-version: 18.x
96+
node-version: 18
8597
cache: npm
8698
- name: Install Dependencies
8799
run: npm ci

.gitignore

+7-8
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,25 @@
1-
# See https://help.github.com/ignore-files/ for more about ignoring files.
2-
31
# compiled output
42
/dist/
5-
/tmp/
3+
/declarations/
64

75
# dependencies
8-
/bower_components/
96
/node_modules/
107

118
# misc
129
/.env*
1310
/.pnp*
14-
/.sass-cache
1511
/.eslintcache
16-
/connect.lock
1712
/coverage/
18-
/libpeerconnection.log
1913
/npm-debug.log*
2014
/testem.log
2115
/yarn-error.log
2216

2317
# ember-try
2418
/.node_modules.ember-try/
25-
/bower.json.ember-try
19+
/npm-shrinkwrap.json.ember-try
2620
/package.json.ember-try
21+
/package-lock.json.ember-try
22+
/yarn.lock.ember-try
23+
24+
# broccoli-debug
25+
/DEBUG/

.npmignore

+7-8
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
/dist/
33
/tmp/
44

5-
# dependencies
6-
/bower_components/
7-
85
# misc
9-
/.bowerrc
106
/.editorconfig
117
/.ember-cli
128
/.env*
@@ -18,23 +14,26 @@
1814
/.gitignore
1915
/.prettierignore
2016
/.prettierrc.js
17+
/.stylelintignore
18+
/.stylelintrc.js
2119
/.template-lintrc.js
2220
/.travis.yml
2321
/.watchmanconfig
24-
/assets/
25-
/bower.json
26-
/config/ember-try.js
2722
/CONTRIBUTING.md
2823
/CODE_OF_CONDUCT.md
2924
/ember-cli-build.js
3025
/node-test/
3126
/testem.js
3227
/tests/
28+
/tsconfig.declarations.json
29+
/tsconfig.json
3330
/yarn-error.log
3431
/yarn.lock
3532
.gitkeep
3633

3734
# ember-try
3835
/.node_modules.ember-try/
39-
/bower.json.ember-try
36+
/npm-shrinkwrap.json.ember-try
4037
/package.json.ember-try
38+
/package-lock.json.ember-try
39+
/yarn.lock.ember-try

.prettierignore

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,13 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
65
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
126

137
# misc
148
/coverage/
159
!.*
16-
.eslintcache
10+
.*/
1711

1812
# ember-try
1913
/.node_modules.ember-try/
20-
/bower.json.ember-try
21-
/package.json.ember-try

.prettierrc.cjs

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
'use strict';
22

33
module.exports = {
4-
singleQuote: true,
4+
overrides: [
5+
{
6+
files: '*.{cjs,mjs,js,ts}',
7+
options: {
8+
singleQuote: true,
9+
},
10+
},
11+
],
512
};

.stylelintignore

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# unconventional files
2+
/blueprints/*/files/
3+
4+
# compiled output
5+
/dist/
6+
7+
# addons
8+
/.node_modules.ember-try/

.stylelintrc.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
5+
};

.watchmanconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"ignore_dirs": ["tmp", "dist"]
2+
"ignore_dirs": ["dist"]
33
}

CONTRIBUTING.md

+16-6
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,24 @@ issue's number to the description of your pull-request.
4646

4747
## Installation
4848

49-
First clone this repository:
49+
- `git clone https://github.com/adopted-ember-addons/ember-changeset-validations.git`
50+
- `cd ember-changeset-validations`
51+
- `npm install`
5052

51-
```sh
52-
git clone https://github.com/poteto/ember-changeset-validations.git
53-
```
53+
## Linting
5454

55-
<!-- Add further details on how to install the project here -->
55+
- `npm run lint`
56+
- `npm run lint:fix`
5657

5758
## Running tests
5859

59-
<!-- Tell the user how to run the tests of your project -->
60+
- `npm run test` – Runs the test suite on the current Ember version
61+
- `npm run test:ember -- --server` – Runs the test suite in "watch mode"
62+
- `npm run test:ember-compatibility` – Runs the test suite against multiple Ember versions
63+
64+
## Running the dummy application
65+
66+
- `npm run start`
67+
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).
68+
69+
For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

README.md

+4-19
Original file line numberDiff line numberDiff line change
@@ -577,25 +577,10 @@ We're grateful to these wonderful contributors who've contributed to `ember-chan
577577

578578
[//]: contributor-faces
579579

580-
## Installation
580+
## Contributing
581581

582-
* `git clone <repository-url>` this repository
583-
* `cd ember-changeset-validations`
584-
* `npm install`
582+
See the [Contributing](CONTRIBUTING.md) guide for details.
585583

586-
## Running
584+
## License
587585

588-
* `ember serve`
589-
* Visit your app at [http://localhost:4200](http://localhost:4200).
590-
591-
## Running Tests
592-
593-
* `npm test` (Runs `ember try:each` to test your addon against multiple Ember versions)
594-
* `ember test`
595-
* `ember test --server`
596-
597-
## Building
598-
599-
* `ember build`
600-
601-
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
586+
This project is licensed under the [MIT License](LICENSE.md).

0 commit comments

Comments
 (0)