use npm to download extension dependencies

Author: zaggino

package.json

@@ -12,6 +12,9 @@
         "branch": "",
         "SHA": ""
     },
+    "dependencies": {
+        "npm": "2.15.10"
+    },
     "devDependencies": {
         "grunt": "0.4.1",
         "jasmine-node": "1.11.0",

src/extensibility/node/ExtensionManagerDomain.js

@@ -32,6 +32,7 @@ var semver   = require("semver"),
     request  = require("request"),
     fs       = require("fs-extra"),
     temp     = require("temp"),
+    npm      = require("npm"),
     validate = require("./package-validator").validate;
 
 // Automatically clean up temp files on exit
@@ -99,17 +100,61 @@ function _performInstall(packagePath, installDirectory, validationResult, callba
         var sourceDir = path.join(validationResult.extractDir, validationResult.commonPrefix);
 
         fs.copy(sourceDir, installDirectory, function (err) {
-            if (err) {
+
+            var fail = function (err) {
                 _removeFailedInstallation(installDirectory);
                 callback(err, null);
-            } else {
+            };
+
+            var finish = function () {
                 // The status may have already been set previously (as in the
                 // DISABLED case.
                 if (!validationResult.installationStatus) {
                     validationResult.installationStatus = Statuses.INSTALLED;
                 }
                 callback(null, validationResult);
+            };
+
+            if (err) {
+                fail(err);
+                return;
+            }
+
+            var packageJson,
+                npmDependencies;
+
+            try {
+                packageJson = JSON.parse(fs.readFileSync(path.join(installDirectory, "package.json"), {
+                    encoding: "utf8"
+                }));
+            } catch (e) {
+                packageJson = null;
+            }
+
+            if (packageJson && packageJson.dependencies) {
+                npmDependencies = Object.keys(packageJson.dependencies).map(function (key) {
+                    return key + "@" + packageJson.dependencies[key];
+                });
             }
+
+            if (npmDependencies && npmDependencies.length > 0) {
+                npm.load(function (err, npm) {
+                    if (err) {
+                        fail(err);
+                        return;
+                    }
+                    npm.commands.install(installDirectory, npmDependencies, function (err, result) {
+                        if (err) {
+                            fail(err);
+                            return;
+                        }
+                        finish();
+                    });
+                });
+            } else {
+                finish();
+            }
+
         });
     });
 }
@@ -264,7 +309,7 @@ function _cmdInstall(packagePath, destinationDirectory, options, callback, _doUp
                 return;
             }
         }
-        
+
         // The "legacy" stuff should go away after all of the commonly used extensions
         // have been upgraded with package.json files.
         var hasLegacyPackage = validationResult.metadata && legacyPackageCheck(legacyDirectory);

src/extensibility/node/spec/Installation.spec.js

@@ -56,7 +56,8 @@ var basicValidExtension       = path.join(testFilesDirectory, "basic-valid-exten
     missingPackageJSON        = path.join(testFilesDirectory, "missing-package-json.zip"),
     missingPackageJSONUpdate  = path.join(testFilesDirectory, "missing-package-json-update.zip"),
     missingPackageJSONRenamed = path.join(testFilesDirectory, "added-package-json-test", "missing-package-json.zip"),
-    withSymlink               = path.join(testFilesDirectory, "with-symlink.zip");
+    withSymlink               = path.join(testFilesDirectory, "with-symlink.zip"),
+    withNpmDependencies       = path.join(testFilesDirectory, "with-npm-dependencies.zip");
 
 
 describe("Package Installation", function () {
@@ -325,4 +326,30 @@ describe("Package Installation", function () {
             done();
         });
     });
+    
+    it("should download npm dependencies when present", function (done) {
+        ExtensionsDomain._cmdInstall(withNpmDependencies, installDirectory, standardOptions, function (err, result) {
+            expect(err).toBeNull();
+            expect(result.errors.length).toEqual(0);
+            expect(fs.existsSync(result.installedTo)).toBe(true);
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules"))).toBe(true);
+            
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "lodash"))).toBe(true);
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "lodash", "package.json"))).toBe(true);
+            var packageInfo = JSON.parse(fs.readFileSync(path.join(result.installedTo, "node_modules", "lodash", "package.json")));
+            expect(packageInfo.version.slice(0,2)).toBe("3.");
+            
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "moment"))).toBe(true);
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "moment", "package.json"))).toBe(true);
+            packageInfo = JSON.parse(fs.readFileSync(path.join(result.installedTo, "node_modules", "moment", "package.json")));
+            expect(packageInfo.version.slice(0,4)).toBe("2.5.");
+            
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "underscore"))).toBe(true);
+            expect(fs.existsSync(path.join(result.installedTo, "node_modules", "underscore", "package.json"))).toBe(true);
+            packageInfo = JSON.parse(fs.readFileSync(path.join(result.installedTo, "node_modules", "underscore", "package.json")));
+            expect(packageInfo.version).toBe("1.0.4");
+            
+            done();
+        });
+    });
 });