Merge branch 'MiguelCastillo-master' (PR #5919)

Author: dangoor

src/extensibility/node/package-validator.js

@@ -309,7 +309,10 @@ function extractAndValidateFiles(zipPath, extractDir, options, callback) {
     });
 
     unzipper.extract({
-        path: extractDir
+        path: extractDir,
+        filter: function (file) {
+            return file.type !== "SymbolicLink";
+        }
     });
 }
 

src/extensibility/node/spec/Installation.spec.js

@@ -55,7 +55,9 @@ var basicValidExtension       = path.join(testFilesDirectory, "basic-valid-exten
     invalidZip                = path.join(testFilesDirectory, "invalid-zip-file.zip"),
     missingPackageJSON        = path.join(testFilesDirectory, "missing-package-json.zip"),
     missingPackageJSONUpdate  = path.join(testFilesDirectory, "missing-package-json-update.zip"),
-    missingPackageJSONRenamed = path.join(testFilesDirectory, "added-package-json-test", "missing-package-json.zip");
+    missingPackageJSONRenamed = path.join(testFilesDirectory, "added-package-json-test", "missing-package-json.zip"),
+    withSymlink            = path.join(testFilesDirectory, "with-symlink.zip");
+
 
 describe("Package Installation", function () {
 
@@ -315,4 +317,14 @@ describe("Package Installation", function () {
             });
         });
     });
+    
+    it("should strip out symlinks in the zipfile", function (done) {
+        ExtensionsDomain._cmdInstall(withSymlink, installDirectory, standardOptions, function (err, result) {
+            expect(err).toBeNull();
+            expect(result.errors.length).toEqual(0);
+            expect(fs.existsSync(result.installedTo)).toBe(true);
+            expect(fs.existsSync(path.join(result.installedTo, "bin", "foo"))).toBe(false);
+            done();
+        });
+    });
 });