Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 2da7ddb

Browse files
saurabh95swmitra
authored andcommitted
Now reverse inspect can be disabled by setting the livedev.wsPort to 0 (#13659)
* Now reverse inspect can be disabled by setting the livedev.wsPort to 0 * Add new preference to optionally disable reverse inspect feature in live preview
1 parent 9065cb9 commit 2da7ddb

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/LiveDevelopment/LiveDevelopment.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,10 @@ define(function LiveDevelopment(require, exports, module) {
201201
PreferencesManager.definePreference("livedev.wsPort", "number", 8125, {
202202
description: Strings.DESCRIPTION_LIVEDEV_WEBSOCKET_PORT
203203
});
204+
205+
PreferencesManager.definePreference("livedev.enableReverseInspect", "boolean", true, {
206+
description: Strings.DESCRIPTION_LIVEDEV_ENABLE_REVERSE_INSPECT
207+
});
204208

205209
function _isPromisePending(promise) {
206210
return promise && promise.state() === "pending";
@@ -1369,7 +1373,12 @@ define(function LiveDevelopment(require, exports, module) {
13691373
// wait for server (StaticServer, Base URL or file:)
13701374
prepareServerPromise
13711375
.done(function () {
1372-
WebSocketTransport.createWebSocketServer(PreferencesManager.get("livedev.wsPort"));
1376+
var reverseInspectPref = PreferencesManager.get("livedev.enableReverseInspect"),
1377+
wsPort = PreferencesManager.get("livedev.wsPort");
1378+
1379+
if (wsPort && reverseInspectPref) {
1380+
WebSocketTransport.createWebSocketServer(wsPort);
1381+
}
13731382
_doLaunchAfterServerReady(doc);
13741383
})
13751384
.fail(function () {

src/nls/root/strings.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,5 +807,6 @@ define({
807807
"DESCRIPTION_INDENT_LINE_COMMENT" : "true to enable indenting of line comments",
808808
"DESCRIPTION_RECENT_FILES_NAV" : "Enable/disable navigation in recent files",
809809
"DESCRIPTION_LIVEDEV_WEBSOCKET_PORT" : "Port on which WebSocket Server runs for Live Preview",
810-
"DESCRIPTION_LIVE_DEV_HIGHLIGHT_SETTINGS" : "Live Preview Highlight settings"
810+
"DESCRIPTION_LIVE_DEV_HIGHLIGHT_SETTINGS" : "Live Preview Highlight settings",
811+
"DESCRIPTION_LIVEDEV_ENABLE_REVERSE_INSPECT" : "false to disable live preview reverse inpsect"
811812
});

0 commit comments

Comments
 (0)