Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 1e495ed

Browse files
committed
use webpack to bundle semver which doesnt provide amd build
1 parent 76a9d22 commit 1e495ed

File tree

7 files changed

+129
-84
lines changed

7 files changed

+129
-84
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,5 @@ Thumbs.db
3939
# Files that can be automatically downloaded that we don't want to ship with our builds
4040
/src/extensibility/node/node_modules/request/tests/
4141

42+
# Files build by scripts
43+
/src/thirdparty/semver.browser.js

Gruntfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ module.exports = function (grunt) {
323323
});
324324

325325
// task: install
326-
grunt.registerTask('install', ['write-config', 'less', 'npm-install-extensions']);
326+
grunt.registerTask('install', ['write-config', 'less', 'pack-web-dependencies', 'npm-install-extensions']);
327327

328328
// task: test
329329
grunt.registerTask('test', ['eslint', 'jasmine', 'nls-check']);

npm-shrinkwrap.json

Lines changed: 72 additions & 80 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@
4949
"q": "1.4.1",
5050
"rewire": "1.1.2",
5151
"xmldoc": "^0.1.2",
52-
"grunt-cleanempty": "1.0.3"
52+
"grunt-cleanempty": "1.0.3",
53+
"webpack": "1.13.3"
5354
},
5455
"scripts": {
5556
"postinstall": "grunt install",

src/config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@
7272
"q": "1.4.1",
7373
"rewire": "1.1.2",
7474
"xmldoc": "^0.1.2",
75-
"grunt-cleanempty": "1.0.3"
75+
"grunt-cleanempty": "1.0.3",
76+
"webpack": "1.13.3"
7677
},
7778
"scripts": {
7879
"postinstall": "grunt install",

src/extensibility/ExtensionManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ define(function (require, exports, module) {
5252
ThemeManager = require("view/ThemeManager");
5353

5454
// semver.browser is an AMD-compatible module
55-
var semver = require("extensibility/node/node_modules/semver/semver.browser");
55+
var semver = require("thirdparty/semver.browser");
5656

5757
/**
5858
* @private

0 commit comments

Comments
 (0)