Merge pull request #325 from jsoverson/fail-build-steps

jasonsanjose · jasonsanjose · commit 9dbf0826321f · 2013-09-06T16:23:50.000-07:00
Failing with useful message on mac build step
diff --git a/tasks/build.js b/tasks/build.js
@@ -60,7 +60,12 @@ module.exports = function (grunt) {
         spawn([
             "xcodebuild -project appshell.xcodeproj -config Release clean",
             "xcodebuild -project appshell.xcodeproj -config Release build"
-        ]).then(function () {
+        ]).then(function (result) {
+            if (result.stderr.match('xcrun: Error')) {
+              grunt.log.error('Unable to run : ' + result.cmd + ' ' + result.args.join(' '));
+              grunt.log.error(result.stderr);
+              return done(false);
+            }
             done();
         }, function (err) {
             grunt.log.error(err);
diff --git a/tasks/common.js b/tasks/common.js
@@ -185,6 +185,8 @@ module.exports = function (grunt) {
                 }
                 child.on("close", function (code) {
                     var closeResult = {
+                        cmd: cmd,
+                        args: args,
                         code: code,
                         stdout: stdout.toString(),
                         stderr: stderr.toString(),

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,8 @@ module.exports = function (grunt) {`
`185`	`185`	`}`
`186`	`186`	`child.on("close", function (code) {`
`187`	`187`	`var closeResult = {`
	`188`	`+ cmd: cmd,`
	`189`	`+ args: args,`
`188`	`190`	`code: code,`
`189`	`191`	`stdout: stdout.toString(),`
`190`	`192`	`stderr: stderr.toString(),`