Merge pull request #72 from ficristo/eslint

Use ESLint too, and start to use it on travis

Author: zaggino

.brackets.json

@@ -4,11 +4,19 @@
         "plusplus": true,
         "devel": true,
         "nomen": true,
+        "indent": 4,
         "maxerr": 50,
         "es5": true,
-        "node": true
+        "node": true,
+        "regexp": true
     },
     "defaultExtension": "js",
+    "language": {
+        "javascript": {
+            "linting.prefer": ["ESLint", "JSLint"],
+            "linting.usePreferredOnly": true
+        }
+    },
     "spaceUnits": 4,
     "useTabChar": false
 }

.eslintrc.json

@@ -0,0 +1,46 @@
+{
+    "env": {
+        "node": true
+    },
+    "rules": {
+        "no-bitwise": 2,
+        "curly": 2,
+        "eqeqeq": 2,
+        "guard-for-in": 0,
+        "wrap-iife": [2, "outside"],
+        "no-use-before-define": 2,
+        "new-cap": 2,
+        "no-caller": 2,
+        "no-empty": 2,
+        "no-new": 2,
+        "no-invalid-regexp": 2,
+        "no-control-regex": 2,
+        "no-regex-spaces": 2,
+        "no-undef": 2,
+        "strict": 2,
+        "no-unused-vars": [0, {"vars": "all", "args": "none"}],
+        "semi": 2,
+
+        "no-iterator": 2,
+        "no-loop-func": 2,
+        "no-multi-str": 2,
+        "no-fallthrough": 2,
+        "no-proto": 2,
+        "no-script-url": 2,
+        "no-shadow": 0,
+        "no-shadow-restricted-names": 2,
+        "no-new-func": 2,
+        "no-new-wrappers": 2,
+        "no-new-require": 2,
+        "new-parens": 2,
+        "no-new-object": 2,
+        "no-invalid-this": 0,
+        "indent": [2, 4],
+
+        "valid-jsdoc": 0,
+        "valid-typeof": 2,
+
+        "no-trailing-spaces": [0, { "skipBlankLines": true }],
+        "eol-last": 2
+    }
+}

lib/downloadData.js

@@ -50,4 +50,4 @@ function _collectDownloadedData(req, res) {
     }
 }
 
-exports.collectDownloadedData = _collectDownloadedData;
+exports.collectDownloadedData = _collectDownloadedData;

lib/filestorage.js

@@ -115,4 +115,4 @@ FileStorage.prototype = {
     }
 };
 
-exports.Storage = FileStorage;
+exports.Storage = FileStorage;

lib/ramstorage.js

@@ -77,4 +77,4 @@ RAMStorage.prototype = {
     }
 };
 
-exports.Storage = RAMStorage;
+exports.Storage = RAMStorage;

lib/registry_utils.js

@@ -125,12 +125,12 @@ exports.authorInfo = function () {
  *
  * @return {string} An URI to download the extension
  */
-exports.formatDownloadURL = function(baseURL, name, version) {
+exports.formatDownloadURL = function (baseURL, name, version) {
     var urlEncodedName = encodeURIComponent(name),
         urlEncodedNameAndVersion = encodeURIComponent(name + "-" + version + ".zip");
 
     return baseURL + "/" + urlEncodedName + "/" + urlEncodedNameAndVersion;
-}
+};
 
 /**
  * Returns an array of current registry entries, sorted by the publish date of the latest version of each entry.

lib/s3storage.js

@@ -200,4 +200,4 @@ S3Storage.prototype = {
     }
 };
 
-exports.Storage = S3Storage;
+exports.Storage = S3Storage;

package.json

@@ -7,8 +7,9 @@
   "scripts": {
     "preinstall": "npm install deps/*",
     "start": "node app",
-    "test": "istanbul test node_modules/jasmine-node/bin/jasmine-node spec",
-    "jslint": "./node_modules/.bin/jslint ./downloadStats/*.js ./spec/*.js ./lib/*.js"
+    "lint": "eslint ./downloadStats/*.js ./spec/*.js ./lib/*.js ./public/js/main.js",
+    "pretest": "npm run lint",
+    "test": "istanbul test node_modules/jasmine-node/bin/jasmine-node spec"
   },
   "issues": {
     "url": "http://github.com/adobe/brackets-registry/issues"
@@ -39,10 +40,10 @@
     "commander": "~2.1.0"
   },
   "devDependencies": {
+    "eslint": "~2.13.1",
     "fs-extra": "~0.30.0",
     "istanbul": "~0.4.5",
     "jasmine-node": "~1.14.5",
-    "jslint": "~0.5.0",
     "rewire": "~2.5.2"
   }
 }

public/js/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+    "extends": "../../.eslintrc.json",
+    "env": {
+        "node": false
+    }
+}

spec/logfileProcessor.spec.js

@@ -296,4 +296,4 @@ describe("LogfileProcessor", function () {
             });
         });
     });
-});
+});