Skip to content

Commit a1ffdce

Browse files
tofarradityasoni9998
authored andcommitted
Enable the multi conversation UI for all users (All-Hands-AI#6374)
1 parent 2988b10 commit a1ffdce

File tree

5 files changed

+10
-19
lines changed

5 files changed

+10
-19
lines changed

frontend/__tests__/routes/_oh.app.test.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { screen, waitFor } from "@testing-library/react";
55
import toast from "react-hot-toast";
66
import App from "#/routes/_oh.app/route";
77
import OpenHands from "#/api/open-hands";
8-
import { MULTI_CONVERSATION_UI } from "#/utils/feature-flags";
98

109
describe("App", () => {
1110
const RouteStub = createRoutesStub([
@@ -35,7 +34,7 @@ describe("App", () => {
3534
await screen.findByTestId("app-route");
3635
});
3736

38-
it.skipIf(!MULTI_CONVERSATION_UI)(
37+
it(
3938
"should call endSession if the user does not have permission to view conversation",
4039
async () => {
4140
const errorToastSpy = vi.spyOn(toast, "error");

frontend/src/components/features/sidebar/sidebar.tsx

+8-11
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { SettingsModal } from "#/components/shared/modals/settings/settings-moda
1515
import { useCurrentSettings } from "#/context/settings-context";
1616
import { useSettings } from "#/hooks/query/use-settings";
1717
import { ConversationPanel } from "../conversation-panel/conversation-panel";
18-
import { MULTI_CONVERSATION_UI } from "#/utils/feature-flags";
1918
import { useEndSession } from "#/hooks/use-end-session";
2019
import { setCurrentAgentState } from "#/state/agent-slice";
2120
import { AgentState } from "#/types/agent-state";
@@ -78,16 +77,14 @@ export function Sidebar() {
7877
<AllHandsLogoButton onClick={handleEndSession} />
7978
</div>
8079
<ExitProjectButton onClick={handleEndSession} />
81-
{MULTI_CONVERSATION_UI && (
82-
<TooltipButton
83-
testId="toggle-conversation-panel"
84-
tooltip="Conversations"
85-
ariaLabel="Conversations"
86-
onClick={() => setConversationPanelIsOpen((prev) => !prev)}
87-
>
88-
<FaListUl size={22} />
89-
</TooltipButton>
90-
)}
80+
<TooltipButton
81+
testId="toggle-conversation-panel"
82+
tooltip="Conversations"
83+
ariaLabel="Conversations"
84+
onClick={() => setConversationPanelIsOpen((prev) => !prev)}
85+
>
86+
<FaListUl size={22} />
87+
</TooltipButton>
9188
<DocsButton />
9289
</div>
9390

frontend/src/routes/_oh.app/route.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import { useUserConversation } from "#/hooks/query/use-user-conversation";
3434
import { ServedAppLabel } from "#/components/layout/served-app-label";
3535
import { TerminalStatusLabel } from "#/components/features/terminal/terminal-status-label";
3636
import { useSettings } from "#/hooks/query/use-settings";
37-
import { MULTI_CONVERSATION_UI } from "#/utils/feature-flags";
3837
import { clearFiles, clearInitialPrompt } from "#/state/initial-query-slice";
3938
import { RootState } from "#/store";
4039

@@ -66,7 +65,7 @@ function AppContent() {
6665
);
6766

6867
React.useEffect(() => {
69-
if (MULTI_CONVERSATION_UI && isFetched && !conversation) {
68+
if (isFetched && !conversation) {
7069
toast.error(
7170
"This conversation does not exist, or you do not have permission to access it.",
7271
);

frontend/src/utils/feature-flags.ts

-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ function loadFeatureFlag(
1212
}
1313
}
1414

15-
export const MULTI_CONVERSATION_UI = loadFeatureFlag("MULTI_CONVERSATION_UI");
1615
export const MEMORY_CONDENSER = loadFeatureFlag("MEMORY_CONDENSER");

frontend/tests/conversation-panel.test.ts

-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ const selectConversationCard = async (page: Page, index: number) => {
3131

3232
test.beforeEach(async ({ page }) => {
3333
await page.goto("/");
34-
await page.evaluate(() => {
35-
localStorage.setItem("FEATURE_MULTI_CONVERSATION_UI", "true");
36-
});
3734
});
3835

3936
test("should only display the create new conversation button when in a conversation", async ({

0 commit comments

Comments
 (0)